Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot

[Takashi Iwai <tiwai@suse.de>]

On Sun, 14 May 2023 23:48:55 +0200,
Joseph C. Sible wrote:
> 
> On 5/14/23, Takashi Iwai wrote:
> > The patch changes two places (the change in alc_shutup_pins() and
> > alc256_shutup()), and I guess the latter is the culprit.  Could you
> > verify that only reverting the latter fixes the problem?
> 
> Yes, only reverting the latter fixes the problem. I just tried a
> kernel consisting of 6.3.2 plus the below change, and it works fine:
> 
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -3638,8 +3638,7 @@ static void alc256_shutup(struct hda_codec *codec)
>         /* If disable 3k pulldown control for alc257, the Mic
> detection will not work correctly
>          * when booting with headset plugged. So skip setting it for
> the codec alc257
>          */
> -       if (codec->core.vendor_id != 0x10ec0236 &&
> -           codec->core.vendor_id != 0x10ec0257)
> +       if (codec->core.vendor_id != 0x10ec0257)
>                 alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
> 
>         if (!spec->no_shutup_pins)

OK, thanks for confirmation.

Kailang, could you check this issue?
Judging from the comment there:

	/* 3k pull low control for Headset jack. */
	/* NOTE: call this before clearing the pin, otherwise codec stalls */
	/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
	 * when booting with headset plugged. So skip setting it for the codec alc257
	 */

... it seems that the codec got screwed with this setup, which leaded
to the non-response at the probe after reboot.

In the worst case, I'll revert that part.


thanks,

Takashi