Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot

[Bagas Sanjaya <bagasdotme@gmail.com>]

On 5/15/23 04:48, Joseph C. Sible wrote:
> On 5/14/23, Takashi Iwai wrote:
>> The patch changes two places (the change in alc_shutup_pins() and
>> alc256_shutup()), and I guess the latter is the culprit.  Could you
>> verify that only reverting the latter fixes the problem?
> 
> Yes, only reverting the latter fixes the problem. I just tried a
> kernel consisting of 6.3.2 plus the below change, and it works fine:
> 
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -3638,8 +3638,7 @@ static void alc256_shutup(struct hda_codec *codec)
>         /* If disable 3k pulldown control for alc257, the Mic
> detection will not work correctly
>          * when booting with headset plugged. So skip setting it for
> the codec alc257
>          */
> -       if (codec->core.vendor_id != 0x10ec0236 &&
> -           codec->core.vendor_id != 0x10ec0257)
> +       if (codec->core.vendor_id != 0x10ec0257)
>                 alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
> 
>         if (!spec->no_shutup_pins)
> 

Thanks for the fixup. Can you send it as proper patch for review?
See Documentation/process/submitting-patches.rst for instructions.

-- 
An old man doll... just what I always wanted! - Clara