Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot

[Takashi Iwai <tiwai@suse.de>]

On Thu, 25 May 2023 11:21:38 +0200,
Kailang wrote:
> 
> 
> 
> > -----Original Message-----
> > From: Takashi Iwai <tiwai@suse.de>
> > Sent: Wednesday, May 24, 2023 6:17 PM
> > To: Kailang <kailang@realtek.com>
> > Cc: Joseph C. Sible <josephcsible@gmail.com>; Bagas Sanjaya
> > <bagasdotme@gmail.com>; regressions@lists.linux.dev; perex@perex.cz;
> > tiwai@suse.com; alsa-devel@alsa-project.org
> > Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP
> > 15z-fc000 on warm boot
> > 
> > 
> > External mail.
> > 
> > 
> > 
> > On Thu, 18 May 2023 07:44:23 +0200,
> > Kailang wrote:
> > >
> > > > -----Original Message-----
> > > > From: Takashi Iwai <tiwai@suse.de>
> > > > Sent: Monday, May 15, 2023 9:40 PM
> > > > To: Joseph C. Sible <josephcsible@gmail.com>
> > > > Cc: Bagas Sanjaya <bagasdotme@gmail.com>;
> > > > regressions@lists.linux.dev; Kailang <kailang@realtek.com>;
> > > > perex@perex.cz; tiwai@suse.com; alsa-devel@alsa-project.org
> > > > Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP
> > > > 15z-fc000 on warm boot
> > > >
> > > >
> > > > External mail.
> > > >
> > > >
> > > >
> > > > On Sun, 14 May 2023 23:48:55 +0200,
> > > > Joseph C. Sible wrote:
> > > > >
> > > > > On 5/14/23, Takashi Iwai wrote:
> > > > > > The patch changes two places (the change in alc_shutup_pins()
> > > > > > and alc256_shutup()), and I guess the latter is the culprit.
> > > > > > Could you verify that only reverting the latter fixes the problem?
> > > > >
> > > > > Yes, only reverting the latter fixes the problem. I just tried a
> > > > > kernel consisting of 6.3.2 plus the below change, and it works fine:
> > > > >
> > > > > --- a/sound/pci/hda/patch_realtek.c
> > > > > +++ b/sound/pci/hda/patch_realtek.c
> > > > > @@ -3638,8 +3638,7 @@ static void alc256_shutup(struct hda_codec
> > > > *codec)
> > > > >         /* If disable 3k pulldown control for alc257, the Mic
> > > > > detection will not work correctly
> > > > >          * when booting with headset plugged. So skip setting it
> > > > > for the codec alc257
> > > > >          */
> > > > > -       if (codec->core.vendor_id != 0x10ec0236 &&
> > > > > -           codec->core.vendor_id != 0x10ec0257)
> > > > > +       if (codec->core.vendor_id != 0x10ec0257)
> > > > >                 alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
> > > > >
> > > > >         if (!spec->no_shutup_pins)
> > > >
> > > > OK, thanks for confirmation.
> > > >
> > > > Kailang, could you check this issue?
> > >
> > > OK. I will take it a look for these days.
> > 
> > Kailang, any chance to get this fixed?
> Sorry! My test machine didn't work. I couldn't have a machine to do this test.
> But I find one ChromeBook with ALC236 today.

Thanks!

I already submitted a PR to Linus for 6.4-rc4, and the next PR will be
likely in two weeks, so we have a bit of time :)


Takashi