* [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match spec
@ 2007-12-14 16:48 Andrew Paprocki
2007-12-17 9:24 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Paprocki @ 2007-12-14 16:48 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai
AC_KNBCAP_DELTA is incorrectly defined as (1<<8). According to the Intel
HDA spec, this is bit 7 after AC_KNBCAP_NUM_STEPS which is a 0x7f mask.
Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
diff -r 4a204306b295 -r 3681a8bf780e pci/hda/hda_codec.h
--- a/pci/hda/hda_codec.h Fri Dec 14 14:42:41 2007 +0100
+++ b/pci/hda/hda_codec.h Fri Dec 14 12:27:35 2007 -0500
@@ -234,7 +234,7 @@ enum {
/* Volume knobs capabilities */
#define AC_KNBCAP_NUM_STEPS (0x7f<<0)
-#define AC_KNBCAP_DELTA (1<<8)
+#define AC_KNBCAP_DELTA (1<<7)
/*
* Control Parameters
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match spec
2007-12-14 16:48 [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match spec Andrew Paprocki
@ 2007-12-17 9:24 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2007-12-17 9:24 UTC (permalink / raw)
To: Andrew Paprocki; +Cc: alsa-devel
At Fri, 14 Dec 2007 12:48:00 -0400,
Andrew Paprocki wrote:
>
> AC_KNBCAP_DELTA is incorrectly defined as (1<<8). According to the Intel
> HDA spec, this is bit 7 after AC_KNBCAP_NUM_STEPS which is a 0x7f mask.
>
> Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
Applied to HG tree now. Thanks.
Takashi
>
> diff -r 4a204306b295 -r 3681a8bf780e pci/hda/hda_codec.h
> --- a/pci/hda/hda_codec.h Fri Dec 14 14:42:41 2007 +0100
> +++ b/pci/hda/hda_codec.h Fri Dec 14 12:27:35 2007 -0500
> @@ -234,7 +234,7 @@ enum {
>
> /* Volume knobs capabilities */
> #define AC_KNBCAP_NUM_STEPS (0x7f<<0)
> -#define AC_KNBCAP_DELTA (1<<8)
> +#define AC_KNBCAP_DELTA (1<<7)
>
> /*
> * Control Parameters
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-17 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-14 16:48 [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match spec Andrew Paprocki
2007-12-17 9:24 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox