Re: [PATCH 44/44] drm/amdgpu/vcn: use dev_info() for firmware information

[Boyuan Zhang <Boyuan.Zhang@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]


On 2025-01-31 11:57, Alex Deucher wrote:
> To properly handle multiple GPUs.
>
> Signed-off-by: Alex Deucher<alexander.deucher@amd.com>


Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com> 
<mailto:Boyuan.Zhang@amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> index edbcb11c382a2..8d8b39e6d197a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> @@ -182,7 +182,8 @@ int amdgpu_vcn_sw_init(struct amdgpu_device *adev, int i)
>   		enc_major = fw_check;
>   		dec_ver = (le32_to_cpu(hdr->ucode_version) >> 24) & 0xf;
>   		vep = (le32_to_cpu(hdr->ucode_version) >> 28) & 0xf;
> -		DRM_INFO("Found VCN firmware Version ENC: %u.%u DEC: %u VEP: %u Revision: %u\n",
> +		dev_info(adev->dev,
> +			 "Found VCN firmware Version ENC: %u.%u DEC: %u VEP: %u Revision: %u\n",
>   			 enc_major, enc_minor, dec_ver, vep, fw_rev);
>   	} else {
>   		unsigned int version_major, version_minor, family_id;
> @@ -190,7 +191,7 @@ int amdgpu_vcn_sw_init(struct amdgpu_device *adev, int i)
>   		family_id = le32_to_cpu(hdr->ucode_version) & 0xff;
>   		version_major = (le32_to_cpu(hdr->ucode_version) >> 24) & 0xff;
>   		version_minor = (le32_to_cpu(hdr->ucode_version) >> 8) & 0xff;
> -		DRM_INFO("Found VCN firmware Version: %u.%u Family ID: %u\n",
> +		dev_info(adev->dev, "Found VCN firmware Version: %u.%u Family ID: %u\n",
>   			 version_major, version_minor, family_id);
>   	}
>   

[-- Attachment #2: Type: text/html, Size: 2662 bytes --]