From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/amdgpu/mes: enable compute pipes across all MEC
Date: Thu, 20 Mar 2025 16:44:45 +0530 [thread overview]
Message-ID: <1ca6101f-e746-4909-885b-071a995b4bee@amd.com> (raw)
In-Reply-To: <20250319190850.3899718-2-alexander.deucher@amd.com>
On 3/20/2025 12:38 AM, Alex Deucher wrote:
> Enable pipes on both MECs for MES.
>
> Fixes: 745f46b6a99f ("drm/amdgpu: enable mes v12 self test")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> index 10f14bf925778..ac9b1708e20d8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> @@ -130,8 +130,7 @@ int amdgpu_mes_init(struct amdgpu_device *adev)
> }
>
> for (i = 0; i < AMDGPU_MES_MAX_COMPUTE_PIPES; i++) {
> - /* use only 1st MEC pipes */
> - if (i >= adev->gfx.mec.num_pipe_per_mec)
> + if (i >= (adev->gfx.mec.num_pipe_per_mec * adev->gfx.mec.num_mec))
Same comment as in patch 1.
Thanks,
Lijo
> break;
> adev->mes.compute_hqd_mask[i] = 0xc;
> }
next prev parent reply other threads:[~2025-03-20 11:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 19:08 [PATCH 1/4] drm/amdgpu/mes: optimize compute loop handling Alex Deucher
2025-03-19 19:08 ` [PATCH 2/4] drm/amdgpu/mes: enable compute pipes across all MEC Alex Deucher
2025-03-20 10:17 ` Liang, Prike
2025-03-20 11:14 ` Lazar, Lijo [this message]
2025-03-20 13:00 ` Alex Deucher
2025-03-19 19:08 ` [PATCH 3/4] drm/amdgpu/mes: drop MES 10.x leftovers Alex Deucher
2025-03-20 10:20 ` Liang, Prike
2025-03-19 19:08 ` [PATCH 4/4] drm/amdgpu/mes: clean up SDMA HQD loop Alex Deucher
2025-03-20 12:06 ` Liang, Prike
2025-03-20 10:14 ` [PATCH 1/4] drm/amdgpu/mes: optimize compute loop handling Liang, Prike
2025-03-20 11:14 ` Lazar, Lijo
2025-03-20 12:13 ` Liang, Prike
2025-03-20 12:51 ` Alex Deucher
2025-03-20 13:44 ` Lazar, Lijo
2025-03-20 13:53 ` Alex Deucher
2025-03-20 14:21 ` Lazar, Lijo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ca6101f-e746-4909-885b-071a995b4bee@amd.com \
--to=lijo.lazar@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox