Re: [PATCH 1/4] drm/amdgpu/mes: optimize compute loop handling

["Lazar, Lijo" <lijo.lazar@amd.com>]

On 3/20/2025 12:38 AM, Alex Deucher wrote:
> Break when we get to the end of the supported pipes
> rather than continuing the loop.
> 
> Reviewed-by: Shaoyun.liu <Shaoyun.liu@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> index 3b83880f9e2cc..10f14bf925778 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> @@ -132,7 +132,7 @@ int amdgpu_mes_init(struct amdgpu_device *adev)
>  	for (i = 0; i < AMDGPU_MES_MAX_COMPUTE_PIPES; i++) {

Unless I'm not seeing something, why not just keep it i <
adev->gfx.mec.num_pipe_per_mec?

Thanks,
Lijo

>  		/* use only 1st MEC pipes */
>  		if (i >= adev->gfx.mec.num_pipe_per_mec)
> -			continue;
> +			break;
>  		adev->mes.compute_hqd_mask[i] = 0xc;
>  	}
>