AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 03/10] drm/amdgpu: init rlc save restore as long as the lists exist
Date: Thu, 5 Jul 2018 17:09:28 +0800	[thread overview]
Message-ID: <20180705090935.9638-3-evan.quan@amd.com> (raw)
In-Reply-To: <20180705090935.9638-1-evan.quan-5C7GfCeVMHo@public.gmane.org>

It does not have to be rlc v2_1 and pg enabled. For rlc v2_0, rlc
save restore is also needed. And pg support is definitely not a
must for rlc save restore.

Change-Id: I85c0e3525ca7fb385c3d0b9e5abc13708c91e795
Signed-off-by: Evan Quan <evan.quan@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 2f6ac255203f..8d895afa6c69 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -2184,8 +2184,13 @@ static void gfx_v9_0_init_pg(struct amdgpu_device *adev)
 {
 	gfx_v9_0_init_csb(adev);
 
-	if (!adev->gfx.rlc.is_rlc_v2_1)
-		return;
+	/* init rlc save restore as long as the lists exist */
+	if (adev->gfx.rlc.reg_list_format_size_bytes &&
+	    adev->gfx.rlc.reg_list_size_bytes &&
+	    adev->gfx.rlc.reg_restore_list_size) {
+		gfx_v9_1_init_rlc_save_restore_list(adev);
+		gfx_v9_0_enable_save_restore_machine(adev);
+	}
 
 	if (adev->pg_flags & (AMD_PG_SUPPORT_GFX_PG |
 			      AMD_PG_SUPPORT_GFX_SMG |
@@ -2193,9 +2198,6 @@ static void gfx_v9_0_init_pg(struct amdgpu_device *adev)
 			      AMD_PG_SUPPORT_CP |
 			      AMD_PG_SUPPORT_GDS |
 			      AMD_PG_SUPPORT_RLC_SMU_HS)) {
-		gfx_v9_1_init_rlc_save_restore_list(adev);
-		gfx_v9_0_enable_save_restore_machine(adev);
-
 		WREG32(mmRLC_JUMP_TABLE_RESTORE,
 		       adev->gfx.rlc.cp_table_gpu_addr >> 8);
 		gfx_v9_0_init_gfx_power_gating(adev);
-- 
2.18.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-07-05  9:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  9:09 [PATCH 01/10] drm/amdgpu: pin the csb buffer on hw init Evan Quan
     [not found] ` <20180705090935.9638-1-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-05  9:09   ` [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and pg status Evan Quan
     [not found]     ` <20180705090935.9638-2-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-09  3:56       ` Quan, Evan
     [not found]         ` <SN6PR12MB265670B1B3AAC47773CBA7A9E4440-kxOKjb6HO/FeL/N0e1LXkAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-10 17:17           ` Alex Deucher
2018-07-05  9:09   ` Evan Quan [this message]
     [not found]     ` <20180705090935.9638-3-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-05 15:19       ` [PATCH 03/10] drm/amdgpu: init rlc save restore as long as the lists exist Huang Rui
2018-07-06  9:14         ` Quan, Evan
2018-07-06 10:14       ` Huang Rui
2018-07-09  3:46         ` Quan, Evan
2018-07-05  9:09   ` [PATCH 04/10] drm/amdgpu: correct direct reg list length for v2_0 rlc Evan Quan
     [not found]     ` <20180705090935.9638-4-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-05 15:06       ` Huang Rui
2018-07-09  4:00         ` Quan, Evan
2018-07-05  9:09   ` [PATCH 05/10] drm/amdgpu: drop mmRLC_PG_CNTL clear Evan Quan
     [not found]     ` <20180705090935.9638-5-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-05 15:07       ` Huang Rui
2018-07-05 15:33       ` Alex Deucher
     [not found]         ` <CADnq5_Mkjuj9hLahht=s70wwXKNqnRcaFMJNjOjR8HSh_DWpUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-06 10:04           ` Huang Rui
2018-07-05  9:09   ` [PATCH 06/10] drm/amdgpu: no touch for the reserved bit of RLC_CGTT_MGCG_OVERRIDE Evan Quan
     [not found]     ` <20180705090935.9638-6-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-09  4:06       ` Quan, Evan
     [not found]         ` <SN6PR12MB2656F298CDBE1A2607BA5B36E4440-kxOKjb6HO/FeL/N0e1LXkAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-10 17:18           ` Alex Deucher
2018-07-05  9:09   ` [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has to wait before request CGCG Evan Quan
     [not found]     ` <20180705090935.9638-7-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-09  4:06       ` Quan, Evan
     [not found]         ` <SN6PR12MB2656009EA5F895E6F2B399B5E4440-kxOKjb6HO/FeL/N0e1LXkAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-10 17:19           ` Alex Deucher
     [not found]             ` <CADnq5_NhmSk62EE3VG+V-=9M-pWZo-jJzzrLKL_K0By2_OaQ7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-11  6:44               ` Quan, Evan
2018-07-05  9:09   ` [PATCH 08/10] drm/amdgpu: use the accessible target rlc safe mode Apis directly Evan Quan
     [not found]     ` <20180705090935.9638-8-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-09  4:08       ` Quan, Evan
     [not found]         ` <SN6PR12MB26569BE03C4B86F63E161B94E4440-kxOKjb6HO/FeL/N0e1LXkAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-10 17:23           ` Alex Deucher
     [not found]             ` <CADnq5_OkzpNCaGBNsB5uOCutr9+m6szm6O6QpmkoEvBSh7Ux5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-11  6:44               ` Quan, Evan
2018-07-05  9:09   ` [PATCH 09/10] drm/amd/powerplay: add vega12 SMU gfxoff support Evan Quan
     [not found]     ` <20180705090935.9638-9-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-05 15:21       ` Huang Rui
2018-07-05  9:09   ` [PATCH 10/10] drm/amd/powerplay: no need to mask workable gfxoff feature for vega12 Evan Quan
     [not found]     ` <20180705090935.9638-10-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-09  4:36       ` Quan, Evan
     [not found]         ` <SN6PR12MB2656713C37BA977A41CB04CEE4440-kxOKjb6HO/FeL/N0e1LXkAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-10 17:24           ` Alex Deucher
2018-07-05 15:25   ` [PATCH 01/10] drm/amdgpu: pin the csb buffer on hw init Huang Rui
2018-07-05 15:25     ` Alex Deucher
     [not found]       ` <CADnq5_ObbDpsjt1-gC5oOJLe-89jU2L1VBs4sOr1-4tgq8n=3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-06  9:10         ` Quan, Evan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705090935.9638-3-evan.quan@amd.com \
    --to=evan.quan-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox