AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: "Christian König" <christian.koenig@amd.com>,
	"Alex Deucher" <alexdeucher@gmail.com>
Cc: amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com
Subject: Re: [PATCH 7/7] drm/amdgpu/gfx6: Support harvested SI chips with disabled TCCs
Date: Fri, 17 Apr 2026 16:09:02 +0200	[thread overview]
Message-ID: <2835381.vuYhMxLoTh@timur-max> (raw)
In-Reply-To: <CADnq5_My527aN+SHpv5YvDCU5u3og8PwPoW7OuzXdc-ZvGRX9A@mail.gmail.com>

On 2026. április 17., péntek 15:36:20 közép-európai nyári idő Alex Deucher 
wrote:
> > > +static void gfx_v6_0_setup_tcc(struct amdgpu_device *adev)
> > > +{
> > > +     u32 i, tcc, tcp_addr_config, num_active_tcc = 0;
> > > +     u64 chan_steer, patched_chan_steer = 0;
> > > +     const u32 num_max_tcc =
> > > adev->gfx.config.max_texture_channel_caches;
> > > +     const u32 dis_tcc_mask = amdgpu_gfx_create_bitmask(num_max_tcc) &
> > > +                              REG_GET_FIELD(RREG32(mmCGTS_TCC_DISABLE),
> > > +                                            CGTS_TCC_DISABLE,
> > > TCC_DISABLE);
> I would OR dis_tcc_mask with mmCGTS_USER_TCC_DISABLE as well in case
> someone has set additional TCCs to disable as well.  Other than that,
> looks good to me.

Thank you, will do.

I'll split off the VCE patches into a separate series and send a second version 
of this series with the consideration for CGTS_USER_TCC_DISABLE added.

Timur



      reply	other threads:[~2026-04-17 14:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 20:26 [PATCH 0/7] Various SI fixes, fix Radeon HD 7870 XT Timur Kristóf
2026-04-16 20:26 ` [PATCH 1/7] drm/amdgpu/gmc: Fix AMDGPU_GART_PLACEMENT_LOW to not overlap with VRAM Timur Kristóf
2026-04-17 10:58   ` Christian König
2026-04-16 20:26 ` [PATCH 2/7] drm/amdgpu/vce: Align VCPU BO to a power of two address Timur Kristóf
2026-04-17  7:08   ` Christian König
2026-04-16 20:26 ` [PATCH 3/7] drm/amdgpu: Add alignment to amdgpu_gtt_mgr_alloc_entries() Timur Kristóf
2026-04-16 20:26 ` [PATCH 4/7] drm/amdgpu/vce1: Fix workaround to ensure low 32-bit VCPU address Timur Kristóf
2026-04-17  7:21   ` Christian König
2026-04-16 20:26 ` [PATCH 5/7] drm/amdgpu/uvd3.1: Don't validate the firmware when already validated Timur Kristóf
2026-04-17  7:22   ` Christian König
2026-04-16 20:26 ` [PATCH 6/7] Documentation/gpu: Add TCC, update TCP in amdgpu glossary Timur Kristóf
2026-04-17  7:24   ` Christian König
2026-04-17  8:36     ` Timur Kristóf
2026-04-17  9:03       ` Christian König
2026-04-16 20:26 ` [PATCH 7/7] drm/amdgpu/gfx6: Support harvested SI chips with disabled TCCs Timur Kristóf
2026-04-17 12:56   ` Christian König
2026-04-17 13:36     ` Alex Deucher
2026-04-17 14:09       ` Timur Kristóf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2835381.vuYhMxLoTh@timur-max \
    --to=timur.kristof@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox