From: Greg KH <gregkh@linuxfoundation.org>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Cc: robh@kernel.org, ckoenig.leichtzumerken@gmail.com,
dri-devel@lists.freedesktop.org, eric@anholt.net,
ppaalanen@gmail.com, amd-gfx@lists.freedesktop.org,
daniel.vetter@ffwll.ch, Alexander.Deucher@amd.com,
yuq825@gmail.com, Harry.Wentland@amd.com, l.stach@pengutronix.de
Subject: Re: [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr
Date: Tue, 19 Jan 2021 08:34:48 +0100 [thread overview]
Message-ID: <YAaLmBMlDRr56erH@kroah.com> (raw)
In-Reply-To: <1611003683-3534-11-git-send-email-andrey.grodzovsky@amd.com>
On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote:
> static struct pci_driver amdgpu_kms_pci_driver = {
> .name = DRIVER_NAME,
> .id_table = pciidlist,
> @@ -1595,6 +1607,7 @@ static struct pci_driver amdgpu_kms_pci_driver = {
> .shutdown = amdgpu_pci_shutdown,
> .driver.pm = &amdgpu_pm_ops,
> .err_handler = &amdgpu_pci_err_handler,
> + .driver.dev_groups = amdgpu_sysfs_groups,
Shouldn't this just be:
groups - amdgpu_sysfs_groups,
Why go to the "driver root" here?
Other than that tiny thing, looks good to me, nice cleanup!
greg k-h
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-19 8:37 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 21:01 [PATCH v4 00/14] RFC Support hot device unplug in amdgpu Andrey Grodzovsky
2021-01-18 21:01 ` [PATCH v4 01/14] drm/ttm: Remap all page faults to per process dummy page Andrey Grodzovsky
2021-01-18 21:48 ` Alex Deucher
2021-01-19 8:41 ` Christian König
2021-01-19 13:56 ` Daniel Vetter
2021-01-25 15:28 ` Andrey Grodzovsky
2021-01-27 14:29 ` Andrey Grodzovsky
2021-02-02 14:21 ` Daniel Vetter
2021-01-18 21:01 ` [PATCH v4 02/14] drm: Unamp the entire device address space on device unplug Andrey Grodzovsky
2021-01-18 21:01 ` [PATCH v4 03/14] drm/ttm: Expose ttm_tt_unpopulate for driver use Andrey Grodzovsky
2021-01-18 21:01 ` [PATCH v4 04/14] drm/sched: Cancel and flush all oustatdning jobs before finish Andrey Grodzovsky
2021-01-18 21:49 ` Alex Deucher
2021-01-19 8:42 ` Christian König
2021-01-19 9:50 ` Christian König
2021-01-18 21:01 ` [PATCH v4 05/14] drm/amdgpu: Split amdgpu_device_fini into early and late Andrey Grodzovsky
2021-01-19 8:45 ` Christian König
2021-01-18 21:01 ` [PATCH v4 06/14] drm/amdgpu: Add early fini callback Andrey Grodzovsky
2021-01-18 21:01 ` [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device Andrey Grodzovsky
2021-01-18 21:52 ` Alex Deucher
2021-01-19 8:48 ` Christian König
2021-01-19 13:45 ` Daniel Vetter
2021-01-19 21:21 ` Andrey Grodzovsky
2021-01-19 22:01 ` Daniel Vetter
2021-01-20 4:21 ` Andrey Grodzovsky
2021-01-20 8:38 ` Daniel Vetter
[not found] ` <1a5f7ccb-1f91-91be-1cb1-e7cb43ac2c13@amd.com>
2021-01-21 10:48 ` Daniel Vetter
2021-01-20 5:01 ` Andrey Grodzovsky
2021-01-20 19:38 ` Andrey Grodzovsky
2021-01-21 10:42 ` Christian König
2021-01-18 21:01 ` [PATCH v4 08/14] drm/amdgpu: Fix a bunch of sdma code crash post device unplug Andrey Grodzovsky
2021-01-19 8:51 ` Christian König
2021-01-18 21:01 ` [PATCH v4 09/14] drm/amdgpu: Remap all page faults to per process dummy page Andrey Grodzovsky
2021-01-19 8:52 ` Christian König
2021-01-18 21:01 ` [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr Andrey Grodzovsky
2021-01-19 7:34 ` Greg KH [this message]
2021-01-19 16:36 ` Andrey Grodzovsky
2021-01-19 17:47 ` Greg KH
2021-01-19 19:04 ` Alex Deucher
2021-01-19 19:16 ` Andrey Grodzovsky
2021-01-19 19:41 ` Greg KH
2021-01-19 8:53 ` Christian König
2021-01-18 21:01 ` [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal Andrey Grodzovsky
2021-01-19 8:55 ` Christian König
2021-01-19 15:35 ` Andrey Grodzovsky
2021-01-19 15:39 ` Christian König
2021-01-19 18:05 ` Daniel Vetter
2021-01-19 18:22 ` Andrey Grodzovsky
2021-01-19 18:59 ` Christian König
2021-01-19 19:16 ` Andrey Grodzovsky
2021-01-20 19:34 ` Andrey Grodzovsky
2021-01-28 17:23 ` Andrey Grodzovsky
2021-01-29 15:16 ` Christian König
2021-01-29 17:35 ` Andrey Grodzovsky
2021-01-29 19:25 ` Christian König
2021-02-05 16:22 ` Andrey Grodzovsky
2021-02-05 22:10 ` Daniel Vetter
2021-02-05 23:09 ` Andrey Grodzovsky
2021-02-06 14:18 ` Daniel Vetter
2021-02-07 21:28 ` Andrey Grodzovsky
2021-02-07 21:50 ` Daniel Vetter
2021-02-08 9:37 ` Christian König
2021-02-08 9:48 ` Daniel Vetter
2021-02-08 10:03 ` Christian König
2021-02-08 10:11 ` Daniel Vetter
2021-02-08 13:59 ` Christian König
2021-02-08 16:23 ` Daniel Vetter
2021-02-08 22:15 ` Andrey Grodzovsky
2021-02-09 7:58 ` Christian König
2021-02-09 14:30 ` Andrey Grodzovsky
2021-02-09 15:40 ` Christian König
2021-02-10 22:01 ` Andrey Grodzovsky
2021-02-12 15:00 ` Andrey Grodzovsky
2021-02-08 22:09 ` Andrey Grodzovsky
2021-02-09 8:27 ` Christian König
2021-02-09 9:46 ` Daniel Vetter
2021-01-18 21:01 ` [PATCH v4 12/14] drm/scheduler: Job timeout handler returns status Andrey Grodzovsky
2021-01-19 7:53 ` Christian König
2021-01-19 17:47 ` Luben Tuikov
2021-01-19 18:53 ` Christian König
2021-01-18 21:01 ` [PATCH v4 13/14] drm/sched: Make timeout timer rearm conditional Andrey Grodzovsky
2021-01-18 21:01 ` [PATCH v4 14/14] drm/amdgpu: Prevent any job recoveries after device is unplugged Andrey Grodzovsky
2021-01-19 14:16 ` [PATCH v4 00/14] RFC Support hot device unplug in amdgpu Daniel Vetter
2021-01-19 17:31 ` Andrey Grodzovsky
2021-01-19 18:08 ` Daniel Vetter
2021-01-19 18:18 ` Andrey Grodzovsky
2021-01-20 9:05 ` Daniel Vetter
2021-01-20 14:19 ` Andrey Grodzovsky
2021-01-20 15:59 ` Daniel Vetter
2021-02-08 5:59 ` Andrey Grodzovsky
2021-02-08 7:27 ` Daniel Vetter
2021-02-09 4:01 ` Andrey Grodzovsky
2021-02-09 9:50 ` Daniel Vetter
2021-02-09 15:34 ` Andrey Grodzovsky
2021-02-18 20:03 ` Andrey Grodzovsky
2021-02-19 10:24 ` Daniel Vetter
2021-02-24 16:30 ` Andrey Grodzovsky
2021-02-25 10:25 ` Daniel Vetter
2021-02-25 16:12 ` Andrey Grodzovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAaLmBMlDRr56erH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Alexander.Deucher@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrey.grodzovsky@amd.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=l.stach@pengutronix.de \
--cc=ppaalanen@gmail.com \
--cc=robh@kernel.org \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox