Re: [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr

From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>
Cc: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Qiang Yu" <yuq825@gmail.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>
Subject: Re: [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr
Date: Tue, 19 Jan 2021 14:16:04 -0500	[thread overview]
Message-ID: <d3c3ebd9-e887-7f2a-16dd-cc6841fffdf9@amd.com> (raw)
In-Reply-To: <CADnq5_PNFQ+3tmRXjY2m22Pnx=neqMC_PTtqrObrdeg0LQUo_w@mail.gmail.com>

On 1/19/21 2:04 PM, Alex Deucher wrote:
> On Tue, Jan 19, 2021 at 1:26 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Tue, Jan 19, 2021 at 11:36:01AM -0500, Andrey Grodzovsky wrote:
>>> On 1/19/21 2:34 AM, Greg KH wrote:
>>>> On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote:
>>>>>    static struct pci_driver amdgpu_kms_pci_driver = {
>>>>>            .name = DRIVER_NAME,
>>>>>            .id_table = pciidlist,
>>>>> @@ -1595,6 +1607,7 @@ static struct pci_driver amdgpu_kms_pci_driver = {
>>>>>            .shutdown = amdgpu_pci_shutdown,
>>>>>            .driver.pm = &amdgpu_pm_ops,
>>>>>            .err_handler = &amdgpu_pci_err_handler,
>>>>> + .driver.dev_groups = amdgpu_sysfs_groups,
>>>> Shouldn't this just be:
>>>>      groups - amdgpu_sysfs_groups,
>>>>
>>>> Why go to the "driver root" here?
>>>
>>> Because I still didn't get to your suggestion to propose a patch to add groups to
>>> pci_driver, it's located in 'base' driver struct.
>> You are a pci driver, you should never have to mess with the "base"
>> driver struct.  Look at commit 92d50fc1602e ("PCI/IB: add support for
>> pci driver attribute groups") which got merged in 4.14, way back in
>> 2017 :)
> Per the previous discussion of this patch set:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.mail-archive.com%2Famd-gfx%40lists.freedesktop.org%2Fmsg56019.html&amp;data=04%7C01%7CAndrey.Grodzovsky%40amd.com%7C1b43efdc8a164169eee508d8bcad1ece%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637466799090087255%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=T462j96qC%2BXCZzgnJMG%2BbUEOG94GVuqkvTWfUB%2B3%2Fl8%3D&amp;reserved=0
>
> Alex

Got it, Next iteration I will include a patch like the above to pci-devel as 
part of the series and will update this patch accordingly.

Andrey

>
>> driver.pm also looks odd, but I'm just going to ignore that for now...
>>
>> thanks,
>>
>> greg k-h
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=04%7C01%7CAndrey.Grodzovsky%40amd.com%7C1b43efdc8a164169eee508d8bcad1ece%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637466799090087255%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=reQqTGFCsEXvHOmSt8c4B6idrotIS4Q69WKw%2FRtpAEg%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx