* [Bpf] [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed
2024-01-31 3:37 [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed Dave Thaler
@ 2024-01-31 3:37 ` Dave Thaler
2024-01-31 18:44 ` Yonghong Song
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Dave Thaler @ 2024-01-31 3:37 UTC (permalink / raw)
To: bpf; +Cc: bpf, Dave Thaler
As discussed in mailing list discussion at
https://mailarchive.ietf.org/arch/msg/bpf/5LnnKm093cGpOmDI9TnLQLBXyys/
this patch updates the "Legacy BPF Packet access instructions"
section to clarify which instructions are deprecated (vs which
were never defined and so are not deprecated).
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
---
Documentation/bpf/standardization/instruction-set.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
index af43227b6..cf08337bf 100644
--- a/Documentation/bpf/standardization/instruction-set.rst
+++ b/Documentation/bpf/standardization/instruction-set.rst
@@ -635,7 +635,9 @@ Legacy BPF Packet access instructions
-------------------------------------
BPF previously introduced special instructions for access to packet data that were
-carried over from classic BPF. However, these instructions are
+carried over from classic BPF. These instructions used an instruction
+class of BPF_LD, a size modifier of BPF_W, BPF_H, or BPF_B, and a
+mode modifier of BPF_ABS or BPF_IND. However, these instructions are
deprecated and should no longer be used. All legacy packet access
instructions belong to the "legacy" conformance group instead of the "basic"
conformance group.
--
2.40.1
--
Bpf mailing list
Bpf@ietf.org
https://www.ietf.org/mailman/listinfo/bpf
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed
2024-01-31 3:37 [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed Dave Thaler
2024-01-31 3:37 ` [Bpf] " Dave Thaler
@ 2024-01-31 18:44 ` Yonghong Song
2024-01-31 18:44 ` [Bpf] " Yonghong Song
2024-01-31 19:02 ` David Vernet
2024-02-01 10:40 ` patchwork-bot+netdevbpf
3 siblings, 1 reply; 7+ messages in thread
From: Yonghong Song @ 2024-01-31 18:44 UTC (permalink / raw)
To: Dave Thaler, bpf; +Cc: bpf, Dave Thaler
On 1/30/24 7:37 PM, Dave Thaler wrote:
> As discussed in mailing list discussion at
> https://mailarchive.ietf.org/arch/msg/bpf/5LnnKm093cGpOmDI9TnLQLBXyys/
> this patch updates the "Legacy BPF Packet access instructions"
> section to clarify which instructions are deprecated (vs which
> were never defined and so are not deprecated).
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed
2024-01-31 3:37 [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed Dave Thaler
2024-01-31 3:37 ` [Bpf] " Dave Thaler
2024-01-31 18:44 ` Yonghong Song
@ 2024-01-31 19:02 ` David Vernet
2024-01-31 19:02 ` [Bpf] " David Vernet
2024-02-01 10:40 ` patchwork-bot+netdevbpf
3 siblings, 1 reply; 7+ messages in thread
From: David Vernet @ 2024-01-31 19:02 UTC (permalink / raw)
To: Dave Thaler; +Cc: bpf, bpf, Dave Thaler
[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]
On Tue, Jan 30, 2024 at 07:37:59PM -0800, Dave Thaler wrote:
> As discussed in mailing list discussion at
> https://mailarchive.ietf.org/arch/msg/bpf/5LnnKm093cGpOmDI9TnLQLBXyys/
> this patch updates the "Legacy BPF Packet access instructions"
> section to clarify which instructions are deprecated (vs which
> were never defined and so are not deprecated).
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Acked-by: David Vernet <void@manifault.com>
> ---
> Documentation/bpf/standardization/instruction-set.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
> index af43227b6..cf08337bf 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -635,7 +635,9 @@ Legacy BPF Packet access instructions
> -------------------------------------
>
> BPF previously introduced special instructions for access to packet data that were
> -carried over from classic BPF. However, these instructions are
> +carried over from classic BPF. These instructions used an instruction
> +class of BPF_LD, a size modifier of BPF_W, BPF_H, or BPF_B, and a
> +mode modifier of BPF_ABS or BPF_IND. However, these instructions are
> deprecated and should no longer be used. All legacy packet access
> instructions belong to the "legacy" conformance group instead of the "basic"
> conformance group.
> --
> 2.40.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Bpf] [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed
2024-01-31 19:02 ` David Vernet
@ 2024-01-31 19:02 ` David Vernet
0 siblings, 0 replies; 7+ messages in thread
From: David Vernet @ 2024-01-31 19:02 UTC (permalink / raw)
To: Dave Thaler; +Cc: bpf, bpf, Dave Thaler
[-- Attachment #1.1: Type: text/plain, Size: 1569 bytes --]
On Tue, Jan 30, 2024 at 07:37:59PM -0800, Dave Thaler wrote:
> As discussed in mailing list discussion at
> https://mailarchive.ietf.org/arch/msg/bpf/5LnnKm093cGpOmDI9TnLQLBXyys/
> this patch updates the "Legacy BPF Packet access instructions"
> section to clarify which instructions are deprecated (vs which
> were never defined and so are not deprecated).
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Acked-by: David Vernet <void@manifault.com>
> ---
> Documentation/bpf/standardization/instruction-set.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
> index af43227b6..cf08337bf 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -635,7 +635,9 @@ Legacy BPF Packet access instructions
> -------------------------------------
>
> BPF previously introduced special instructions for access to packet data that were
> -carried over from classic BPF. However, these instructions are
> +carried over from classic BPF. These instructions used an instruction
> +class of BPF_LD, a size modifier of BPF_W, BPF_H, or BPF_B, and a
> +mode modifier of BPF_ABS or BPF_IND. However, these instructions are
> deprecated and should no longer be used. All legacy packet access
> instructions belong to the "legacy" conformance group instead of the "basic"
> conformance group.
> --
> 2.40.1
>
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 76 bytes --]
--
Bpf mailing list
Bpf@ietf.org
https://www.ietf.org/mailman/listinfo/bpf
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed
2024-01-31 3:37 [PATCH bpf-next] bpf, docs: Clarify which legacy packet instructions existed Dave Thaler
` (2 preceding siblings ...)
2024-01-31 19:02 ` David Vernet
@ 2024-02-01 10:40 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-01 10:40 UTC (permalink / raw)
To: Dave Thaler; +Cc: bpf, bpf, dthaler1968
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Tue, 30 Jan 2024 19:37:59 -0800 you wrote:
> As discussed in mailing list discussion at
> https://mailarchive.ietf.org/arch/msg/bpf/5LnnKm093cGpOmDI9TnLQLBXyys/
> this patch updates the "Legacy BPF Packet access instructions"
> section to clarify which instructions are deprecated (vs which
> were never defined and so are not deprecated).
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
>
> [...]
Here is the summary with links:
- [bpf-next] bpf, docs: Clarify which legacy packet instructions existed
https://git.kernel.org/bpf/bpf-next/c/088a464ed53f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread