From: Andrea Righi <arighi@nvidia.com>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Joel Fernandes <joelagnelf@nvidia.com>, Tejun Heo <tj@kernel.org>,
David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>, Shuah Khan <shuah@kernel.org>
Cc: sched-ext@lists.linux.dev, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 11/16] sched/deadline: Allow to initialize DL server when needed
Date: Wed, 3 Sep 2025 11:33:37 +0200 [thread overview]
Message-ID: <20250903095008.162049-12-arighi@nvidia.com> (raw)
In-Reply-To: <20250903095008.162049-1-arighi@nvidia.com>
When switching between fair and sched_ext, we need to initialize the
bandwidth contribution of the DL server independently for each class.
Add support for on-demand initialization to handle such transitions.
Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
kernel/sched/deadline.c | 36 +++++++++++++++++++++++++++++-------
kernel/sched/sched.h | 1 +
2 files changed, 30 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 165b12553e10d..b744187ec6372 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1583,6 +1583,32 @@ void dl_server_update(struct sched_dl_entity *dl_se, s64 delta_exec)
}
}
+/**
+ * dl_server_init_params - Initialize bandwidth reservation for a DL server
+ * @dl_se: The DL server entity to remove bandwidth for
+ *
+ * This function initializes the bandwidth reservation for a DL server
+ * entity, its bandwidth accounting and server state.
+ *
+ * Returns: 0 on success, negative error code on failure
+ */
+int dl_server_init_params(struct sched_dl_entity *dl_se)
+{
+ u64 runtime = 50 * NSEC_PER_MSEC;
+ u64 period = 1000 * NSEC_PER_MSEC;
+ int err;
+
+ err = dl_server_apply_params(dl_se, runtime, period, 1);
+ if (err)
+ return err;
+
+ dl_se->dl_server = 1;
+ dl_se->dl_defer = 1;
+ setup_new_dl_entity(dl_se);
+
+ return err;
+}
+
void dl_server_start(struct sched_dl_entity *dl_se)
{
struct rq *rq = dl_se->rq;
@@ -1638,8 +1664,7 @@ void sched_init_dl_servers(void)
struct sched_dl_entity *dl_se;
for_each_online_cpu(cpu) {
- u64 runtime = 50 * NSEC_PER_MSEC;
- u64 period = 1000 * NSEC_PER_MSEC;
+ int err;
rq = cpu_rq(cpu);
@@ -1649,11 +1674,8 @@ void sched_init_dl_servers(void)
WARN_ON(dl_server(dl_se));
- dl_server_apply_params(dl_se, runtime, period, 1);
-
- dl_se->dl_server = 1;
- dl_se->dl_defer = 1;
- setup_new_dl_entity(dl_se);
+ err = dl_server_init_params(dl_se);
+ WARN_ON_ONCE(err);
}
}
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 928874ab9b2db..1fbf4ffbcb208 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -395,6 +395,7 @@ extern void ext_server_init(struct rq *rq);
extern void __dl_server_attach_root(struct sched_dl_entity *dl_se, struct rq *rq);
extern int dl_server_apply_params(struct sched_dl_entity *dl_se,
u64 runtime, u64 period, bool init);
+extern int dl_server_init_params(struct sched_dl_entity *dl_se);
extern int dl_server_remove_params(struct sched_dl_entity *dl_se);
static inline bool dl_server_active(struct sched_dl_entity *dl_se)
--
2.51.0
next prev parent reply other threads:[~2025-09-03 9:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 9:33 [PATCHSET v8 sched_ext/for-6.18] Add a deadline server for sched_ext tasks Andrea Righi
2025-09-03 9:33 ` [PATCH 01/16] sched_ext: Exit early on hotplug events during attach Andrea Righi
2025-09-03 19:44 ` Tejun Heo
2025-09-03 21:40 ` Andrea Righi
2025-09-03 9:33 ` [PATCH 02/16] sched/debug: Fix updating of ppos on server write ops Andrea Righi
2025-09-03 9:33 ` [PATCH 03/16] sched/debug: Stop and start server based on if it was active Andrea Righi
2025-09-03 14:43 ` Juri Lelli
2025-09-03 15:02 ` Andrea Righi
2025-09-03 9:33 ` [PATCH 04/16] sched/deadline: Clear the defer params Andrea Righi
2025-09-03 14:44 ` Juri Lelli
2025-09-03 9:33 ` [PATCH 05/16] sched/deadline: Return EBUSY if dl_bw_cpus is zero Andrea Righi
2025-09-03 14:53 ` Juri Lelli
2025-09-03 15:10 ` Andrea Righi
2025-09-03 15:15 ` Juri Lelli
2025-09-03 15:24 ` Andrea Righi
2025-09-03 20:05 ` Peter Zijlstra
2025-09-04 7:12 ` luca abeni
2025-09-04 7:17 ` Juri Lelli
2025-09-03 9:33 ` [PATCH 06/16] sched: Add a server arg to dl_server_update_idle_time() Andrea Righi
2025-09-03 9:33 ` [PATCH 07/16] sched_ext: Add a DL server for sched_ext tasks Andrea Righi
2025-09-03 19:54 ` Tejun Heo
2025-09-03 20:08 ` Peter Zijlstra
2025-09-03 20:41 ` Tejun Heo
2025-09-03 20:56 ` Peter Zijlstra
2025-09-04 20:28 ` Peter Zijlstra
2025-09-04 21:43 ` Tejun Heo
2025-09-04 22:02 ` Peter Zijlstra
2025-09-10 16:01 ` Peter Zijlstra
2025-09-03 21:33 ` Andrea Righi
2025-09-03 9:33 ` [PATCH 08/16] sched/debug: Add support to change sched_ext server params Andrea Righi
2025-09-03 9:33 ` [PATCH 09/16] sched/deadline: Add support to remove DL server's bandwidth contribution Andrea Righi
2025-09-03 9:33 ` [PATCH 10/16] sched/deadline: Account ext server bandwidth Andrea Righi
2025-09-03 9:33 ` Andrea Righi [this message]
2025-09-03 9:33 ` [PATCH 12/16] sched_ext: Selectively enable ext and fair DL servers Andrea Righi
2025-09-03 9:33 ` [PATCH 13/16] sched/deadline: Fix DL server crash in inactive_timer callback Andrea Righi
2025-09-03 9:33 ` [PATCH 14/16] sched/deadline: De-couple balance and pick_task Andrea Righi
2025-09-03 9:33 ` [PATCH 15/16] selftests/sched_ext: Add test for sched_ext dl_server Andrea Righi
2025-09-03 9:33 ` [PATCH 16/16] selftests/sched_ext: Add test for DL server total_bw consistency Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903095008.162049-12-arighi@nvidia.com \
--to=arighi@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelagnelf@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox