BPF List
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>, Shuah Khan <shuah@kernel.org>,
	sched-ext@lists.linux.dev, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/16] sched_ext: Exit early on hotplug events during attach
Date: Wed, 3 Sep 2025 09:44:32 -1000	[thread overview]
Message-ID: <aLiaoEvjBfBsp-tR@slm.duckdns.org> (raw)
In-Reply-To: <20250903095008.162049-2-arighi@nvidia.com>

Hello,

On Wed, Sep 03, 2025 at 11:33:27AM +0200, Andrea Righi wrote:
>  static int validate_ops(struct scx_sched *sch, const struct sched_ext_ops *ops)
> @@ -5627,11 +5630,15 @@ static int scx_enable(struct sched_ext_ops *ops, struct bpf_link *link)
>  		if (((void (**)(void))ops)[i])
>  			set_bit(i, sch->has_op);
>  
> -	check_hotplug_seq(sch, ops);
> -	scx_idle_update_selcpu_topology(ops);
> +	ret = check_hotplug_seq(sch, ops);
> +	if (!ret)
> +		scx_idle_update_selcpu_topology(ops);
>  
>  	cpus_read_unlock();
>  
> +	if (ret)
> +		goto err_disable;

The double testing is a bit jarring. Maybe just add cpus_read_unlock() in
the error block so that error return can take place right after
check_hotplug_seq()? Alternatively, create a new error jump target - e.g.
err_disable_unlock_cpus and share it between here and the init failure path?

Thanks.

-- 
tejun

  reply	other threads:[~2025-09-03 19:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03  9:33 [PATCHSET v8 sched_ext/for-6.18] Add a deadline server for sched_ext tasks Andrea Righi
2025-09-03  9:33 ` [PATCH 01/16] sched_ext: Exit early on hotplug events during attach Andrea Righi
2025-09-03 19:44   ` Tejun Heo [this message]
2025-09-03 21:40     ` Andrea Righi
2025-09-03  9:33 ` [PATCH 02/16] sched/debug: Fix updating of ppos on server write ops Andrea Righi
2025-09-03  9:33 ` [PATCH 03/16] sched/debug: Stop and start server based on if it was active Andrea Righi
2025-09-03 14:43   ` Juri Lelli
2025-09-03 15:02     ` Andrea Righi
2025-09-03  9:33 ` [PATCH 04/16] sched/deadline: Clear the defer params Andrea Righi
2025-09-03 14:44   ` Juri Lelli
2025-09-03  9:33 ` [PATCH 05/16] sched/deadline: Return EBUSY if dl_bw_cpus is zero Andrea Righi
2025-09-03 14:53   ` Juri Lelli
2025-09-03 15:10     ` Andrea Righi
2025-09-03 15:15       ` Juri Lelli
2025-09-03 15:24         ` Andrea Righi
2025-09-03 20:05     ` Peter Zijlstra
2025-09-04  7:12       ` luca abeni
2025-09-04  7:17       ` Juri Lelli
2025-09-03  9:33 ` [PATCH 06/16] sched: Add a server arg to dl_server_update_idle_time() Andrea Righi
2025-09-03  9:33 ` [PATCH 07/16] sched_ext: Add a DL server for sched_ext tasks Andrea Righi
2025-09-03 19:54   ` Tejun Heo
2025-09-03 20:08     ` Peter Zijlstra
2025-09-03 20:41       ` Tejun Heo
2025-09-03 20:56         ` Peter Zijlstra
2025-09-04 20:28           ` Peter Zijlstra
2025-09-04 21:43             ` Tejun Heo
2025-09-04 22:02               ` Peter Zijlstra
2025-09-10 16:01               ` Peter Zijlstra
2025-09-03 21:33         ` Andrea Righi
2025-09-03  9:33 ` [PATCH 08/16] sched/debug: Add support to change sched_ext server params Andrea Righi
2025-09-03  9:33 ` [PATCH 09/16] sched/deadline: Add support to remove DL server's bandwidth contribution Andrea Righi
2025-09-03  9:33 ` [PATCH 10/16] sched/deadline: Account ext server bandwidth Andrea Righi
2025-09-03  9:33 ` [PATCH 11/16] sched/deadline: Allow to initialize DL server when needed Andrea Righi
2025-09-03  9:33 ` [PATCH 12/16] sched_ext: Selectively enable ext and fair DL servers Andrea Righi
2025-09-03  9:33 ` [PATCH 13/16] sched/deadline: Fix DL server crash in inactive_timer callback Andrea Righi
2025-09-03  9:33 ` [PATCH 14/16] sched/deadline: De-couple balance and pick_task Andrea Righi
2025-09-03  9:33 ` [PATCH 15/16] selftests/sched_ext: Add test for sched_ext dl_server Andrea Righi
2025-09-03  9:33 ` [PATCH 16/16] selftests/sched_ext: Add test for DL server total_bw consistency Andrea Righi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLiaoEvjBfBsp-tR@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=bpf@vger.kernel.org \
    --cc=bsegall@google.com \
    --cc=changwoo@igalia.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joelagnelf@nvidia.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=shuah@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=void@manifault.com \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox