BPF List
 help / color / mirror / Atom feed
From: luca abeni <luca.abeni@santannapisa.it>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>,
	Andrea Righi <arighi@nvidia.com>, Ingo Molnar <mingo@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Joel Fernandes <joelagnelf@nvidia.com>, Tejun Heo <tj@kernel.org>,
	David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>, Shuah Khan <shuah@kernel.org>,
	sched-ext@lists.linux.dev, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Yuri Andriaccio <yurand2000@gmail.com>
Subject: Re: [PATCH 05/16] sched/deadline: Return EBUSY if dl_bw_cpus is zero
Date: Thu, 4 Sep 2025 09:12:17 +0200	[thread overview]
Message-ID: <20250904091217.78de3dde@luca64> (raw)
In-Reply-To: <20250903200520.GN4067720@noisy.programming.kicks-ass.net>

Hi Peter,

On Wed, 3 Sep 2025 22:05:20 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
[...]
> > Yuri is proposing to ignore dl-servers bandwidth contribution from
> > admission control (as they essentially operate on the remaining
> > bandwidth portion not available to RT/DEADLINE tasks):
> > 
> > https://lore.kernel.org/lkml/20250903114448.664452-1-yurand2000@gmail.com/
> > 
> > His patch should make this patch not required. Would you be able and
> > willing to test this assumption?
> > 
> > I don't believe Peter already expressed his opinion on what Yuri is
> > proposing, so this might be moot.   
> 
> Urgh, yeah, I don't like that at all. That reasoning makes no sense
> what so ever. That 5% is not lost time, that 5% is being very
> optimistic and 'models' otherwise unaccountable time like IRQ and
> random overheads.
> 
> Thinking you can give out 100% CPU time to a bandwidth limited group
> of tasks is delusional.
> 
> Explicitly not accounting things that you *can* is just plain wrong.
> So no, Yuri's thing is not going to go anywhere.

The goal of Yuri's patch was not to avoid accounting things... The goal
was to avoid subtracting the fair dl server utilization from the
utilization reserved for real-time tasks (assuming that
/proc/sys/kernel/sched_rt_runtime_us / /proc/sys/kernel/sched_rt_period_us
represents the fraction of CPU time reserved for real-time tasks).

Maybe we made errors in describing the patch (or in some details of the
implementation), but the final goal was just to ensure that
sched_rt_runtime_us/sched_rt_period_us goes to RT tasks; the remaining
fraction of CPU time is shared by SCHED_OTHER tasks, fair dl servers,
IRQs, and other overhead (the fair dl server utilization can be smaller
than 1-sched_rt_runtime_us/sched_rt_period_us, so some time can be
explicitly left for IRQs and kernel).


				Luca



				Luca

  reply	other threads:[~2025-09-04  7:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03  9:33 [PATCHSET v8 sched_ext/for-6.18] Add a deadline server for sched_ext tasks Andrea Righi
2025-09-03  9:33 ` [PATCH 01/16] sched_ext: Exit early on hotplug events during attach Andrea Righi
2025-09-03 19:44   ` Tejun Heo
2025-09-03 21:40     ` Andrea Righi
2025-09-03  9:33 ` [PATCH 02/16] sched/debug: Fix updating of ppos on server write ops Andrea Righi
2025-09-03  9:33 ` [PATCH 03/16] sched/debug: Stop and start server based on if it was active Andrea Righi
2025-09-03 14:43   ` Juri Lelli
2025-09-03 15:02     ` Andrea Righi
2025-09-03  9:33 ` [PATCH 04/16] sched/deadline: Clear the defer params Andrea Righi
2025-09-03 14:44   ` Juri Lelli
2025-09-03  9:33 ` [PATCH 05/16] sched/deadline: Return EBUSY if dl_bw_cpus is zero Andrea Righi
2025-09-03 14:53   ` Juri Lelli
2025-09-03 15:10     ` Andrea Righi
2025-09-03 15:15       ` Juri Lelli
2025-09-03 15:24         ` Andrea Righi
2025-09-03 20:05     ` Peter Zijlstra
2025-09-04  7:12       ` luca abeni [this message]
2025-09-04  7:17       ` Juri Lelli
2025-09-03  9:33 ` [PATCH 06/16] sched: Add a server arg to dl_server_update_idle_time() Andrea Righi
2025-09-03  9:33 ` [PATCH 07/16] sched_ext: Add a DL server for sched_ext tasks Andrea Righi
2025-09-03 19:54   ` Tejun Heo
2025-09-03 20:08     ` Peter Zijlstra
2025-09-03 20:41       ` Tejun Heo
2025-09-03 20:56         ` Peter Zijlstra
2025-09-04 20:28           ` Peter Zijlstra
2025-09-04 21:43             ` Tejun Heo
2025-09-04 22:02               ` Peter Zijlstra
2025-09-10 16:01               ` Peter Zijlstra
2025-09-03 21:33         ` Andrea Righi
2025-09-03  9:33 ` [PATCH 08/16] sched/debug: Add support to change sched_ext server params Andrea Righi
2025-09-03  9:33 ` [PATCH 09/16] sched/deadline: Add support to remove DL server's bandwidth contribution Andrea Righi
2025-09-03  9:33 ` [PATCH 10/16] sched/deadline: Account ext server bandwidth Andrea Righi
2025-09-03  9:33 ` [PATCH 11/16] sched/deadline: Allow to initialize DL server when needed Andrea Righi
2025-09-03  9:33 ` [PATCH 12/16] sched_ext: Selectively enable ext and fair DL servers Andrea Righi
2025-09-03  9:33 ` [PATCH 13/16] sched/deadline: Fix DL server crash in inactive_timer callback Andrea Righi
2025-09-03  9:33 ` [PATCH 14/16] sched/deadline: De-couple balance and pick_task Andrea Righi
2025-09-03  9:33 ` [PATCH 15/16] selftests/sched_ext: Add test for sched_ext dl_server Andrea Righi
2025-09-03  9:33 ` [PATCH 16/16] selftests/sched_ext: Add test for DL server total_bw consistency Andrea Righi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250904091217.78de3dde@luca64 \
    --to=luca.abeni@santannapisa.it \
    --cc=arighi@nvidia.com \
    --cc=bpf@vger.kernel.org \
    --cc=bsegall@google.com \
    --cc=changwoo@igalia.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joelagnelf@nvidia.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=void@manifault.com \
    --cc=vschneid@redhat.com \
    --cc=yurand2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox