Re: [PATCH bpf-next 03/18] bpf: Refactor record_call_access() to extract per-arg logic

[Yonghong Song <yonghong.song@linux.dev>]

On 4/29/26 1:51 AM, Eduard Zingerman wrote:
> On Fri, 2026-04-24 at 10:14 -0700, Yonghong Song wrote:
>> Extract the per-argument FP-derived pointer handling from
>> record_call_access() into a new record_arg_access() helper.
>>
>> The existing loop body — checking arg_is_fp, querying stack access
>> bytes, and calling record_stack_access/record_imprecise — will be
>> reused for stack argument slots in the next patch. Factoring it out
>> now avoids duplicating the logic.
>>
>> No functional change.
>>
>> Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
>> ---
> Acked-by: Eduard Zingerman <eddyz87@gmail.com>
>
> [...]
>
>> +static int record_arg_access(struct bpf_verifier_env *env,
> [...]
>
>> +		for (int f = 0; f <= depth; f++) {
>> +			err = mark_stack_read(instance, f, insn_idx, SPIS_ALL);
>> +			if (err)
>> +				return err;
>> +		}
>> +		return 1;
> Why having both 0 and 1 as success return codes in this function?

You are right. Will remove 1.

>
>
> [...]