From: Alexei Starovoitov <ast@fb.com>
To: Joanne Koong <joannekoong@fb.com>, Zvi Effron <zeffron@riotgames.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
bpf <bpf@vger.kernel.org>, "Kernel Team" <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next v4 1/5] bpf: Add bitset map with bloom filter capabilities
Date: Wed, 13 Oct 2021 06:48:41 +0200 [thread overview]
Message-ID: <e77470bd-0ea3-7d7b-8de9-20ad2ef2594b@fb.com> (raw)
In-Reply-To: <4f09d330-b694-e2c6-8ec9-388c088d1c34@fb.com>
On 10/12/21 6:17 PM, Joanne Koong wrote:
> If the bitset data could reside in a global array in the bpf program,
> then I
> agree - it seems like we could just make a helper function that takes in
> an ARG_PTR_TO_MEM where we pass the data in as a ptr, instead of needing
> a map.
The main advantage of helpers for bit ops is ease of implementation.
We can add set/test/clear_bit along with ffs fls and others
very quickly.
But programs that need to do atomic bit ops probably care
about performance, so non-inlined helper might be too slow.
Doing the same via new instructions will take a ton more time,
but the long term benefits of insns are worth considering.
next prev parent reply other threads:[~2021-10-13 4:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 22:20 [PATCH bpf-next v4 0/5] Implement bitset maps, with bloom filter Joanne Koong
2021-10-06 22:20 ` [PATCH bpf-next v4 1/5] bpf: Add bitset map with bloom filter capabilities Joanne Koong
2021-10-07 14:20 ` Toke Høiland-Jørgensen
2021-10-07 21:59 ` Joanne Koong
2021-10-08 21:57 ` Toke Høiland-Jørgensen
2021-10-08 23:11 ` Andrii Nakryiko
2021-10-09 13:10 ` Toke Høiland-Jørgensen
2021-10-12 3:17 ` Andrii Nakryiko
2021-10-12 12:48 ` Toke Høiland-Jørgensen
2021-10-12 22:46 ` Joanne Koong
2021-10-12 23:25 ` Zvi Effron
2021-10-13 1:17 ` Joanne Koong
2021-10-13 4:48 ` Alexei Starovoitov [this message]
2021-10-13 0:11 ` Martin KaFai Lau
2021-10-13 4:41 ` Alexei Starovoitov
2021-10-19 23:53 ` Andrii Nakryiko
2021-10-08 23:05 ` Andrii Nakryiko
2021-10-08 23:24 ` Zvi Effron
2021-10-09 0:16 ` Martin KaFai Lau
2021-10-06 22:21 ` [PATCH bpf-next v4 2/5] libbpf: Add "map_extra" as a per-map-type extra flag Joanne Koong
2021-10-08 23:19 ` Andrii Nakryiko
2021-10-20 21:08 ` Joanne Koong
2021-10-20 21:21 ` Andrii Nakryiko
2021-10-21 20:14 ` Joanne Koong
2021-10-21 21:41 ` Andrii Nakryiko
2021-10-09 2:12 ` Andrii Nakryiko
2021-10-06 22:21 ` [PATCH bpf-next v4 3/5] selftests/bpf: Add bitset map test cases Joanne Koong
2021-10-06 22:21 ` [PATCH bpf-next v4 4/5] bpf/benchs: Add benchmark tests for bloom filter throughput + false positive Joanne Koong
2021-10-06 22:35 ` Joanne Koong
2021-10-09 2:54 ` Andrii Nakryiko
2021-10-15 23:35 ` Joanne Koong
2021-10-20 0:46 ` Joanne Koong
2021-10-09 2:39 ` Andrii Nakryiko
2021-10-06 22:21 ` [PATCH bpf-next v4 5/5] bpf/benchs: Add benchmarks for comparing hashmap lookups w/ vs. w/out bloom filter Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e77470bd-0ea3-7d7b-8de9-20ad2ef2594b@fb.com \
--to=ast@fb.com \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=joannekoong@fb.com \
--cc=toke@redhat.com \
--cc=zeffron@riotgames.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox