* [Buildroot] [PATCH] New package: freerdp
@ 2012-05-23 20:51 Julian Lunz
2012-05-23 21:02 ` Peter Korsgaard
0 siblings, 1 reply; 9+ messages in thread
From: Julian Lunz @ 2012-05-23 20:51 UTC (permalink / raw)
To: buildroot
Signed-off-by: Julian Lunz <git@jlunz.de>
---
package/Config.in | 1 +
package/freerdp/Config.in | 11 +++++++++++
package/freerdp/freerdp.mk | 13 +++++++++++++
3 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 package/freerdp/Config.in
create mode 100644 package/freerdp/freerdp.mk
diff --git a/package/Config.in b/package/Config.in
index fb1b08f..2d1f18d 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -152,6 +152,7 @@ source "package/leafpad/Config.in"
source "package/midori/Config.in"
source "package/pcmanfm/Config.in"
source "package/rdesktop/Config.in"
+source "package/freerdp/Config.in"
source "package/sylpheed/Config.in"
source "package/synergy/Config.in"
source "package/torsmo/Config.in"
diff --git a/package/freerdp/Config.in b/package/freerdp/Config.in
new file mode 100644
index 0000000..1cc49c9
--- /dev/null
+++ b/package/freerdp/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_FREERDP
+ bool "freerdp"
+ select BR2_PACKAGE_OPENSSL
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBXT
+ depends on BR2_PACKAGE_XORG7
+ help
+ FreeRDPFreeRDP is a free implementation of the
+ Remote Desktop Protocol (RDP), released under the Apache license
+
+ http://www.freerdp.com/
diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
new file mode 100644
index 0000000..61b6ca2
--- /dev/null
+++ b/package/freerdp/freerdp.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# FreeRDP
+#
+#############################################################
+
+FREERDP_VERSION = 1.0.1
+FREERDP_SOURCE = freerdp-$(FREERDP_VERSION).tar.gz
+FREERDP_SITE = https://github.com/downloads/FreeRDP/FreeRDP
+FREERDP_CONF_OPT = -DWITH_CUPS=OFF -DWITH_FFMPEG=OFF -DWITH_ALSA=OFF -DWITH_XINERAMA=OFF
+FREERDP_DEPENDENCIES = openssl xlib_libX11 xlib_libXt zlib
+
+$(eval $(call CMAKETARGETS))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] New package: freerdp
2012-05-23 20:51 [Buildroot] [PATCH] New package: freerdp Julian Lunz
@ 2012-05-23 21:02 ` Peter Korsgaard
2012-05-23 21:41 ` [Buildroot] (no subject) Julian Lunz
2012-05-23 21:49 ` [Buildroot] [PATCH] New package: freerdp Julian Lunz
0 siblings, 2 replies; 9+ messages in thread
From: Peter Korsgaard @ 2012-05-23 21:02 UTC (permalink / raw)
To: buildroot
>>>>> "Julian" == Julian Lunz <git@jlunz.de> writes:
Hi,
Julian> Signed-off-by: Julian Lunz <git@jlunz.de>
Julian> ---
Julian> package/Config.in | 1 +
Julian> package/freerdp/Config.in | 11 +++++++++++
Julian> package/freerdp/freerdp.mk | 13 +++++++++++++
Julian> 3 files changed, 25 insertions(+), 0 deletions(-)
Julian> create mode 100644 package/freerdp/Config.in
Julian> create mode 100644 package/freerdp/freerdp.mk
Julian> diff --git a/package/Config.in b/package/Config.in
Julian> index fb1b08f..2d1f18d 100644
Julian> --- a/package/Config.in
Julian> +++ b/package/Config.in
Julian> @@ -152,6 +152,7 @@ source "package/leafpad/Config.in"
Julian> source "package/midori/Config.in"
Julian> source "package/pcmanfm/Config.in"
Julian> source "package/rdesktop/Config.in"
Julian> +source "package/freerdp/Config.in"
I know it logically belong with rdesktop, but we normally sort these
sort lines alphabetically.
Julian> source "package/sylpheed/Config.in"
Julian> source "package/synergy/Config.in"
Julian> source "package/torsmo/Config.in"
Julian> diff --git a/package/freerdp/Config.in b/package/freerdp/Config.in
Julian> new file mode 100644
Julian> index 0000000..1cc49c9
Julian> --- /dev/null
Julian> +++ b/package/freerdp/Config.in
Julian> @@ -0,0 +1,11 @@
Julian> +config BR2_PACKAGE_FREERDP
Julian> + bool "freerdp"
Julian> + select BR2_PACKAGE_OPENSSL
Julian> + select BR2_PACKAGE_XLIB_LIBX11
Julian> + select BR2_PACKAGE_XLIB_LIBXT
Julian> + depends on BR2_PACKAGE_XORG7
Julian> + help
Julian> + FreeRDPFreeRDP is a free implementation of the
Julian> + Remote Desktop Protocol (RDP), released under the Apache license
Julian> +
Julian> + http://www.freerdp.com/
Julian> diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
Julian> new file mode 100644
Julian> index 0000000..61b6ca2
Julian> --- /dev/null
Julian> +++ b/package/freerdp/freerdp.mk
Julian> @@ -0,0 +1,13 @@
Julian> +#############################################################
Julian> +#
Julian> +# FreeRDP
Julian> +#
Julian> +#############################################################
Julian> +
Julian> +FREERDP_VERSION = 1.0.1
Julian> +FREERDP_SOURCE = freerdp-$(FREERDP_VERSION).tar.gz
Julian> +FREERDP_SITE = https://github.com/downloads/FreeRDP/FreeRDP
Julian> +FREERDP_CONF_OPT = -DWITH_CUPS=OFF -DWITH_FFMPEG=OFF -DWITH_ALSA=OFF -DWITH_XINERAMA=OFF
We do have packages for cups, ffmpeg, alsa and libXinerama in buildroot,
so it would be good to add optional support for these - E.G.:
ifeq ($(BR2_PACKAGE_CUPS),y)
FREERDP_DEPENDENCIES += cups
else
FREERDP_CONF_OPT += -DWITH_CUPS=OFF
endif
..
Julian> +FREERDP_DEPENDENCIES = openssl xlib_libX11 xlib_libXt zlib
You don't select BR2_PACKAGE_ZLIB in Config.in, but you have it here?
Otherwise it looks good. Care to fix and resend?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] (no subject)
2012-05-23 21:02 ` Peter Korsgaard
@ 2012-05-23 21:41 ` Julian Lunz
2012-05-23 21:49 ` [Buildroot] [PATCH] New package: freerdp Julian Lunz
1 sibling, 0 replies; 9+ messages in thread
From: Julian Lunz @ 2012-05-23 21:41 UTC (permalink / raw)
To: buildroot
Hello Peter,
thanks for your quick reply and comments.
Fixed the patch according to your proposals.
Best regards,
Julian
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] New package: freerdp
@ 2012-05-23 21:45 Julian Lunz
2012-05-29 18:34 ` Julian Lunz
2012-05-29 19:12 ` Arnout Vandecappelle
0 siblings, 2 replies; 9+ messages in thread
From: Julian Lunz @ 2012-05-23 21:45 UTC (permalink / raw)
To: buildroot
Signed-off-by: Julian Lunz <git@jlunz.de>
---
package/Config.in | 1 +
package/freerdp/Config.in | 38 ++++++++++++++++++++++++++++++++++++++
package/freerdp/freerdp.mk | 41 +++++++++++++++++++++++++++++++++++++++++
3 files changed, 80 insertions(+), 0 deletions(-)
create mode 100644 package/freerdp/Config.in
create mode 100644 package/freerdp/freerdp.mk
diff --git a/package/Config.in b/package/Config.in
index fb1b08f..dc683aa 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -144,6 +144,7 @@ comment "X applications"
source "package/alsamixergui/Config.in"
source "package/docker/Config.in"
source "package/feh/Config.in"
+source "package/freerdp/Config.in"
source "package/gqview/Config.in"
source "package/gmpc/Config.in"
source "package/gob2/Config.in"
diff --git a/package/freerdp/Config.in b/package/freerdp/Config.in
new file mode 100644
index 0000000..b452141
--- /dev/null
+++ b/package/freerdp/Config.in
@@ -0,0 +1,38 @@
+menuconfig BR2_PACKAGE_FREERDP
+ bool "freerdp"
+ select BR2_PACKAGE_OPENSSL
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBXT
+ select BR2_PACKAGE_ZLIB
+ depends on BR2_PACKAGE_XORG7
+ help
+ FreeRDPFreeRDP is a free implementation of the
+ Remote Desktop Protocol (RDP), released under the Apache license
+
+ http://www.freerdp.com/
+
+
+if BR2_PACKAGE_FREERDP
+
+config BR2_PACKAGE_FREERDP_WITHCUPS
+ bool "CUPS support"
+ help
+ Compile with CUPS support.
+
+config BR2_PACKAGE_FREERDP_WITHFFMPEG
+ bool "FFmpeg support"
+ help
+ Compile with FFmpeg support.
+
+config BR2_PACKAGE_FREERDP_WITHALSA
+ bool "Alsa support"
+ help
+ Compile with Alsa support.
+
+config BR2_PACKAGE_FREERDP_WITHXINERAMA
+ bool "Xinerama support"
+ help
+ Compile with Xinerama support.
+
+endif # BR2_PACKAGE_FREERDP
+
diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
new file mode 100644
index 0000000..b947628
--- /dev/null
+++ b/package/freerdp/freerdp.mk
@@ -0,0 +1,41 @@
+#############################################################
+#
+# FreeRDP
+#
+#############################################################
+
+FREERDP_VERSION = 1.0.1
+FREERDP_SOURCE = freerdp-$(FREERDP_VERSION).tar.gz
+FREERDP_SITE = https://github.com/downloads/FreeRDP/FreeRDP
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHCUPS),y)
+FREERDP_CONF_OPT += -DWITH_CUPS=ON
+FREERDP_DEPENDENCIES += cups
+else
+FREERDP_CONF_OPT += -DWITH_CUPS=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHFFMPEG),y)
+FREERDP_CONF_OPT += -DWITH_FFMPEG=ON
+FREERDP_DEPENDENCIES += ffmpeg
+else
+FREERDP_CONF_OPT += -DWITH_FFMPEG=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHALSA),y)
+FREERDP_CONF_OPT += -DWITH_ALSA=ON
+FREERDP_DEPENDENCIES += alsa-utils
+else
+FREERDP_CONF_OPT += -DWITH_ALSA=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHXINERAMA),y)
+FREERDP_CONF_OPT += -DWITH_XINERAMA=ON
+FREERDP_DEPENDENCIES += xlib_libXinerama
+else
+FREERDP_CONF_OPT += -DWITH_XINERAMA=OFF
+endif
+
+FREERDP_DEPENDENCIES += openssl xlib_libX11 xlib_libXt zlib
+
+$(eval $(call CMAKETARGETS))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] New package: freerdp
2012-05-23 21:02 ` Peter Korsgaard
2012-05-23 21:41 ` [Buildroot] (no subject) Julian Lunz
@ 2012-05-23 21:49 ` Julian Lunz
1 sibling, 0 replies; 9+ messages in thread
From: Julian Lunz @ 2012-05-23 21:49 UTC (permalink / raw)
To: buildroot
Hello Peter,
thanks for your quick reply and comments.
Fixed the patch according to your proposals.
Other git send-email failed a bit, therefore seperate mails.
Best regards,
Julian
On Wed, 23 May 2012 23:02:38 +0200
Peter Korsgaard <jacmet@uclibc.org> wrote:
> >>>>> "Julian" == Julian Lunz <git@jlunz.de> writes:
>
> Hi,
>
> Julian> Signed-off-by: Julian Lunz <git@jlunz.de>
> Julian> ---
> Julian> package/Config.in | 1 +
> Julian> package/freerdp/Config.in | 11 +++++++++++
> Julian> package/freerdp/freerdp.mk | 13 +++++++++++++
> Julian> 3 files changed, 25 insertions(+), 0 deletions(-)
> Julian> create mode 100644 package/freerdp/Config.in
> Julian> create mode 100644 package/freerdp/freerdp.mk
>
> Julian> diff --git a/package/Config.in b/package/Config.in
> Julian> index fb1b08f..2d1f18d 100644
> Julian> --- a/package/Config.in
> Julian> +++ b/package/Config.in
> Julian> @@ -152,6 +152,7 @@ source "package/leafpad/Config.in"
> Julian> source "package/midori/Config.in"
> Julian> source "package/pcmanfm/Config.in"
> Julian> source "package/rdesktop/Config.in"
> Julian> +source "package/freerdp/Config.in"
>
>
> I know it logically belong with rdesktop, but we normally sort these
> sort lines alphabetically.
>
>
> Julian> source "package/sylpheed/Config.in"
> Julian> source "package/synergy/Config.in"
> Julian> source "package/torsmo/Config.in"
> Julian> diff --git a/package/freerdp/Config.in
> Julian> b/package/freerdp/Config.in new file mode 100644
> Julian> index 0000000..1cc49c9
> Julian> --- /dev/null
> Julian> +++ b/package/freerdp/Config.in
> Julian> @@ -0,0 +1,11 @@
> Julian> +config BR2_PACKAGE_FREERDP
> Julian> + bool "freerdp"
> Julian> + select BR2_PACKAGE_OPENSSL
> Julian> + select BR2_PACKAGE_XLIB_LIBX11
> Julian> + select BR2_PACKAGE_XLIB_LIBXT
> Julian> + depends on BR2_PACKAGE_XORG7
> Julian> + help
> Julian> + FreeRDPFreeRDP is a free implementation of the
> Julian> + Remote Desktop Protocol (RDP), released under the
> Julian> Apache license +
> Julian> + http://www.freerdp.com/
> Julian> diff --git a/package/freerdp/freerdp.mk
> Julian> b/package/freerdp/freerdp.mk new file mode 100644
> Julian> index 0000000..61b6ca2
> Julian> --- /dev/null
> Julian> +++ b/package/freerdp/freerdp.mk
> Julian> @@ -0,0 +1,13 @@
> Julian> +#############################################################
> Julian> +#
> Julian> +# FreeRDP
> Julian> +#
> Julian> +#############################################################
> Julian> +
> Julian> +FREERDP_VERSION = 1.0.1
> Julian> +FREERDP_SOURCE = freerdp-$(FREERDP_VERSION).tar.gz
> Julian> +FREERDP_SITE = https://github.com/downloads/FreeRDP/FreeRDP
> Julian> +FREERDP_CONF_OPT = -DWITH_CUPS=OFF -DWITH_FFMPEG=OFF
> Julian> -DWITH_ALSA=OFF -DWITH_XINERAMA=OFF
>
> We do have packages for cups, ffmpeg, alsa and libXinerama in
> buildroot, so it would be good to add optional support for these -
> E.G.:
>
> ifeq ($(BR2_PACKAGE_CUPS),y)
> FREERDP_DEPENDENCIES += cups
> else
> FREERDP_CONF_OPT += -DWITH_CUPS=OFF
> endif
> ..
>
> Julian> +FREERDP_DEPENDENCIES = openssl xlib_libX11 xlib_libXt zlib
>
> You don't select BR2_PACKAGE_ZLIB in Config.in, but you have it here?
>
> Otherwise it looks good. Care to fix and resend?
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] New package: freerdp
2012-05-23 21:45 Julian Lunz
@ 2012-05-29 18:34 ` Julian Lunz
2012-05-29 19:12 ` Arnout Vandecappelle
1 sibling, 0 replies; 9+ messages in thread
From: Julian Lunz @ 2012-05-29 18:34 UTC (permalink / raw)
To: buildroot
Hi,
Cared to fix, looking good?
On Wed, 23 May 2012 23:45:09 +0200
Julian Lunz <git@jlunz.de> wrote:
> Signed-off-by: Julian Lunz <git@jlunz.de>
> ---
> package/Config.in | 1 +
> package/freerdp/Config.in | 38
> ++++++++++++++++++++++++++++++++++++++ package/freerdp/freerdp.mk |
> 41 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 80
> insertions(+), 0 deletions(-) create mode 100644
> package/freerdp/Config.in create mode 100644
> package/freerdp/freerdp.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index fb1b08f..dc683aa 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -144,6 +144,7 @@ comment "X applications"
> source "package/alsamixergui/Config.in"
> source "package/docker/Config.in"
> source "package/feh/Config.in"
> +source "package/freerdp/Config.in"
> source "package/gqview/Config.in"
> source "package/gmpc/Config.in"
> source "package/gob2/Config.in"
> diff --git a/package/freerdp/Config.in b/package/freerdp/Config.in
> new file mode 100644
> index 0000000..b452141
> --- /dev/null
> +++ b/package/freerdp/Config.in
> @@ -0,0 +1,38 @@
> +menuconfig BR2_PACKAGE_FREERDP
> + bool "freerdp"
> + select BR2_PACKAGE_OPENSSL
> + select BR2_PACKAGE_XLIB_LIBX11
> + select BR2_PACKAGE_XLIB_LIBXT
> + select BR2_PACKAGE_ZLIB
> + depends on BR2_PACKAGE_XORG7
> + help
> + FreeRDPFreeRDP is a free implementation of the
> + Remote Desktop Protocol (RDP), released under the Apache
> license +
> + http://www.freerdp.com/
> +
> +
> +if BR2_PACKAGE_FREERDP
> +
> +config BR2_PACKAGE_FREERDP_WITHCUPS
> + bool "CUPS support"
> + help
> + Compile with CUPS support.
> +
> +config BR2_PACKAGE_FREERDP_WITHFFMPEG
> + bool "FFmpeg support"
> + help
> + Compile with FFmpeg support.
> +
> +config BR2_PACKAGE_FREERDP_WITHALSA
> + bool "Alsa support"
> + help
> + Compile with Alsa support.
> +
> +config BR2_PACKAGE_FREERDP_WITHXINERAMA
> + bool "Xinerama support"
> + help
> + Compile with Xinerama support.
> +
> +endif # BR2_PACKAGE_FREERDP
> +
> diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
> new file mode 100644
> index 0000000..b947628
> --- /dev/null
> +++ b/package/freerdp/freerdp.mk
> @@ -0,0 +1,41 @@
> +#############################################################
> +#
> +# FreeRDP
> +#
> +#############################################################
> +
> +FREERDP_VERSION = 1.0.1
> +FREERDP_SOURCE = freerdp-$(FREERDP_VERSION).tar.gz
> +FREERDP_SITE = https://github.com/downloads/FreeRDP/FreeRDP
> +
> +ifeq ($(BR2_PACKAGE_FREERDP_WITHCUPS),y)
> +FREERDP_CONF_OPT += -DWITH_CUPS=ON
> +FREERDP_DEPENDENCIES += cups
> +else
> +FREERDP_CONF_OPT += -DWITH_CUPS=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_FREERDP_WITHFFMPEG),y)
> +FREERDP_CONF_OPT += -DWITH_FFMPEG=ON
> +FREERDP_DEPENDENCIES += ffmpeg
> +else
> +FREERDP_CONF_OPT += -DWITH_FFMPEG=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_FREERDP_WITHALSA),y)
> +FREERDP_CONF_OPT += -DWITH_ALSA=ON
> +FREERDP_DEPENDENCIES += alsa-utils
> +else
> +FREERDP_CONF_OPT += -DWITH_ALSA=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_FREERDP_WITHXINERAMA),y)
> +FREERDP_CONF_OPT += -DWITH_XINERAMA=ON
> +FREERDP_DEPENDENCIES += xlib_libXinerama
> +else
> +FREERDP_CONF_OPT += -DWITH_XINERAMA=OFF
> +endif
> +
> +FREERDP_DEPENDENCIES += openssl xlib_libX11 xlib_libXt zlib
> +
> +$(eval $(call CMAKETARGETS))
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] New package: freerdp
2012-05-23 21:45 Julian Lunz
2012-05-29 18:34 ` Julian Lunz
@ 2012-05-29 19:12 ` Arnout Vandecappelle
2012-05-30 17:53 ` Julian Lunz
1 sibling, 1 reply; 9+ messages in thread
From: Arnout Vandecappelle @ 2012-05-29 19:12 UTC (permalink / raw)
To: buildroot
On 05/23/12 23:45, Julian Lunz wrote:
[snip]
> +if BR2_PACKAGE_FREERDP
> +
> +config BR2_PACKAGE_FREERDP_WITHCUPS
> + bool "CUPS support"
You need to add 'select BR2_PACKAGE_CUPS'.
But in fact, in this case I think it could be turned around: compile with
cups support if BR2_PACKAGE_CUPS is selected. I.e., remove these
config options and in the .mk file:
[snip]
> +ifeq ($(BR2_PACKAGE_FREERDP_WITHCUPS),y)
replace with
ifeq ($(BR2_PACKAGE_CUPS),y)
On the other hand, for some of these (particularly alsa and Xinerama) it's
probably more user-friendly to have a config option like you have now.
> +FREERDP_CONF_OPT += -DWITH_CUPS=ON
> +FREERDP_DEPENDENCIES += cups
> +else
> +FREERDP_CONF_OPT += -DWITH_CUPS=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_FREERDP_WITHFFMPEG),y)
> +FREERDP_CONF_OPT += -DWITH_FFMPEG=ON
> +FREERDP_DEPENDENCIES += ffmpeg
> +else
> +FREERDP_CONF_OPT += -DWITH_FFMPEG=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_FREERDP_WITHALSA),y)
> +FREERDP_CONF_OPT += -DWITH_ALSA=ON
> +FREERDP_DEPENDENCIES += alsa-utils
Shouldn't this be alsa-lib, rather than alsa-utils?
[snip]
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] New package: freerdp
2012-05-29 19:12 ` Arnout Vandecappelle
@ 2012-05-30 17:53 ` Julian Lunz
2012-05-30 19:04 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Julian Lunz @ 2012-05-30 17:53 UTC (permalink / raw)
To: buildroot
Hi Arnout,
thanks for your input!
On Tue, 29 May 2012 21:12:29 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> On 05/23/12 23:45, Julian Lunz wrote:
> [snip]
> > +if BR2_PACKAGE_FREERDP
> > +
> > +config BR2_PACKAGE_FREERDP_WITHCUPS
> > + bool "CUPS support"
> You need to add 'select BR2_PACKAGE_CUPS'.
Yep, missing for the others as well.
>
> But in fact, in this case I think it could be turned around:
> compile with cups support if BR2_PACKAGE_CUPS is selected. I.e.,
> remove these config options and in the .mk file:
> [snip]
> > +ifeq ($(BR2_PACKAGE_FREERDP_WITHCUPS),y)
> replace with
> ifeq ($(BR2_PACKAGE_CUPS),y)
>
True, but I tend to have it stated more explicitly that these options
could but mustn't be used.
So it is more a question of how would I buildroot like to behave.
A lot of other packages use the mechanism you describe, so what about
merging both like that:
(make "logical or")
ifneq (,$(filter y, $(BR2_PACKAGE_CUPS) \
$(BR2_PACKAGE_FREERDP_WITHCUPS)))
...
endif
>
> On the other hand, for some of these (particularly alsa and
> Xinerama) it's probably more user-friendly to have a config option
> like you have now.
>
> > +FREERDP_CONF_OPT += -DWITH_CUPS=ON
> > +FREERDP_DEPENDENCIES += cups
> > +else
> > +FREERDP_CONF_OPT += -DWITH_CUPS=OFF
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_FREERDP_WITHFFMPEG),y)
> > +FREERDP_CONF_OPT += -DWITH_FFMPEG=ON
> > +FREERDP_DEPENDENCIES += ffmpeg
> > +else
> > +FREERDP_CONF_OPT += -DWITH_FFMPEG=OFF
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_FREERDP_WITHALSA),y)
> > +FREERDP_CONF_OPT += -DWITH_ALSA=ON
> > +FREERDP_DEPENDENCIES += alsa-utils
> Shouldn't this be alsa-lib, rather than alsa-utils?
Indeed, alsa-lib here.
>
> [snip]
>
>
> Regards,
> Arnout
>
Best regards,
Julian
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] New package: freerdp
2012-05-30 17:53 ` Julian Lunz
@ 2012-05-30 19:04 ` Thomas Petazzoni
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2012-05-30 19:04 UTC (permalink / raw)
To: buildroot
Le Wed, 30 May 2012 19:53:34 +0200,
Julian Lunz <git@jlunz.de> a ?crit :
> True, but I tend to have it stated more explicitly that these options
> could but mustn't be used.
> So it is more a question of how would I buildroot like to behave.
> A lot of other packages use the mechanism you describe, so what about
> merging both like that:
>
> (make "logical or")
>
> ifneq (,$(filter y, $(BR2_PACKAGE_CUPS) \
> $(BR2_PACKAGE_FREERDP_WITHCUPS)))
> ...
> endif
No, please do like we do for all other packages in Buildroot: simply
use them if available, i.e:
ifeq ($(BR2_PACKAGE_CUPS),y)
... do whatever is needed in your package to use cups
yourpkg_DEPENDENCIES += cups
else
... do whatever is needed in your package to not use cups
endif
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-05-30 19:04 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-23 20:51 [Buildroot] [PATCH] New package: freerdp Julian Lunz
2012-05-23 21:02 ` Peter Korsgaard
2012-05-23 21:41 ` [Buildroot] (no subject) Julian Lunz
2012-05-23 21:49 ` [Buildroot] [PATCH] New package: freerdp Julian Lunz
-- strict thread matches above, loose matches on Subject: below --
2012-05-23 21:45 Julian Lunz
2012-05-29 18:34 ` Julian Lunz
2012-05-29 19:12 ` Arnout Vandecappelle
2012-05-30 17:53 ` Julian Lunz
2012-05-30 19:04 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox