* [Buildroot] [PATCH v2 1/7] Adding ding-libs
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
@ 2014-12-12 15:42 ` Gregory Dymarek
2014-12-31 17:03 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 2/7] Adding gengetopt Gregory Dymarek
` (6 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Gregory Dymarek @ 2014-12-12 15:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
---
package/Config.in | 1 +
package/ding-libs/Config.in | 9 +++++++++
package/ding-libs/ding-libs.hash | 1 +
package/ding-libs/ding-libs.mk | 17 +++++++++++++++++
4 files changed, 28 insertions(+)
create mode 100644 package/ding-libs/Config.in
create mode 100644 package/ding-libs/ding-libs.hash
create mode 100644 package/ding-libs/ding-libs.mk
diff --git a/package/Config.in b/package/Config.in
index 48be2df..9e3f11b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -876,6 +876,7 @@ menu "Other"
source "package/clapack/Config.in"
source "package/classpath/Config.in"
source "package/cppcms/Config.in"
+ source "package/ding-libs/Config.in"
source "package/eigen/Config.in"
source "package/elfutils/Config.in"
source "package/fftw/Config.in"
diff --git a/package/ding-libs/Config.in b/package/ding-libs/Config.in
new file mode 100644
index 0000000..7c7a17f
--- /dev/null
+++ b/package/ding-libs/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_DING_LIBS
+ bool "ding-libs"
+# depends on BR2_TOOLCHAIN_BUILDROOT_LOCALE
+ select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+ help
+ Adds ding-libs
+ https://git.fedorahosted.org/git/ding-libs.git
+
diff --git a/package/ding-libs/ding-libs.hash b/package/ding-libs/ding-libs.hash
new file mode 100644
index 0000000..cf21585
--- /dev/null
+++ b/package/ding-libs/ding-libs.hash
@@ -0,0 +1 @@
+sha256,639984a57d6f936a6551c842712619692febaebf4515033fc929620a241ffa6a
diff --git a/package/ding-libs/ding-libs.mk b/package/ding-libs/ding-libs.mk
new file mode 100644
index 0000000..582b9be
--- /dev/null
+++ b/package/ding-libs/ding-libs.mk
@@ -0,0 +1,17 @@
+#############################################################
+#
+# ding-libs
+#
+#############################################################
+DING_LIBS_VERSION = 0_4_0
+DING_LIBS_SOURCE = ding_libs-$(DING_LIBS_VERSION).tar.xz
+DING_LIBS_SITE = https://git.fedorahosted.org/cgit/ding-libs.git/snapshot
+#DING_LIBS_DEPENDENCIES = BR2_TOOLCHAIN_BUILDROOT_LOCALE
+DING_LIBS_DEPENDENCIES = $(if !$(BR2_ENABLE_LOCALE),libiconv) $(if $(BR2_NEEDS_GETTEXT),gettext)
+DING_LIBS_AUTORECONF = YES
+DING_LIBS_INSTALL_STAGING = YES
+DING_LIBS_LICENSE = GPLv3
+DING_LIBS_LICENSE_FILES = COPYING
+DING_LIBS_MAKE=$(MAKE1)
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [Buildroot] [PATCH v2 1/7] Adding ding-libs
2014-12-12 15:42 ` [Buildroot] [PATCH v2 1/7] Adding ding-libs Gregory Dymarek
@ 2014-12-31 17:03 ` Thomas Petazzoni
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2014-12-31 17:03 UTC (permalink / raw)
To: buildroot
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:41 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
> ---
> package/Config.in | 1 +
> package/ding-libs/Config.in | 9 +++++++++
> package/ding-libs/ding-libs.hash | 1 +
> package/ding-libs/ding-libs.mk | 17 +++++++++++++++++
> 4 files changed, 28 insertions(+)
> create mode 100644 package/ding-libs/Config.in
> create mode 100644 package/ding-libs/ding-libs.hash
> create mode 100644 package/ding-libs/ding-libs.mk
Thanks, applied, after doing again a fairly significant amount of fixes:
[Thomas:
- Remove unneeded comment in Config.in
- Remove select if libiconv, not needed
- Add dependency on wchar, needed when we depend on gettext
- Improve Config.in help text
- Fix the format of the hash file to make it actually useful
- Fix the comment header in the .mk file
- Remove useless commented line in .mk file
- Fixup license information: it's not under GPLv3, but under LGPLv3+
(library) and GPLv3+ (test programs)
- Add host-pkgconf to the dependencies, remove libiconv from the
dependencies.
- Add a comment to explain why autoreconf is needed.
- Remove usage of $(MAKE1) that does look necessary.]
See
http://git.buildroot.net/buildroot/commit/?id=3af1d306bdc4144e243e453221a7ab5a49b14e56
for the final commit.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2 2/7] Adding gengetopt
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
2014-12-12 15:42 ` [Buildroot] [PATCH v2 1/7] Adding ding-libs Gregory Dymarek
@ 2014-12-12 15:42 ` Gregory Dymarek
2015-01-01 14:07 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 3/7] Adding libnice Gregory Dymarek
` (5 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Gregory Dymarek @ 2014-12-12 15:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
---
package/Config.in | 1 +
package/Config.in.host | 1 +
package/gengetopt/Config.in | 6 ++++++
package/gengetopt/Config.in.host | 6 ++++++
package/gengetopt/gengetopt.hash | 1 +
package/gengetopt/gengetopt.mk | 16 ++++++++++++++++
6 files changed, 31 insertions(+)
create mode 100644 package/gengetopt/Config.in
create mode 100644 package/gengetopt/Config.in.host
create mode 100644 package/gengetopt/gengetopt.hash
create mode 100644 package/gengetopt/gengetopt.mk
diff --git a/package/Config.in b/package/Config.in
index 9e3f11b..49fb8b3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -44,6 +44,7 @@ menu "Compressors and decompressors"
if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/gzip/Config.in"
endif
+ source "package/gengetopt/Config.in"
source "package/infozip/Config.in"
source "package/lz4/Config.in"
source "package/lzip/Config.in"
diff --git a/package/Config.in.host b/package/Config.in.host
index 0b7bc36..dd89bd3 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -8,6 +8,7 @@ menu "Host utilities"
source "package/e2tools/Config.in.host"
source "package/genext2fs/Config.in.host"
source "package/genimage/Config.in.host"
+ source "package/gengetopt/Config.in.host"
source "package/genpart/Config.in.host"
source "package/lpc3250loader/Config.in.host"
source "package/mke2img/Config.in.host"
diff --git a/package/gengetopt/Config.in b/package/gengetopt/Config.in
new file mode 100644
index 0000000..41d9f75
--- /dev/null
+++ b/package/gengetopt/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_GENGETOPT
+ bool "gengetopt"
+ help
+ Adds GNU Gengetopt
+ Gengetopt is a tool to write command line option parsing code for C programs.
+ http://www.gnu.org/software/gengetopt/gengetopt.html
diff --git a/package/gengetopt/Config.in.host b/package/gengetopt/Config.in.host
new file mode 100644
index 0000000..5be8312
--- /dev/null
+++ b/package/gengetopt/Config.in.host
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_HOST_GENGETOPT
+ bool "host gengetopt"
+ help
+ Adds GNU Gengetopt
+ Gengetopt is a tool to write command line option parsing code for C programs.
+ http://www.gnu.org/software/gengetopt/gengetopt.html
diff --git a/package/gengetopt/gengetopt.hash b/package/gengetopt/gengetopt.hash
new file mode 100644
index 0000000..5224cec
--- /dev/null
+++ b/package/gengetopt/gengetopt.hash
@@ -0,0 +1 @@
+sha256,30b05a88604d71ef2a42a2ef26cd26df242b41f5b011ad03083143a31d9b01f7
diff --git a/package/gengetopt/gengetopt.mk b/package/gengetopt/gengetopt.mk
new file mode 100644
index 0000000..692dfe1
--- /dev/null
+++ b/package/gengetopt/gengetopt.mk
@@ -0,0 +1,16 @@
+#############################################################
+#
+# gengetopt
+#
+#############################################################
+GENGETOPT_VERSION = 2.22.6
+GENGETOPT_SITE = ftp://ftp.gnu.org/gnu/gengetopt/
+GENGETOPT_AUTORECONF = YES
+GENGETOPT_LICENSE = GPLv3
+GENGETOPT_LICENSE_FILES = COPYING
+
+GENGETOPT_MAKE=$(MAKE1)
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
+
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [Buildroot] [PATCH v2 2/7] Adding gengetopt
2014-12-12 15:42 ` [Buildroot] [PATCH v2 2/7] Adding gengetopt Gregory Dymarek
@ 2015-01-01 14:07 ` Thomas Petazzoni
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2015-01-01 14:07 UTC (permalink / raw)
To: buildroot
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:42 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
> ---
> package/Config.in | 1 +
> package/Config.in.host | 1 +
> package/gengetopt/Config.in | 6 ++++++
> package/gengetopt/Config.in.host | 6 ++++++
> package/gengetopt/gengetopt.hash | 1 +
> package/gengetopt/gengetopt.mk | 16 ++++++++++++++++
> 6 files changed, 31 insertions(+)
> create mode 100644 package/gengetopt/Config.in
> create mode 100644 package/gengetopt/Config.in.host
> create mode 100644 package/gengetopt/gengetopt.hash
> create mode 100644 package/gengetopt/gengetopt.mk
Thanks, applied, after doing a number of changes:
[Thomas:
- Improve commit log.
- Remove target variant of the package, not needed as we don't do
development on the target.
- Remove Config.in.host option for the package, there is not really
a need to select it from menuconfig, it's merely a build
dependency for another package.
- Fix format of hash file.
- Fix format of comment header in .mk file.
- Use BR2_GNU_MIRROR.
- License is GPLv3+, not GPLv3.
- Add 'LICENSE' to the license files, as it indicates that the
license is GPLv3+.
- Add an explanation about $(MAKE1) being used.]
See the final commit at
http://git.buildroot.net/buildroot/commit/?id=dadd8dd0b913f41faf4412dab8100965bb3fc621.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2 3/7] Adding libnice
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
2014-12-12 15:42 ` [Buildroot] [PATCH v2 1/7] Adding ding-libs Gregory Dymarek
2014-12-12 15:42 ` [Buildroot] [PATCH v2 2/7] Adding gengetopt Gregory Dymarek
@ 2014-12-12 15:42 ` Gregory Dymarek
2014-12-31 16:05 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 4/7] Adding libsrtp Gregory Dymarek
` (4 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Gregory Dymarek @ 2014-12-12 15:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
---
package/Config.in | 1 +
package/libnice/Config.in | 6 ++++++
.../libnice/libnice-0001-build-IPV6_RECVERR.patch | 20 ++++++++++++++++++++
package/libnice/libnice.hash | 1 +
package/libnice/libnice.mk | 11 +++++++++++
5 files changed, 39 insertions(+)
create mode 100644 package/libnice/Config.in
create mode 100644 package/libnice/libnice-0001-build-IPV6_RECVERR.patch
create mode 100644 package/libnice/libnice.hash
create mode 100644 package/libnice/libnice.mk
diff --git a/package/Config.in b/package/Config.in
index 49fb8b3..e8c973e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -824,6 +824,7 @@ menu "Networking"
source "package/libmnl/Config.in"
source "package/libmodbus/Config.in"
source "package/libndp/Config.in"
+ source "package/libnice/Config.in"
source "package/libnetfilter_acct/Config.in"
source "package/libnetfilter_conntrack/Config.in"
source "package/libnetfilter_cthelper/Config.in"
diff --git a/package/libnice/Config.in b/package/libnice/Config.in
new file mode 100644
index 0000000..1ff8560
--- /dev/null
+++ b/package/libnice/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBNICE
+ bool "libnice"
+ select BR2_PACKAGE_LIBGLIB2
+ help
+ Adds libnice - The GLib ICE implementation
+ http://nice.freedesktop.org/wiki/
diff --git a/package/libnice/libnice-0001-build-IPV6_RECVERR.patch b/package/libnice/libnice-0001-build-IPV6_RECVERR.patch
new file mode 100644
index 0000000..39ef617
--- /dev/null
+++ b/package/libnice/libnice-0001-build-IPV6_RECVERR.patch
@@ -0,0 +1,20 @@
+diff -rupN libnice-0.1.8.orig/stun/usages/bind.c libnice-0.1.8/stun/usages/bind.c
+--- libnice-0.1.8.orig/stun/usages/bind.c 2014-09-22 18:01:28.000000000 +0100
++++ libnice-0.1.8/stun/usages/bind.c 2014-12-01 13:28:32.144707407 +0000
+@@ -257,12 +257,16 @@ static int stun_socket (int family, int
+ int yes = 1;
+ switch (family)
+ {
++#ifdef IP_RECVERR
+ case AF_INET:
+ setsockopt (fd, SOL_IP, IP_RECVERR, &yes, sizeof (yes));
++#endif
+ break;
++#ifdef IPV6_RECVERR
+ case AF_INET6:
+ setsockopt (fd, SOL_IPV6, IPV6_RECVERR, &yes, sizeof (yes));
+ break;
++#endif
+ default:
+ /* Nothing to do. */
+ break;
diff --git a/package/libnice/libnice.hash b/package/libnice/libnice.hash
new file mode 100644
index 0000000..39f15d9
--- /dev/null
+++ b/package/libnice/libnice.hash
@@ -0,0 +1 @@
+sha256,9da7f09909902d535389d929c3e4d69129528fb18438a6c8565ec812d9904ddf
diff --git a/package/libnice/libnice.mk b/package/libnice/libnice.mk
new file mode 100644
index 0000000..dd7f7a4
--- /dev/null
+++ b/package/libnice/libnice.mk
@@ -0,0 +1,11 @@
+#############################################################
+#
+# libnice
+#
+#############################################################
+LIBNICE_VERSION = 0.1.8
+LIBNICE_SITE = http://nice.freedesktop.org/releases/
+LIBNICE_DEPENDENCIES = libglib2
+LIBNICE_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [Buildroot] [PATCH v2 3/7] Adding libnice
2014-12-12 15:42 ` [Buildroot] [PATCH v2 3/7] Adding libnice Gregory Dymarek
@ 2014-12-31 16:05 ` Thomas Petazzoni
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2014-12-31 16:05 UTC (permalink / raw)
To: buildroot
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:43 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
Thanks, I've applied your patch, but after doing a fairly significant
set of changes. As detailed in the commit log:
[Thomas:
- Rename patch to the proper naming convention
- Reduce patch to only take care of the IPv6 case
- Add description in the patch
- Propagate libglib2 dependencies in Config.in + added the
corresponding comment.
- Added a real help text, and fixed the help text indentation.
- Fixed the comment header in the .mk file to have the right number
of # signs.
- Added the license informations
- Added a dependency on host-pkgconf, used by the configure script
- Added --without-gstreamer and --without-gstreamer-0.10 to be
explicit about the fact that we don't support GStreamer in libnice
for now.
- Fixed the hash file to have the proper format.]
See http://git.buildroot.net/buildroot/commit/?id=89502b9d56ad4f06954fae55684ef21525ad2515.
May I suggest you to compare the final commit and your original patch,
so that you can see what the issues were, for your upcoming
contributions?
Thanks a lot!
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2 4/7] Adding libsrtp
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
` (2 preceding siblings ...)
2014-12-12 15:42 ` [Buildroot] [PATCH v2 3/7] Adding libnice Gregory Dymarek
@ 2014-12-12 15:42 ` Gregory Dymarek
2015-01-01 10:30 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 5/7] Adding libwebsock Gregory Dymarek
` (3 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Gregory Dymarek @ 2014-12-12 15:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
---
package/Config.in | 1 +
package/libsrtp/Config.in | 5 +++++
package/libsrtp/libsrtp.hash | 1 +
package/libsrtp/libsrtp.mk | 13 +++++++++++++
4 files changed, 20 insertions(+)
create mode 100644 package/libsrtp/Config.in
create mode 100644 package/libsrtp/libsrtp.hash
create mode 100644 package/libsrtp/libsrtp.mk
diff --git a/package/Config.in b/package/Config.in
index e8c973e..501f505 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -843,6 +843,7 @@ menu "Networking"
source "package/libshairplay/Config.in"
source "package/libshout/Config.in"
source "package/libsoup/Config.in"
+ source "package/libsrtp/Config.in"
source "package/libstrophe/Config.in"
source "package/libtirpc/Config.in"
source "package/libtorrent/Config.in"
diff --git a/package/libsrtp/Config.in b/package/libsrtp/Config.in
new file mode 100644
index 0000000..b81e9cf
--- /dev/null
+++ b/package/libsrtp/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_LIBSRTP
+ bool "libsrtp"
+ help
+ Adds libsrtp
+ https://github.com/cisco/libsrtp
diff --git a/package/libsrtp/libsrtp.hash b/package/libsrtp/libsrtp.hash
new file mode 100644
index 0000000..18f3eea
--- /dev/null
+++ b/package/libsrtp/libsrtp.hash
@@ -0,0 +1 @@
+sha256,aefb6c068b201a051585976526e9795bb74d8540446657559622d31d0d755cbb
diff --git a/package/libsrtp/libsrtp.mk b/package/libsrtp/libsrtp.mk
new file mode 100644
index 0000000..7c76785
--- /dev/null
+++ b/package/libsrtp/libsrtp.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# libsrtp
+#
+#############################################################
+LIBSRTP_VERSION = v1.5.0
+LIBSRTP_SITE_METHOD = git
+#LIBSRTP_SITE = https://github.com/cisco/libsrtp/
+#LIBSRTP_AUTORECONF = YES
+LIBSRTP_INSTALL_STAGING = YES
+LIBSRTP_LICENSE = BSD-3c
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [Buildroot] [PATCH v2 4/7] Adding libsrtp
2014-12-12 15:42 ` [Buildroot] [PATCH v2 4/7] Adding libsrtp Gregory Dymarek
@ 2015-01-01 10:30 ` Thomas Petazzoni
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2015-01-01 10:30 UTC (permalink / raw)
To: buildroot
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:44 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
> ---
> package/Config.in | 1 +
> package/libsrtp/Config.in | 5 +++++
> package/libsrtp/libsrtp.hash | 1 +
> package/libsrtp/libsrtp.mk | 13 +++++++++++++
> 4 files changed, 20 insertions(+)
> create mode 100644 package/libsrtp/Config.in
> create mode 100644 package/libsrtp/libsrtp.hash
> create mode 100644 package/libsrtp/libsrtp.mk
Thanks, applied, after doing numerous changes:
[Thomas:
- Add better Config.in help text and fix its indentation
- Fix comment header in .mk file
- Uncomment useful commented lines in .mk file (SITE and AUTORECONF)
- Add LICENSE_FILES variable.
- Add handling of static/shared libraries build/installation.
- Add dependency on host-pkgconf, so that libsrtp installs its own
.pc file.
- Add optional dependency on OpenSSL.
- Use github helper.
- Remove hash file, since we're downloading from Git.]
See
http://git.buildroot.net/buildroot/commit/?id=10f42fa8ae8d05bf36fd5e65f0ab2a1315cab18d
for the final commit.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2 5/7] Adding libwebsock
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
` (3 preceding siblings ...)
2014-12-12 15:42 ` [Buildroot] [PATCH v2 4/7] Adding libsrtp Gregory Dymarek
@ 2014-12-12 15:42 ` Gregory Dymarek
2015-01-01 11:43 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 6/7] Adding sofia-sip Gregory Dymarek
` (2 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Gregory Dymarek @ 2014-12-12 15:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
---
package/Config.in | 1 +
package/libwebsock/Config.in | 6 ++++++
package/libwebsock/libwebsock.hash | 1 +
package/libwebsock/libwebsock.mk | 22 ++++++++++++++++++++++
4 files changed, 30 insertions(+)
create mode 100644 package/libwebsock/Config.in
create mode 100644 package/libwebsock/libwebsock.hash
create mode 100644 package/libwebsock/libwebsock.mk
diff --git a/package/Config.in b/package/Config.in
index 501f505..77430b9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -851,6 +851,7 @@ menu "Networking"
source "package/libupnpp/Config.in"
source "package/liburiparser/Config.in"
source "package/libvncserver/Config.in"
+ source "package/libwebsock/Config.in"
source "package/libwebsockets/Config.in"
source "package/neon/Config.in"
source "package/nss-mdns/Config.in"
diff --git a/package/libwebsock/Config.in b/package/libwebsock/Config.in
new file mode 100644
index 0000000..427b3fd
--- /dev/null
+++ b/package/libwebsock/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBWEBSOCK
+ bool "libwebsock"
+ select BR2_PACKAGE_LIBEVENT
+ help
+ Adds libwebsock
+ https://github.com/payden/libwebsock
diff --git a/package/libwebsock/libwebsock.hash b/package/libwebsock/libwebsock.hash
new file mode 100644
index 0000000..2250c09
--- /dev/null
+++ b/package/libwebsock/libwebsock.hash
@@ -0,0 +1 @@
+sha256,ac459d1de0205f8aedf2fd10a48cb02a06acb127c3403001670a839502e02afd
diff --git a/package/libwebsock/libwebsock.mk b/package/libwebsock/libwebsock.mk
new file mode 100644
index 0000000..f82b553
--- /dev/null
+++ b/package/libwebsock/libwebsock.mk
@@ -0,0 +1,22 @@
+#############################################################
+#
+# libwebsock
+#
+#############################################################
+LIBWEBSOCK_VERSION = 3c1615eeadb0b582b63851073bfe3e5132f31ebc
+LIBWEBSOCK_SITE_METHOD = git
+LIBWEBSOCK_SITE = https://github.com/payden/libwebsock.git
+LIBWEBSOCK_DEPENDENCIES = libevent
+LIBWEBSOCK_AUTORECONF = YES
+LIBWEBSOCK_INSTALL_STAGING = YES
+LIBWEBSOCK_LICENSE = LGPLv3
+LIBWEBSOCK_LICENSE_FILES = COPYING
+
+LIBWEBSOCK_CFLAGS = $(TARGET_CFLAGS)
+LIBWEBSOCK_LIBS += -lpthread -levent
+
+LIBWEBSOCK_CONF_ENV += \
+ CFLAGS="$(LIBWEBSOCK_CFLAGS)" \
+ LIBS="$(LIBWEBSOCK_LIBS)"
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [Buildroot] [PATCH v2 5/7] Adding libwebsock
2014-12-12 15:42 ` [Buildroot] [PATCH v2 5/7] Adding libwebsock Gregory Dymarek
@ 2015-01-01 11:43 ` Thomas Petazzoni
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2015-01-01 11:43 UTC (permalink / raw)
To: buildroot
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:45 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
> ---
> package/Config.in | 1 +
> package/libwebsock/Config.in | 6 ++++++
> package/libwebsock/libwebsock.hash | 1 +
> package/libwebsock/libwebsock.mk | 22 ++++++++++++++++++++++
> 4 files changed, 30 insertions(+)
> create mode 100644 package/libwebsock/Config.in
> create mode 100644 package/libwebsock/libwebsock.hash
> create mode 100644 package/libwebsock/libwebsock.mk
Thanks, committed, after doing a number of changes:
[Thomas:
- Add dependency on BR2_TOOLCHAIN_HAS_THREADS
- Improve Config.in help text
- Fixup comment header in .mk file.
- Use github helper.
- Remove hash file (we're downloading from Git)
- Fixup LICENSE_FILES
- Remove LIBWEBSOCK_CFLAGS, they were the default.
- Remove LIBWEBSOCK_LIBS, and instead use a patch to switch
libwebsock configure script to use pkg-config.]
See
http://git.buildroot.net/buildroot/commit/?id=a569dfc9db32dee4b07c56b70b8e4278f6451e6e
for the final commit.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2 6/7] Adding sofia-sip
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
` (4 preceding siblings ...)
2014-12-12 15:42 ` [Buildroot] [PATCH v2 5/7] Adding libwebsock Gregory Dymarek
@ 2014-12-12 15:42 ` Gregory Dymarek
2015-01-01 13:52 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 7/7] Adding janus-gateway Gregory Dymarek
2014-12-12 15:58 ` [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Vicente Olivert Riera
7 siblings, 1 reply; 17+ messages in thread
From: Gregory Dymarek @ 2014-12-12 15:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
---
package/Config.in | 1 +
package/sofia-sip/Config.in | 5 ++++
...ag.h-reintroduce-soatag_local_sdp_str_ref.patch | 26 ++++++++++++++++++
package/sofia-sip/sofia-sip.hash | 1 +
package/sofia-sip/sofia-sip.mk | 31 ++++++++++++++++++++++
5 files changed, 64 insertions(+)
create mode 100644 package/sofia-sip/Config.in
create mode 100644 package/sofia-sip/sofia-sip-1.12.11-0001-soa_tag.h-reintroduce-soatag_local_sdp_str_ref.patch
create mode 100644 package/sofia-sip/sofia-sip.hash
create mode 100644 package/sofia-sip/sofia-sip.mk
diff --git a/package/Config.in b/package/Config.in
index 77430b9..316d899 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -862,6 +862,7 @@ menu "Networking"
source "package/rtmpdump/Config.in"
source "package/slirp/Config.in"
source "package/snmppp/Config.in"
+ source "package/sofia-sip/Config.in"
source "package/thrift/Config.in"
source "package/usbredir/Config.in"
source "package/wvstreams/Config.in"
diff --git a/package/sofia-sip/Config.in b/package/sofia-sip/Config.in
new file mode 100644
index 0000000..d9045b5
--- /dev/null
+++ b/package/sofia-sip/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_SOFIA_SIP
+ bool "sofia-sip"
+ help
+ Adds Sofia-SIP Library
+ http://sofia-sip.sourceforge.net
diff --git a/package/sofia-sip/sofia-sip-1.12.11-0001-soa_tag.h-reintroduce-soatag_local_sdp_str_ref.patch b/package/sofia-sip/sofia-sip-1.12.11-0001-soa_tag.h-reintroduce-soatag_local_sdp_str_ref.patch
new file mode 100644
index 0000000..2d52348
--- /dev/null
+++ b/package/sofia-sip/sofia-sip-1.12.11-0001-soa_tag.h-reintroduce-soatag_local_sdp_str_ref.patch
@@ -0,0 +1,26 @@
+From bcd0f17fd83f2dfe570a3ab17249a5c7290b27f2 Mon Sep 17 00:00:00 2001
+From: Pekka Pessi <Pekka.Pessi@nokia.com>
+Date: Thu, 24 Mar 2011 14:45:21 +0200
+Subject: [PATCH] soa_tag.h: reintroduce soatag_local_sdp_str_ref
+
+Thanks to Erik Habicht <e.habicht@thiesen.com> for spotting it
+---
+ libsofia-sip-ua/soa/sofia-sip/soa_tag.h | 2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/libsofia-sip-ua/soa/sofia-sip/soa_tag.h b/libsofia-sip-ua/soa/sofia-sip/soa_tag.h
+index 723ca02..d9448d6 100644
+--- a/libsofia-sip-ua/soa/sofia-sip/soa_tag.h
++++ b/libsofia-sip-ua/soa/sofia-sip/soa_tag.h
+@@ -118,7 +118,7 @@ SOFIAPUBVAR tag_typedef_t soatag_local_sdp_ref;
+ SOFIAPUBVAR tag_typedef_t soatag_local_sdp_str;
+ #define SOATAG_LOCAL_SDP_STR_REF(x) \
+ soatag_local_sdp_str_ref, tag_str_vr(&(x))
+-SOFIAPUBVAR tag_typedef_t soatag_session_sdp_str_ref;
++SOFIAPUBVAR tag_typedef_t soatag_local_sdp_str_ref;
+
+ #define SOATAG_AF(x) soatag_af, tag_int_v((x))
+ SOFIAPUBVAR tag_typedef_t soatag_af;
+--
+1.7.7
+
diff --git a/package/sofia-sip/sofia-sip.hash b/package/sofia-sip/sofia-sip.hash
new file mode 100644
index 0000000..4f352c3
--- /dev/null
+++ b/package/sofia-sip/sofia-sip.hash
@@ -0,0 +1 @@
+sha256,2b01bc2e1826e00d1f7f57d29a2854b15fd5fe24695e47a14a735d195dd37c81
diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk
new file mode 100644
index 0000000..6be04f5
--- /dev/null
+++ b/package/sofia-sip/sofia-sip.mk
@@ -0,0 +1,31 @@
+#############################################################
+#
+# sofiasip
+#
+#############################################################
+SOFIA_SIP_VERSION = 1.12.11
+SOFIA_SIP_SOURCE = sofia-sip-$(SOFIA_SIP_VERSION).tar.gz
+SOFIA_SIP_SITE = http://downloads.sourceforge.net/project/sofia-sip/sofia-sip/$(SOFIA_SIP_VERSION)
+SOFIA_SIP_INSTALL_STAGING = YES
+
+ifeq ($(BR2_TOOLCHAIN_BUILDROOT_INET_IPV6),y)
+else
+ SOFIA_SIP_CONF_OPTS = --disable-ip6
+endif
+
+ifneq ($(BR2_HAVE_DOCUMENTATION),y)
+# If doxygen is not installed on the host, documentation won't be generated.
+ SOFIA_SIP_CONF_OPTS += --with-doxygen=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
+ SOFIA_SIP_CONF_OPTS += --with-glib
+ SOFIA_SIP_DEPENDENCIES += libglib2
+else
+ SOFIA_SIP_CONF_OPTS += --without-glib
+endif
+
+ifneq ($(BR2_ENABLE_DEBUG),y)
+ SOFIA_SIP_CONF_OPTS += --enable-ndebug
+endif
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [Buildroot] [PATCH v2 6/7] Adding sofia-sip
2014-12-12 15:42 ` [Buildroot] [PATCH v2 6/7] Adding sofia-sip Gregory Dymarek
@ 2015-01-01 13:52 ` Thomas Petazzoni
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2015-01-01 13:52 UTC (permalink / raw)
To: buildroot
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:46 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
> ---
> package/Config.in | 1 +
> package/sofia-sip/Config.in | 5 ++++
> ...ag.h-reintroduce-soatag_local_sdp_str_ref.patch | 26 ++++++++++++++++++
> package/sofia-sip/sofia-sip.hash | 1 +
> package/sofia-sip/sofia-sip.mk | 31 ++++++++++++++++++++++
> 5 files changed, 64 insertions(+)
> create mode 100644 package/sofia-sip/Config.in
> create mode 100644 package/sofia-sip/sofia-sip-1.12.11-0001-soa_tag.h-reintroduce-soatag_local_sdp_str_ref.patch
> create mode 100644 package/sofia-sip/sofia-sip.hash
> create mode 100644 package/sofia-sip/sofia-sip.mk
Thanks, applied, after doing a number of changes:
[Thomas:
- Add better Config.in help text.
- Fix the hash file format.
- Fix comment header in .mk file.
- Remove SOURCE variable, as it had the default value.
- Add dependency on host-pkgconf, used by the configure script.
- Add LICENSE and LICENSE_FILES variables.
- Do not use BR2_HAVE_DOCUMENTATION, this option has been
removed. Instead, always disable doxygen.
- Simplify the IPv6 test.
- Add optional dependency on OpenSSL.
- Fixup the handling of the --enable-ndebug.]
See the final commit at
http://git.buildroot.net/buildroot/commit/?id=fbfa66535072bf6bffdddfbe30f8adda801d13b2.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2 7/7] Adding janus-gateway
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
` (5 preceding siblings ...)
2014-12-12 15:42 ` [Buildroot] [PATCH v2 6/7] Adding sofia-sip Gregory Dymarek
@ 2014-12-12 15:42 ` Gregory Dymarek
2015-01-01 15:46 ` Thomas Petazzoni
2014-12-12 15:58 ` [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Vicente Olivert Riera
7 siblings, 1 reply; 17+ messages in thread
From: Gregory Dymarek @ 2014-12-12 15:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
---
package/Config.in | 1 +
package/janus-gateway/Config.in | 13 +++++++++++
.../janus-gateway-0001-disable-ssp.patch | 12 ++++++++++
package/janus-gateway/janus-gateway.hash | 1 +
package/janus-gateway/janus-gateway.mk | 27 ++++++++++++++++++++++
5 files changed, 54 insertions(+)
create mode 100644 package/janus-gateway/Config.in
create mode 100644 package/janus-gateway/janus-gateway-0001-disable-ssp.patch
create mode 100644 package/janus-gateway/janus-gateway.hash
create mode 100644 package/janus-gateway/janus-gateway.mk
diff --git a/package/Config.in b/package/Config.in
index 316d899..f02d695 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1055,6 +1055,7 @@ endif
source "package/iptraf-ng/Config.in"
source "package/iputils/Config.in"
source "package/iw/Config.in"
+ source "package/janus-gateway/Config.in"
source "package/kismet/Config.in"
source "package/knock/Config.in"
source "package/leafnode2/Config.in"
diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
new file mode 100644
index 0000000..3a201ba
--- /dev/null
+++ b/package/janus-gateway/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_JANUS_GATEWAY
+ bool "janus-gateway"
+ select BR2_PACKAGE_LIBMICROHTTPD
+ select BR2_PACKAGE_JANSSON
+ select BR2_PACKAGE_LIBNICE
+ select BR2_PACKAGE_SOFIA_SIP
+ select BR2_PACKAGE_LIBSRTP
+ select BR2_PACKAGE_DING_LIBS
+ select BR2_PACKAGE_LIBWEBSOCK
+ select BR2_PACKAGE_HOST_GENGETOPT
+ help
+ Adds janusgateway:
+ https://github.com/meetecho/janus-gateway
diff --git a/package/janus-gateway/janus-gateway-0001-disable-ssp.patch b/package/janus-gateway/janus-gateway-0001-disable-ssp.patch
new file mode 100644
index 0000000..5de8b3b
--- /dev/null
+++ b/package/janus-gateway/janus-gateway-0001-disable-ssp.patch
@@ -0,0 +1,12 @@
+diff -rupN janus-gateway-master.orig/Makefile.am janus-gateway-master/Makefile.am
+--- janus-gateway-master.orig/Makefile.am 2014-11-27 14:36:31.000000000 +0000
++++ janus-gateway-master/Makefile.am 2014-12-01 16:39:50.551935028 +0000
+@@ -14,7 +14,7 @@ AM_CFLAGS += -Wredundant-decls # sophia
+ # some fairly big refactoring though, which can wait.
+ # AM_CFLAGS += -Wshadow -Wstrict-aliasing=2
+
+-AM_CFLAGS += -fstack-protector-all -g -ggdb -fPIC -rdynamic
++AM_CFLAGS += -g -ggdb -fPIC -rdynamic
+
+ # FIXME: make docs work with distcheck
+ DISTCHECK_CONFIGURE_FLAGS = --disable-docs --enable-post-processing
diff --git a/package/janus-gateway/janus-gateway.hash b/package/janus-gateway/janus-gateway.hash
new file mode 100644
index 0000000..8be5bb2
--- /dev/null
+++ b/package/janus-gateway/janus-gateway.hash
@@ -0,0 +1 @@
+sha256,3e90f67810f78255042d3ab857629b510009052b6a334af4b80701cf2a824874
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
new file mode 100644
index 0000000..277a38c
--- /dev/null
+++ b/package/janus-gateway/janus-gateway.mk
@@ -0,0 +1,27 @@
+#############################################################
+#
+# janus-gateway
+#
+#############################################################
+JANUS_GATEWAY_VERSION = c632c1e9da5ffd8c34df6086a1aa5a8511a2a02d
+JANUS_GATEWAY_SITE_METHOD = git
+JANUS_GATEWAY_SITE = https://github.com/meetecho/janus-gateway.git
+JANUS_GATEWAY_LICENSE = GPLv3
+JANUS_GATEWAY_LICENSE_FILES = COPYING
+
+JANUS_GATEWAY_DEPENDENCIES = host-pkgconf libmicrohttpd jansson libnice sofia-sip libsrtp ding-libs libwebsock host-gengetopt
+
+# Straight out of the repository, no ./configure
+JANUS_GATEWAY_AUTORECONF = YES
+
+define JANUS_GATEWAY_M4
+ mkdir -p $(@D)/m4
+endef
+JANUS_GATEWAY_POST_PATCH_HOOKS += JANUS_GATEWAY_M4
+
+JANUS_GATEWAY_CONF_OPTS = --disable-data-channels \
+ --disable-rabbitmq
+
+JANUS_GATEWAY_MAKE=$(MAKE1)
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [Buildroot] [PATCH v2 7/7] Adding janus-gateway
2014-12-12 15:42 ` [Buildroot] [PATCH v2 7/7] Adding janus-gateway Gregory Dymarek
@ 2015-01-01 15:46 ` Thomas Petazzoni
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2015-01-01 15:46 UTC (permalink / raw)
To: buildroot
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:47 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
> ---
> package/Config.in | 1 +
> package/janus-gateway/Config.in | 13 +++++++++++
> .../janus-gateway-0001-disable-ssp.patch | 12 ++++++++++
> package/janus-gateway/janus-gateway.hash | 1 +
> package/janus-gateway/janus-gateway.mk | 27 ++++++++++++++++++++++
> 5 files changed, 54 insertions(+)
> create mode 100644 package/janus-gateway/Config.in
> create mode 100644 package/janus-gateway/janus-gateway-0001-disable-ssp.patch
> create mode 100644 package/janus-gateway/janus-gateway.hash
> create mode 100644 package/janus-gateway/janus-gateway.mk
Thanks, applied, with a number of changes:
[Thomas:
- Rename patch to the proper naming convention, and add a
description to it.
- Add mandatory dependency to OpenSSL.
- Make the dependency on libwebsock optional.
- Remove select of host-gengetopt, since this package no longer has
a menuconfig option.
- Add missing toolchain option dependencies inherited from selected
packages.
- Add proper Config.in help text.
- Fix the .mk comment header to the proper format.
- Use the github function and remove the unneeded SITE_METHOD
variable.
- Add support for optional Opus and Libogg support.
- Remove hash file, since the package is fetched from github.]
See the final commit at
http://git.buildroot.net/buildroot/commit/?id=f95c7e6fb9c0cf30eb769a8f0e272e76f36c5eae.
Also, could you:
* Submit the SSP patch to the upstream project, and ask them to create
the m4/ directory?
* Create a followup patch for Buildroot that adds a working example of
janus.cfg configuration file and an init script to start the janus
daemon? This way users of the package at least have a working
starting point.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
` (6 preceding siblings ...)
2014-12-12 15:42 ` [Buildroot] [PATCH v2 7/7] Adding janus-gateway Gregory Dymarek
@ 2014-12-12 15:58 ` Vicente Olivert Riera
2014-12-12 16:06 ` Gregory Dymarek
7 siblings, 1 reply; 17+ messages in thread
From: Vicente Olivert Riera @ 2014-12-12 15:58 UTC (permalink / raw)
To: buildroot
Dear Gregory Dymarek,
could you please login in your patchwork account and change the state of
your previous patch series to 'superseded'?
Thanks,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
^ permalink raw reply [flat|nested] 17+ messages in thread