[Buildroot] [PATCH 1/7] package/gstreamer1/gstreamer1: add optional support for libcap

[Buildroot] [PATCH 1/7] package/gstreamer1/gstreamer1: add optional support for libcap

[Bernd Kuhls]

When libcap was compiled before, gstreamer1 will use it as optional
dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/libexec/gstreamer-1.0/gst-ptp-helper | grep NEEDED | sort
 0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
[...]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/gstreamer1/gstreamer1/gstreamer1.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gstreamer1/gstreamer1/gstreamer1.mk b/package/gstreamer1/gstreamer1/gstreamer1.mk
index b788160..6761e8c 100644
--- a/package/gstreamer1/gstreamer1/gstreamer1.mk
+++ b/package/gstreamer1/gstreamer1/gstreamer1.mk
@@ -36,6 +36,13 @@ GSTREAMER1_CONF_OPTS = \
 
 GSTREAMER1_DEPENDENCIES = libglib2 host-pkgconf host-bison host-flex
 
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+GSTREAMER1_CONF_OPTS += --with-ptp-helper-permissions=capabilities
+GSTREAMER1_DEPENDENCIES += libcap
+else
+GSTREAMER1_CONF_OPTS += --with-ptp-helper-permissions=auto
+endif
+
 # gstreamer-1.6 changed the location of its gstconfig.h file,
 # and unfortunately, not all (by far!) consumers have been
 # updated to look in the correct location.
-- 
2.7.0

[Buildroot] [PATCH 2/7] package/gstreamer1/gst1-plugins-good: add optional support for libv4l

[Bernd Kuhls]

When libv4l was compiled before, gst1-plugins-good will use it as
optional dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/lib/gstreamer-1.0/libgstvideo4linux2.so | grep NEEDED | sort
[...]
 0x0000000000000001 (NEEDED)             Shared library: [libv4l2.so.0]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
index 92ce029..6bf17c0 100644
--- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
+++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
@@ -35,6 +35,13 @@ GST1_PLUGINS_GOOD_CONF_OPTS += \
 
 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base
 
+ifeq ($(BR2_PACKAGE_LIBV4L),y)
+GST1_PLUGINS_GOOD_CONF_OPTS += --with-libv4l2
+GST1_PLUGINS_GOOD_DEPENDENCIES += libv4l
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += --without-libv4l2
+endif
+
 ifeq ($(BR2_PACKAGE_ORC),y)
 GST1_PLUGINS_GOOD_CONF_OPTS += --enable-orc
 GST1_PLUGINS_GOOD_DEPENDENCIES += orc
-- 
2.7.0

[Buildroot] [PATCH 2/7] package/gstreamer1/gst1-plugins-good: add optional support for libv4l

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 21 Feb 2016 15:48:40 +0100, Bernd Kuhls wrote:
> When libv4l was compiled before, gst1-plugins-good will use it as
> optional dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/lib/gstreamer-1.0/libgstvideo4linux2.so | grep NEEDED | sort
> [...]
>  0x0000000000000001 (NEEDED)             Shared library: [libv4l2.so.0]
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/7] package/chrony: add optional support for libcap

[Bernd Kuhls]

When libcap was compiled before, chrony will use it as optional
dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/chronyd | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libm.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.1]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/chrony/chrony.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/chrony/chrony.mk b/package/chrony/chrony.mk
index 369d7eb..59faa10 100644
--- a/package/chrony/chrony.mk
+++ b/package/chrony/chrony.mk
@@ -16,6 +16,12 @@ CHRONY_CONF_OPTS = \
 	--without-seccomp \
 	--without-tomcrypt
 
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+CHRONY_DEPENDENCIES += libcap
+else
+CHRONY_CONF_OPTS += --without-libcap
+endif
+
 ifeq ($(BR2_PACKAGE_LIBNSS),y)
 CHRONY_DEPENDENCIES += host-pkgconf libnss
 else
-- 
2.7.0

[Buildroot] [PATCH 3/7] package/chrony: add optional support for libcap

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 21 Feb 2016 15:48:41 +0100, Bernd Kuhls wrote:
> When libcap was compiled before, chrony will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/chronyd | grep NEEDED
>  0x0000000000000001 (NEEDED)             Shared library: [libm.so.1]
>  0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
>  0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.1]
>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.1]
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/chrony/chrony.mk | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 4/7] package/kismet: add optional support for libcap

[Bernd Kuhls]

When libcap was compiled before, kismet will use it as optional
dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/bin/kismet_server | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
[...]

The build system offers no option to en-/disable libcap support:
https://www.kismetwireless.net/gitweb/?p=kismet.git;a=blob;f=configure.ac;h=e874b10f3c1d56e2deb5e8adf4b8da4066fdde56;hb=HEAD#l635

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kismet/kismet.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/kismet/kismet.mk b/package/kismet/kismet.mk
index 64a0ab2..f4a28b8 100644
--- a/package/kismet/kismet.mk
+++ b/package/kismet/kismet.mk
@@ -15,6 +15,10 @@ KISMET_LICENSE_FILES = debian/copyright
 # We touch configure.in:
 KISMET_AUTORECONF = YES
 
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+KISMET_DEPENDENCIES += libcap
+endif
+
 ifeq ($(BR2_PACKAGE_PCRE),y)
 KISMET_DEPENDENCIES += pcre
 endif
-- 
2.7.0

[Buildroot] [PATCH 4/7] package/kismet: add optional support for libcap

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 21 Feb 2016 15:48:42 +0100, Bernd Kuhls wrote:
> When libcap was compiled before, kismet will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/bin/kismet_server | grep NEEDED
>  0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
> [...]
> 
> The build system offers no option to en-/disable libcap support:
> https://www.kismetwireless.net/gitweb/?p=kismet.git;a=blob;f=configure.ac;h=e874b10f3c1d56e2deb5e8adf4b8da4066fdde56;hb=HEAD#l635
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/kismet/kismet.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 5/7] package/nfs-utils: add optional support for libcap

[Bernd Kuhls]

When libcap was compiled before, nfs-utils will use it as optional
dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/sm-notify | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libtirpc.so.3]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.1]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/nfs-utils/nfs-utils.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index 6dd175c..179009d 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -28,6 +28,13 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPCDEBUG) += usr/sbin/rpcdebug
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_LOCKD) += usr/sbin/rpc.lockd
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+NFS_UTILS_CONF_OPTS += --enable-caps
+NFS_UTILS_DEPENDENCIES += libcap
+else
+NFS_UTILS_CONF_OPTS += --disable-caps
+endif
+
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
 NFS_UTILS_CONF_OPTS += --enable-tirpc
 NFS_UTILS_DEPENDENCIES += libtirpc
-- 
2.7.0

[Buildroot] [PATCH 5/7] package/nfs-utils: add optional support for libcap

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 21 Feb 2016 15:48:43 +0100, Bernd Kuhls wrote:
> When libcap was compiled before, nfs-utils will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/sm-notify | grep NEEDED
>  0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
>  0x0000000000000001 (NEEDED)             Shared library: [libtirpc.so.3]
>  0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.1]
>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.1]
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/nfs-utils/nfs-utils.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 6/7] package/avahi: add optional support for libcap

[Bernd Kuhls]

When libcap was compiled before, avahi will use it as optional
dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/sbin/avahi-daemon | grep NEEDED | sort
 0x0000000000000001 (NEEDED)             Shared library: [libavahi-common.so.3]
 0x0000000000000001 (NEEDED)             Shared library: [libavahi-core.so.7]
 0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
[...]

The build system offers no option to en-/disable libcap support:
http://git.0pointer.net/avahi.git/tree/configure.ac#n382

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/avahi/avahi.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk
index 5d6e6a8..ce89e42 100644
--- a/package/avahi/avahi.mk
+++ b/package/avahi/avahi.mk
@@ -117,6 +117,9 @@ endif
 
 ifeq ($(BR2_PACKAGE_AVAHI_DAEMON),y)
 AVAHI_DEPENDENCIES += expat
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+AVAHI_DEPENDENCIES += libcap
+endif
 AVAHI_CONF_OPTS += --with-xml=expat
 else
 AVAHI_CONF_OPTS += --with-xml=none
-- 
2.7.0

[Buildroot] [PATCH 6/7] package/avahi: add optional support for libcap

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 21 Feb 2016 15:48:44 +0100, Bernd Kuhls wrote:

> diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk
> index 5d6e6a8..ce89e42 100644
> --- a/package/avahi/avahi.mk
> +++ b/package/avahi/avahi.mk
> @@ -117,6 +117,9 @@ endif
>  
>  ifeq ($(BR2_PACKAGE_AVAHI_DAEMON),y)
>  AVAHI_DEPENDENCIES += expat
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +AVAHI_DEPENDENCIES += libcap
> +endif

It is a bit weird to have this in the middle of the expat handling, IMO.

>  AVAHI_CONF_OPTS += --with-xml=expat
>  else
>  AVAHI_CONF_OPTS += --with-xml=none

Shouldn't we simply do:

ifeq ($(BR2_PACKAGE_EXPAT),y)
AVAHI_DEPENDENCIES += expat
AVAHI_CONF_OPTS += --with-xml=expat
else
AVAHI_CONF_OPTS += --with-xml=none
endif

ifeq ($(BR2_PACKAGE_LIBCAP),y)
AVAHI_DEPENDENCIES += libcap
endif

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 7/7] package/quagga: add optional support for libcap

[Bernd Kuhls]

When libcap was compiled before, quagga will use it as optional
dependency:

$ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/bin/vtysh | grep NEEDED | sort
 0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
[...]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/quagga/quagga.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
index c5dd2ba..30e8233 100644
--- a/package/quagga/quagga.mk
+++ b/package/quagga/quagga.mk
@@ -37,6 +37,12 @@ endif
 ifeq ($(BR2_PACKAGE_QUAGGA_VTYSH),y)
 QUAGGA_CONF_OPTS += --enable-vtysh
 QUAGGA_DEPENDENCIES += readline
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+QUAGGA_CONF_OPTS += --enable-capabilities
+QUAGGA_DEPENDENCIES += libcap
+else
+QUAGGA_CONF_OPTS += --disable-capabilities
+endif
 else
 QUAGGA_CONF_OPTS += --disable-vtysh
 endif
-- 
2.7.0

[Buildroot] [PATCH 7/7] package/quagga: add optional support for libcap

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 21 Feb 2016 15:48:45 +0100, Bernd Kuhls wrote:
> When libcap was compiled before, quagga will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/bin/vtysh | grep NEEDED | sort
>  0x0000000000000001 (NEEDED)             Shared library: [libcap.so.2]
> [...]
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/quagga/quagga.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
> index c5dd2ba..30e8233 100644
> --- a/package/quagga/quagga.mk
> +++ b/package/quagga/quagga.mk
> @@ -37,6 +37,12 @@ endif
>  ifeq ($(BR2_PACKAGE_QUAGGA_VTYSH),y)
>  QUAGGA_CONF_OPTS += --enable-vtysh
>  QUAGGA_DEPENDENCIES += readline
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +QUAGGA_CONF_OPTS += --enable-capabilities
> +QUAGGA_DEPENDENCIES += libcap
> +else
> +QUAGGA_CONF_OPTS += --disable-capabilities
> +endif
>  else
>  QUAGGA_CONF_OPTS += --disable-vtysh
>  endif

The capabilities option is global, not tied only with vtysh. Even if
vtysh seems to be the only user right now, it might change, so I
believe it's better to have this dependency outside the
BR2_PACKAGE_QUAGGA_VTYSH block.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/7] package/gstreamer1/gstreamer1: add optional support for libcap

[Thomas Petazzoni]

Bernd,

On Sun, 21 Feb 2016 15:48:39 +0100, Bernd Kuhls wrote:

> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +GSTREAMER1_CONF_OPTS += --with-ptp-helper-permissions=capabilities
> +GSTREAMER1_DEPENDENCIES += libcap
> +else
> +GSTREAMER1_CONF_OPTS += --with-ptp-helper-permissions=auto
> +endif

I am not entirely sure about this one. When BR2_PACKAGE_LIBCAP=y, are
we sure that the user wants to use capabilities for everything
including this GStreamer feature? There are other possible values for
--with-ptp-helper-permissions. So it would be good to have a commit log
that details a bit more the reasoning, other than just "it might use
libcap, so let's use it".

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com