* [Buildroot] [PATCH v3 3/3] flannel: new package
2016-04-04 19:31 [Buildroot] [PATCH v3 0/3] Add go language support Geoff Levand
@ 2016-04-04 19:31 ` Geoff Levand
2016-04-20 21:03 ` Thomas Petazzoni
2016-04-04 19:31 ` [Buildroot] [PATCH v3 2/3] go: new host package Geoff Levand
` (3 subsequent siblings)
4 siblings, 1 reply; 25+ messages in thread
From: Geoff Levand @ 2016-04-04 19:31 UTC (permalink / raw)
To: buildroot
Flannel is a virtual network that gives a subnet to each host for use
with container runtimes.
Cc: Brandon Philips <brandon.philips@coreos.com>
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
package/Config.in | 1 +
package/flannel/Config.in | 9 +++++++++
package/flannel/flannel.hash | 2 ++
package/flannel/flannel.mk | 42 ++++++++++++++++++++++++++++++++++++++++++
4 files changed, 54 insertions(+)
create mode 100644 package/flannel/Config.in
create mode 100644 package/flannel/flannel.hash
create mode 100644 package/flannel/flannel.mk
diff --git a/package/Config.in b/package/Config.in
index 64822bf..b7d9a17 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1374,6 +1374,7 @@ endif
source "package/faifa/Config.in"
source "package/fastd/Config.in"
source "package/fcgiwrap/Config.in"
+ source "package/flannel/Config.in"
source "package/fmc/Config.in"
source "package/fping/Config.in"
source "package/gesftpserver/Config.in"
diff --git a/package/flannel/Config.in b/package/flannel/Config.in
new file mode 100644
index 0000000..0da356d
--- /dev/null
+++ b/package/flannel/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_FLANNEL
+ bool "flannel"
+ depends on BR2_PACKAGE_GO_ARCH_SUPPORTS
+ select BR2_PACKAGE_HOST_GO
+ help
+ Flannel is a virtual network that gives a subnet to each host for use
+ with container runtimes.
+
+ https://github.com/coreos/flannel
diff --git a/package/flannel/flannel.hash b/package/flannel/flannel.hash
new file mode 100644
index 0000000..a19329a
--- /dev/null
+++ b/package/flannel/flannel.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 c09a76e80647282687b8db36f28dd3aede650f8f71dad0cf9f453f2ae3a0635d flannel-v0.5.5.tar.gz
diff --git a/package/flannel/flannel.mk b/package/flannel/flannel.mk
new file mode 100644
index 0000000..4c1d27e
--- /dev/null
+++ b/package/flannel/flannel.mk
@@ -0,0 +1,42 @@
+################################################################################
+#
+# flannel
+#
+################################################################################
+
+FLANNEL_VERSION = v0.5.5
+FLANNEL_SITE = $(call github,coreos,flannel.git,$(FLANNEL_VERSION))
+
+FLANNEL_LICENSE = Apache-2.0
+FLANNEL_LICENSE_FILES = LICENSE
+
+FLANNEL_DEPENDENCIES = host-go
+
+FLANNEL_MAKE_ENV = \
+ GOBIN="$(@D)/bin" \
+ GOPATH="$(@D)/gopath" \
+ GOARCH=$(GO_GOARCH) \
+ CGO_ENABLED=1
+
+FLANNEL_GLDFLAGS = \
+ -X github.com/coreos/flannel/version.Version=${FLANNEL_VERSION} \
+ -extldflags '-static'
+
+define FLANNEL_CONFIGURE_CMDS
+ # Put sources at prescribed GOPATH location.
+ mkdir -p $(@D)/gopath/src/github.com/coreos
+ ln -s $(@D) $(@D)/gopath/src/github.com/coreos/flannel
+endef
+
+define FLANNEL_BUILD_CMDS
+ cd $(@D) && $(FLANNEL_MAKE_ENV) $(HOST_GO_FINAL)/bin/go \
+ build -v -o $(@D)/bin/flanneld -ldflags "${FLANNEL_GLDFLAGS}" .
+endef
+
+define FLANNEL_INSTALL_TARGET_CMDS
+ # Install flannel to its well known location.
+ $(INSTALL) -D -m 0755 $(@D)/bin/flanneld $(TARGET_DIR)/opt/bin/flanneld
+ $(INSTALL) -D -m 0755 $(@D)/dist/mk-docker-opts.sh $(TARGET_DIR)/opt/bin/mk-docker-opts.sh
+endef
+
+$(eval $(generic-package))
--
2.5.0
^ permalink raw reply related [flat|nested] 25+ messages in thread* [Buildroot] [PATCH v3 3/3] flannel: new package
2016-04-04 19:31 ` [Buildroot] [PATCH v3 3/3] flannel: new package Geoff Levand
@ 2016-04-20 21:03 ` Thomas Petazzoni
0 siblings, 0 replies; 25+ messages in thread
From: Thomas Petazzoni @ 2016-04-20 21:03 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 04 Apr 2016 19:31:49 +0000, Geoff Levand wrote:
> Flannel is a virtual network that gives a subnet to each host for use
> with container runtimes.
>
> Cc: Brandon Philips <brandon.philips@coreos.com>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> package/Config.in | 1 +
> package/flannel/Config.in | 9 +++++++++
> package/flannel/flannel.hash | 2 ++
> package/flannel/flannel.mk | 42 ++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 54 insertions(+)
> create mode 100644 package/flannel/Config.in
> create mode 100644 package/flannel/flannel.hash
> create mode 100644 package/flannel/flannel.mk
Applied to master after doing the following changes:
[Thomas:
- Don't select BR2_PACKAGE_HOST_GO since this option was removed.
- Take into account the rename of BR2_PACKAGE_GO_ARCH_SUPPORTS to
BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS.
- Rewrap Config.in help text, it was slightly too large.
- Don't use the github function (the link was anyway incorrect), but
instead a direct link to the tarball, since the tarballs are
uploaded by the maintainers.
- Update the hash accordingly.
- Use $() to reference make variables and not ${}.
- Call the go compiler from $(HOST_DIR)/usr/bin, rather than from
HOST_GO_ROOT.]
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 2/3] go: new host package
2016-04-04 19:31 [Buildroot] [PATCH v3 0/3] Add go language support Geoff Levand
2016-04-04 19:31 ` [Buildroot] [PATCH v3 3/3] flannel: new package Geoff Levand
@ 2016-04-04 19:31 ` Geoff Levand
2016-04-20 21:03 ` Thomas Petazzoni
2016-04-04 19:31 ` [Buildroot] [PATCH v3 1/3] go-bootstrap: " Geoff Levand
` (2 subsequent siblings)
4 siblings, 1 reply; 25+ messages in thread
From: Geoff Levand @ 2016-04-04 19:31 UTC (permalink / raw)
To: buildroot
Add a new package 'go' which builds the host cross compiler and libraries for the
go programming language.
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
package/Config.in.host | 1 +
package/go/Config.in.host | 13 ++++++++
package/go/go.hash | 2 ++
package/go/go.mk | 75 +++++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 91 insertions(+)
create mode 100644 package/go/Config.in.host
create mode 100644 package/go/go.hash
create mode 100644 package/go/go.mk
diff --git a/package/Config.in.host b/package/Config.in.host
index a91612b..e646dfe 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -13,6 +13,7 @@ menu "Host utilities"
source "package/genext2fs/Config.in.host"
source "package/genimage/Config.in.host"
source "package/genpart/Config.in.host"
+ source "package/go/Config.in.host"
source "package/gptfdisk/Config.in.host"
source "package/imx-usb-loader/Config.in.host"
source "package/jq/Config.in.host"
diff --git a/package/go/Config.in.host b/package/go/Config.in.host
new file mode 100644
index 0000000..e69259c
--- /dev/null
+++ b/package/go/Config.in.host
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_GO_ARCH_SUPPORTS
+ bool
+ default y
+ depends on BR2_arm || BR2_aarch64 || BR2_i386 || BR2_x86_64 || BR2_powerpc
+ depends on !BR2_ARM_CPU_ARMV4
+
+config BR2_PACKAGE_HOST_GO
+ bool "host go"
+ depends on BR2_PACKAGE_GO_ARCH_SUPPORTS
+ help
+ The Go Programming Language.
+
+ https://golang.org
diff --git a/package/go/go.hash b/package/go/go.hash
new file mode 100644
index 0000000..e7c72de
--- /dev/null
+++ b/package/go/go.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 754e06dab1c31ab168fc9db9e32596734015ea9e24bc44cae7f237f417ce4efe go1.5.3.src.tar.gz
diff --git a/package/go/go.mk b/package/go/go.mk
new file mode 100644
index 0000000..8dd51b1
--- /dev/null
+++ b/package/go/go.mk
@@ -0,0 +1,75 @@
+################################################################################
+#
+# go
+#
+################################################################################
+
+GO_VERSION = 1.5.3
+GO_SITE = https://storage.googleapis.com/golang
+GO_SOURCE = go$(GO_VERSION).src.tar.gz
+
+GO_LICENSE = BSD-3c
+GO_LICENSE_FILES = LICENSE
+
+ifeq ($(BR2_arm),y)
+GO_GOARCH = arm
+else ifeq ($(BR2_aarch64),y)
+GO_GOARCH = arm64
+else ifeq ($(BR2_i386),y)
+GO_GOARCH = 386
+else ifeq ($(BR2_x86_64),y)
+GO_GOARCH = amd64
+else ifeq ($(BR2_powerpc),y)
+GO_GOARCH = ppc64
+else
+GO_GOARCH = unknown
+endif
+
+ifeq ($(BR2_arm)$(BR2_ARM_CPU_ARMV5),yy)
+GO_GOARM = 5
+else ifeq ($(BR2_arm)$(BR2_ARM_CPU_ARMV6),yy)
+GO_GOARM = 6
+else ifeq ($(BR2_arm)$(BR2_ARM_CPU_ARMV7A),yy)
+GO_GOARM = 7
+else ifeq ($(BR2_arm),y)
+GO_GOARM = unknown
+endif
+
+HOST_GO_DEPENDENCIES = host-go-bootstrap
+HOST_GO_FINAL = $(HOST_DIR)/usr/lib/go
+
+HOST_GO_MAKE_ENV = \
+ GOROOT_BOOTSTRAP=$(GO_BOOTSTRAP_FINAL) \
+ GOROOT_FINAL=$(HOST_GO_FINAL) \
+ GOROOT="$(@D)" \
+ GOBIN="$(@D)/bin" \
+ GOARCH=$(GO_GOARCH) \
+ GOARM=$(GO_GOARM) \
+ GOOS=linux \
+ CGO_ENABLED=1 \
+ CC_FOR_TARGET=$(TARGET_CC) \
+ CXX_FOR_TARGET=$(TARGET_CXX)
+
+define HOST_GO_BUILD_CMDS
+ cd $(@D)/src && $(HOST_GO_MAKE_ENV) ./make.bash
+endef
+
+define HOST_GO_INSTALL_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/bin/go $(HOST_GO_FINAL)/bin/go
+ $(INSTALL) -D -m 0755 $(@D)/bin/gofmt $(HOST_GO_FINAL)/bin/gofmt
+
+ ln -sf ../lib/go/bin/go $(HOST_DIR)/usr/bin/
+ ln -sf ../lib/go/bin/gofmt $(HOST_DIR)/usr/bin/
+
+ cp -a $(@D)/lib $(HOST_GO_FINAL)/
+
+ mkdir -p $(HOST_GO_FINAL)/pkg
+ cp -a $(@D)/pkg/include $(@D)/pkg/linux_* $(HOST_GO_FINAL)/pkg/
+ cp -a $(@D)/pkg/tool $(HOST_GO_FINAL)/pkg/
+
+ # There is a known issue which requires the go sources to be installed
+ # https://golang.org/issue/2775
+ cp -a $(@D)/src $(HOST_GO_FINAL)/
+endef
+
+$(eval $(host-generic-package))
--
2.5.0
^ permalink raw reply related [flat|nested] 25+ messages in thread* [Buildroot] [PATCH v3 2/3] go: new host package
2016-04-04 19:31 ` [Buildroot] [PATCH v3 2/3] go: new host package Geoff Levand
@ 2016-04-20 21:03 ` Thomas Petazzoni
0 siblings, 0 replies; 25+ messages in thread
From: Thomas Petazzoni @ 2016-04-20 21:03 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 04 Apr 2016 19:31:49 +0000, Geoff Levand wrote:
> Add a new package 'go' which builds the host cross compiler and libraries for the
> go programming language.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> package/Config.in.host | 1 +
> package/go/Config.in.host | 13 ++++++++
> package/go/go.hash | 2 ++
> package/go/go.mk | 75 +++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 91 insertions(+)
> create mode 100644 package/go/Config.in.host
> create mode 100644 package/go/go.hash
> create mode 100644 package/go/go.mk
Applied to master after doing the following changes:
[Thomas:
- Put the computation of GO_GOARM inside the ifeq ($(BR2_arm),y)
condition rather than duplicating this condition.
- Remove the GO_GOARCH=unknown case, since there is no way to fall in
this case as only supported architectures can use host-go.
- Remove the GO_GOARM=unknown case, since we are sure that only
ARMv5/6/7 will use host-go.
- Rename HOST_GO_FINAL to HOST_GO_ROOT, since it's really the "root"
of the Go installation.
- Remove visible Config.in.host option.]
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
2016-04-04 19:31 [Buildroot] [PATCH v3 0/3] Add go language support Geoff Levand
2016-04-04 19:31 ` [Buildroot] [PATCH v3 3/3] flannel: new package Geoff Levand
2016-04-04 19:31 ` [Buildroot] [PATCH v3 2/3] go: new host package Geoff Levand
@ 2016-04-04 19:31 ` Geoff Levand
2016-04-20 21:02 ` Thomas Petazzoni
2016-04-06 5:05 ` [Buildroot] [PATCH v3 0/3] Add go language support Christian Stewart
2016-04-21 20:43 ` Thomas Petazzoni
4 siblings, 1 reply; 25+ messages in thread
From: Geoff Levand @ 2016-04-04 19:31 UTC (permalink / raw)
To: buildroot
Add a new package go-bootstrap which builds a bootstrap compiler for the
go programming language.
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
package/go-bootstrap/go-bootstrap.hash | 2 ++
package/go-bootstrap/go-bootstrap.mk | 38 ++++++++++++++++++++++++++++++++++
2 files changed, 40 insertions(+)
create mode 100644 package/go-bootstrap/go-bootstrap.hash
create mode 100644 package/go-bootstrap/go-bootstrap.mk
diff --git a/package/go-bootstrap/go-bootstrap.hash b/package/go-bootstrap/go-bootstrap.hash
new file mode 100644
index 0000000..1d0566a
--- /dev/null
+++ b/package/go-bootstrap/go-bootstrap.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 299a6fd8f8adfdce15bc06bde926e7b252ae8e24dd5b16b7d8791ed79e7b5e9b go1.4.2.src.tar.gz
diff --git a/package/go-bootstrap/go-bootstrap.mk b/package/go-bootstrap/go-bootstrap.mk
new file mode 100644
index 0000000..ccb932d
--- /dev/null
+++ b/package/go-bootstrap/go-bootstrap.mk
@@ -0,0 +1,38 @@
+################################################################################
+#
+# go-bootstrap
+#
+################################################################################
+
+GO_BOOTSTRAP_VERSION = 1.4.2
+GO_BOOTSTRAP_SITE = https://storage.googleapis.com/golang
+GO_BOOTSTRAP_SOURCE = go$(GO_BOOTSTRAP_VERSION).src.tar.gz
+
+GO_BOOTSTRAP_LICENSE = BSD-3c
+GO_BOOTSTRAP_LICENSE_FILES = LICENSE
+
+GO_BOOTSTRAP_FINAL = $(HOST_DIR)/usr/lib/go-$(GO_BOOTSTRAP_VERSION)
+
+GO_BOOTSTRAP_MAKE_ENV = \
+ GOOS=linux \
+ GOROOT_FINAL="$(GO_BOOTSTRAP_FINAL)" \
+ GOROOT="$(@D)" \
+ GOBIN="$(@D)/bin"
+
+define HOST_GO_BOOTSTRAP_BUILD_CMDS
+ cd $(@D)/src && $(GO_BOOTSTRAP_MAKE_ENV) ./make.bash
+endef
+
+define HOST_GO_BOOTSTRAP_INSTALL_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/bin/go $(GO_BOOTSTRAP_FINAL)/bin/go
+ $(INSTALL) -D -m 0755 $(@D)/bin/gofmt $(GO_BOOTSTRAP_FINAL)/bin/gofmt
+
+ cp -a $(@D)/lib $(GO_BOOTSTRAP_FINAL)/
+ cp -a $(@D)/pkg $(GO_BOOTSTRAP_FINAL)/
+
+ # There is a known issue which requires the go sources to be installed
+ # https://golang.org/issue/2775
+ cp -a $(@D)/src $(GO_BOOTSTRAP_FINAL)/
+endef
+
+$(eval $(host-generic-package))
--
2.5.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
2016-04-04 19:31 ` [Buildroot] [PATCH v3 1/3] go-bootstrap: " Geoff Levand
@ 2016-04-20 21:02 ` Thomas Petazzoni
2016-04-22 1:09 ` Cam Hutchison
0 siblings, 1 reply; 25+ messages in thread
From: Thomas Petazzoni @ 2016-04-20 21:02 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 04 Apr 2016 19:31:49 +0000, Geoff Levand wrote:
> Add a new package go-bootstrap which builds a bootstrap compiler for the
> go programming language.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> package/go-bootstrap/go-bootstrap.hash | 2 ++
> package/go-bootstrap/go-bootstrap.mk | 38 ++++++++++++++++++++++++++++++++++
> 2 files changed, 40 insertions(+)
> create mode 100644 package/go-bootstrap/go-bootstrap.hash
> create mode 100644 package/go-bootstrap/go-bootstrap.mk
I've applied to master after doing the following changes:
[Thomas:
- Rename GO_BOOTSTRAP_FINAL to HOST_GO_BOOTSTRAP_ROOT. Use the HOST_
prefix because this variable is specific to the host variant. And
it's not "final" at all, but rather the "root" of the Go Bootstrap
installation.
- Rename GO_BOOTSTRAP_MAKE_ENV to HOST_GO_BOOTSTRAP_MAKE_ENV, also to
have the HOST_ prefix because it's a host package.]
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 25+ messages in thread* [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
2016-04-20 21:02 ` Thomas Petazzoni
@ 2016-04-22 1:09 ` Cam Hutchison
2016-04-22 9:51 ` Thomas Petazzoni
0 siblings, 1 reply; 25+ messages in thread
From: Cam Hutchison @ 2016-04-22 1:09 UTC (permalink / raw)
To: buildroot
Hi Thomas,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>On Mon, 04 Apr 2016 19:31:49 +0000, Geoff Levand wrote:
>> Add a new package go-bootstrap which builds a bootstrap compiler for the
>> go programming language.
>>
>I've applied to master after doing the following changes:
> [Thomas:
> - Rename GO_BOOTSTRAP_FINAL to HOST_GO_BOOTSTRAP_ROOT. Use the HOST_
> prefix because this variable is specific to the host variant. And
> it's not "final" at all, but rather the "root" of the Go Bootstrap
> installation.
> - Rename GO_BOOTSTRAP_MAKE_ENV to HOST_GO_BOOTSTRAP_MAKE_ENV, also to
> have the HOST_ prefix because it's a host package.]
I just started playing with these patches a few days ago and made a local
change to this patch that made sense to me - I removed the
HOST_GO_BOOTSTRAP_INSTALL_CMDS because I did not see that it was useful
to have the bootstrap compiler installed in the HOST_DIR. This mattered
for me as I build the toolchain and install it system-wide to use for
other builds, which refer to that toolchain as an external one.
I then changed the second patch to use HOST_GO_BOOTSTRAP_BUILDDIR
instead of GO_BOOTSTRAP_FINAL.
Does this make sense to have in buildroot?
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
2016-04-22 1:09 ` Cam Hutchison
@ 2016-04-22 9:51 ` Thomas Petazzoni
2016-04-22 21:41 ` Cam Hutchison
0 siblings, 1 reply; 25+ messages in thread
From: Thomas Petazzoni @ 2016-04-22 9:51 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 22 Apr 2016 11:09:50 +1000, Cam Hutchison wrote:
> I just started playing with these patches a few days ago and made a local
> change to this patch that made sense to me - I removed the
> HOST_GO_BOOTSTRAP_INSTALL_CMDS because I did not see that it was useful
> to have the bootstrap compiler installed in the HOST_DIR. This mattered
> for me as I build the toolchain and install it system-wide to use for
> other builds, which refer to that toolchain as an external one.
>
> I then changed the second patch to use HOST_GO_BOOTSTRAP_BUILDDIR
> instead of GO_BOOTSTRAP_FINAL.
>
> Does this make sense to have in buildroot?
We normally try to not use things from the build directory of package A
when building package B. In an ideal world, things should be
implemented as if we could remove the build directory of a package once
it has been installed in the host/staging/target directories. It should
therefore install there everything that might be needed by packages
that depend on that package.
That being said:
1/ There are already numerous exceptions to this rule. For example,
all the external kernel modules directly refer to $(LINUX_DIR). And
I guess there are other cases as well.
2/ The host-go-bootstrap case is also somewhat special.
Let's see what Arnout/Peter/Yann think about this, whether we really
need to enforce this rule or not.
However, back to your original problem, I don't really see why the fact
that host-go-bootstrap is installed in $(HOST_DIR) prevents you from
installing the toolchain system-wide for use by other builds. Yes, it
increases the size of the host directory, but other than that I don't
see the technical limitation.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 25+ messages in thread* [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
2016-04-22 9:51 ` Thomas Petazzoni
@ 2016-04-22 21:41 ` Cam Hutchison
2016-04-22 21:49 ` Thomas Petazzoni
0 siblings, 1 reply; 25+ messages in thread
From: Cam Hutchison @ 2016-04-22 21:41 UTC (permalink / raw)
To: buildroot
Thomas Petazzoni wrote:
> Hello,
>
> On Fri, 22 Apr 2016 11:09:50 +1000, Cam Hutchison wrote:
>
> > [leaving and using host-go-bootstrap in its BUILDDIR]
>
> We normally try to not use things from the build directory of package A
> when building package B.
I agree that it is not ideal to reach into the builddir of another
package. Ludovic Guegan implemented an alternative where the host-golang
package encapsulated the bootstrap compiler rather than using a separate
package. This makes some sense since the bootstrap compiler is purely
internal to the build of the go compiler.
But the implementation meant that extraction and build of the bootstrap
compiler was just replicaing what buildroot already does and gave less
control (you couldn't run "make host-go-bootstrap-build" for example),
which made it more tedious to iterate some change I was trying.
A separate go-bootstrap package makes better use of buildroot's
infrastructure.
> However, back to your original problem, I don't really see why the fact
> that host-go-bootstrap is installed in $(HOST_DIR) prevents you from
> installing the toolchain system-wide for use by other builds. Yes, it
> increases the size of the host directory, but other than that I don't
> see the technical limitation.
With two go compiler installed in the host dir, it becomes possible for
someone to use the wrong one. Since the sources are also installed in
the host dir, two sets of sources - one older than the other - will be
installed. That's annoying when you want to index it (ctags, etc) for
easy navigation. Having both full compilers (one completely unncessary)
just feels like laying a land mine.
When it is just the outputdir, I don't mind so much but when installed
system-wide, I'm usually quite careful about what gets installed.
I could also just delete it in a post-install script. But not doing
something is better than doing it and undoing it.
Perhaps this is just all personal preference, in which case I'll
maintain a local patch. I'm happy that go has made it into buildroot.
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
2016-04-22 21:41 ` Cam Hutchison
@ 2016-04-22 21:49 ` Thomas Petazzoni
2016-04-23 8:34 ` Peter Korsgaard
0 siblings, 1 reply; 25+ messages in thread
From: Thomas Petazzoni @ 2016-04-22 21:49 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 23 Apr 2016 07:41:56 +1000, Cam Hutchison wrote:
> I agree that it is not ideal to reach into the builddir of another
> package. Ludovic Guegan implemented an alternative where the host-golang
> package encapsulated the bootstrap compiler rather than using a separate
> package. This makes some sense since the bootstrap compiler is purely
> internal to the build of the go compiler.
That's obviously an alternate way: have the host-go compiler download
the bootstrap compiler as <pkg>_EXTRA_DOWNLOADS, and take care to
extract it / install it temporarily. Not sure it is really better, and
I agree with you that the current status make a better use of the
Buildroot package infrastructure.
> > However, back to your original problem, I don't really see why the fact
> > that host-go-bootstrap is installed in $(HOST_DIR) prevents you from
> > installing the toolchain system-wide for use by other builds. Yes, it
> > increases the size of the host directory, but other than that I don't
> > see the technical limitation.
>
> With two go compiler installed in the host dir, it becomes possible for
> someone to use the wrong one. Since the sources are also installed in
> the host dir, two sets of sources - one older than the other - will be
> installed. That's annoying when you want to index it (ctags, etc) for
> easy navigation. Having both full compilers (one completely unncessary)
> just feels like laying a land mine.
>
> When it is just the outputdir, I don't mind so much but when installed
> system-wide, I'm usually quite careful about what gets installed.
>
> I could also just delete it in a post-install script. But not doing
> something is better than doing it and undoing it.
Your arguments make sense. Let's see what others think about it.
> Perhaps this is just all personal preference, in which case I'll
> maintain a local patch. I'm happy that go has made it into buildroot.
I'm happy to have finally found the time to review and merge those
patches. If you're interested in go, can you have a look at the build
failures that I pointed to Geoff? See:
http://lists.busybox.net/pipermail/buildroot/2016-April/159336.html
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 1/3] go-bootstrap: new host package
2016-04-22 21:49 ` Thomas Petazzoni
@ 2016-04-23 8:34 ` Peter Korsgaard
0 siblings, 0 replies; 25+ messages in thread
From: Peter Korsgaard @ 2016-04-23 8:34 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
>> When it is just the outputdir, I don't mind so much but when installed
>> system-wide, I'm usually quite careful about what gets installed.
>>
>> I could also just delete it in a post-install script. But not doing
>> something is better than doing it and undoing it.
> Your arguments make sense. Let's see what others think about it.
I also don't really see any better way. This solution is OK with me.
--
Venlig hilsen,
Peter Korsgaard
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-04-04 19:31 [Buildroot] [PATCH v3 0/3] Add go language support Geoff Levand
` (2 preceding siblings ...)
2016-04-04 19:31 ` [Buildroot] [PATCH v3 1/3] go-bootstrap: " Geoff Levand
@ 2016-04-06 5:05 ` Christian Stewart
2016-04-06 16:23 ` Geoff Levand
2016-04-21 20:43 ` Thomas Petazzoni
4 siblings, 1 reply; 25+ messages in thread
From: Christian Stewart @ 2016-04-06 5:05 UTC (permalink / raw)
To: buildroot
All,
On Mon, Apr 4, 2016 at 3:32 PM Geoff Levand <geoff@infradead.org> wrote:
> This series adds support for the go programming language. I tested the
> build of
> the included flannel package on i386, powerpc64, arm (32 bit) and arm64.
> I did
> runtime testing of the generated flannel binary on arm64.
I haven't had a chance yet to test these on an actual device. However, I've
read through the patches and everything looks good to me. Also, a test
compile resulted in success for my target env.
@Geoff you may add my Acked-by to the commits:
Acked-by: Christian Stewart <christian@paral.in>
In early May we will be returning to work on the Docker-under-Buildroot
related stuff, and I will be rebasing my Docker series on top of this. If
someone else wants to pick that up, please feel free as my work on that is
still a month out.
In the meantime, thanks for the work Geoff, and I look forward to using
your patches in our lab.
Best,
Christian Stewart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160406/f249e968/attachment.html>
^ permalink raw reply [flat|nested] 25+ messages in thread* [Buildroot] [PATCH v3 0/3] Add go language support
2016-04-04 19:31 [Buildroot] [PATCH v3 0/3] Add go language support Geoff Levand
` (3 preceding siblings ...)
2016-04-06 5:05 ` [Buildroot] [PATCH v3 0/3] Add go language support Christian Stewart
@ 2016-04-21 20:43 ` Thomas Petazzoni
2016-04-25 16:27 ` Geoff Levand
2016-04-29 21:26 ` Geoff Levand
4 siblings, 2 replies; 25+ messages in thread
From: Thomas Petazzoni @ 2016-04-21 20:43 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 04 Apr 2016 19:31:49 +0000, Geoff Levand wrote:
> Geoff Levand (3):
> go-bootstrap: new host package
> go: new host package
> flannel: new package
Now that those patches have been merged, we're starting to see some
build issues:
- With host-go:
http://autobuild.buildroot.org/?reason=host-go-1.5.3
- With flannel:
http://autobuild.buildroot.org/?reason=flannel-v0.5.5
Could you have a look at those build problems?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 25+ messages in thread* [Buildroot] [PATCH v3 0/3] Add go language support
2016-04-21 20:43 ` Thomas Petazzoni
@ 2016-04-25 16:27 ` Geoff Levand
2016-04-29 21:26 ` Geoff Levand
1 sibling, 0 replies; 25+ messages in thread
From: Geoff Levand @ 2016-04-25 16:27 UTC (permalink / raw)
To: buildroot
On Thu, 2016-04-21 at 22:43 +0200, Thomas Petazzoni wrote:
> Now that those patches have been merged, we're starting to see some
> build issues:
>
> - With host-go:
> http://autobuild.buildroot.org/?reason=host-go-1.5.3
>
> - With flannel:
> http://autobuild.buildroot.org/?reason=flannel-v0.5.5
>
> Could you have a look at those build problems?
I'll look into them.
-Geoff
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-04-21 20:43 ` Thomas Petazzoni
2016-04-25 16:27 ` Geoff Levand
@ 2016-04-29 21:26 ` Geoff Levand
2016-04-30 12:03 ` Thomas Petazzoni
1 sibling, 1 reply; 25+ messages in thread
From: Geoff Levand @ 2016-04-29 21:26 UTC (permalink / raw)
To: buildroot
On Thu, 2016-04-21 at 22:43 +0200, Thomas Petazzoni wrote:
> Now that those patches have been merged, we're starting to see some
> build issues:
>
> - With host-go:
> http://autobuild.buildroot.org/?reason=host-go-1.5.3
>
> - With flannel:
> http://autobuild.buildroot.org/?reason=flannel-v0.5.5
Just to give an update, I've got fixes for the host-go problems,
and am working on the flannel problem.
WIP patches are in my master branch here:
git at github.com:glevand/buildroot--buildroot.git
-Geoff
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-04-29 21:26 ` Geoff Levand
@ 2016-04-30 12:03 ` Thomas Petazzoni
2016-05-01 3:43 ` Christian Stewart
2016-05-02 16:21 ` Geoff Levand
0 siblings, 2 replies; 25+ messages in thread
From: Thomas Petazzoni @ 2016-04-30 12:03 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 29 Apr 2016 14:26:00 -0700, Geoff Levand wrote:
> Just to give an update, I've got fixes for the host-go problems,
> and am working on the flannel problem.
>
> WIP patches are in my master branch here:
>
> git at github.com:glevand/buildroot--buildroot.git
Hum, I'm looking at this repository, and I see only 3 branches, and
none of them seem to contain things that look like fixes. Did I miss
something?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-04-30 12:03 ` Thomas Petazzoni
@ 2016-05-01 3:43 ` Christian Stewart
2016-05-02 16:37 ` Geoff Levand
2016-05-02 16:21 ` Geoff Levand
1 sibling, 1 reply; 25+ messages in thread
From: Christian Stewart @ 2016-05-01 3:43 UTC (permalink / raw)
To: buildroot
Geoff, Thomas,
On Sat, Apr 30, 2016 at 8:03 AM Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote: > Hum, I'm looking at this repository, and I see only 3 branches, and none of them seem to contain things that look like fixes. Did I miss something?
If I try to directly compile something that references Go, it seems that Go does
not have the cross compiler as a dependency in the Makefile tree.
# runtime/cgo fork/exec
/home/paralin/Documents/skiffos/buildroot/output/host/usr/bin/arm-buildroot-linux-gnueabi-gcc:
no such file or directory
Indeed, the cross compiler toolchain is NOT compiled before Go. I think a
dependency needs to be added for this.
Thanks, Christian Stewart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160501/a2286545/attachment.html>
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-05-01 3:43 ` Christian Stewart
@ 2016-05-02 16:37 ` Geoff Levand
2016-05-03 7:08 ` Thomas Petazzoni
0 siblings, 1 reply; 25+ messages in thread
From: Geoff Levand @ 2016-05-02 16:37 UTC (permalink / raw)
To: buildroot
On Sun, 2016-05-01 at 03:43 +0000, Christian Stewart wrote:
> Indeed, the cross compiler toolchain is NOT compiled before Go. I
> think a dependency needs to be added for this.
I have the patch below that adds BR2_TOOLCHAIN_HAS_THREADS. Is
it enough to pull in the toolchain?
-Geoff
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-05-02 16:37 ` Geoff Levand
@ 2016-05-03 7:08 ` Thomas Petazzoni
2016-05-06 19:57 ` Geoff Levand
0 siblings, 1 reply; 25+ messages in thread
From: Thomas Petazzoni @ 2016-05-03 7:08 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 02 May 2016 09:37:50 -0700, Geoff Levand wrote:
> I have the patch below that adds BR2_TOOLCHAIN_HAS_THREADS. Is
> it enough to pull in the toolchain?
No, adding dependencies at the Config.in level doesn't change anything
in terms of build order.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-05-03 7:08 ` Thomas Petazzoni
@ 2016-05-06 19:57 ` Geoff Levand
2016-05-06 19:58 ` Geoff Levand
0 siblings, 1 reply; 25+ messages in thread
From: Geoff Levand @ 2016-05-06 19:57 UTC (permalink / raw)
To: buildroot
On Tue, 2016-05-03 at 09:08 +0200, Thomas Petazzoni wrote:
> On Mon, 02 May 2016 09:37:50 -0700, Geoff Levand wrote:
>
> > I have the patch below that adds BR2_TOOLCHAIN_HAS_THREADS. Is
> > it enough to pull in the toolchain?
>
> No, adding dependencies at the Config.in level doesn't change anything
> in terms of build order.
It seems one of these in go-bootstrap.mk should work, is either
one prefered?
+HOST_GO_BOOTSTRAP_DEPENDENCIES = host-go-bootstrap
+HOST_GO_BOOTSTRAP_ADD_TOOLCHAIN_DEPENDENCY = YES
-Geoff
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-05-06 19:57 ` Geoff Levand
@ 2016-05-06 19:58 ` Geoff Levand
2016-05-07 23:48 ` Arnout Vandecappelle
0 siblings, 1 reply; 25+ messages in thread
From: Geoff Levand @ 2016-05-06 19:58 UTC (permalink / raw)
To: buildroot
On Fri, 2016-05-06 at 12:57 -0700, Geoff Levand wrote:
> On Tue, 2016-05-03 at 09:08 +0200, Thomas Petazzoni wrote:
> > On Mon, 02 May 2016 09:37:50 -0700, Geoff Levand wrote:
> >
> > > I have the patch below that adds BR2_TOOLCHAIN_HAS_THREADS. Is
> > > it enough to pull in the toolchain?
> >
> > No, adding dependencies at the Config.in level doesn't change
> > anything
> > in terms of build order.
>
> It seems one of these in go-bootstrap.mk should work, is either
> one prefered?
>
> +HOST_GO_BOOTSTRAP_DEPENDENCIES = host-go-bootstrap
+HOST_GO_BOOTSTRAP_DEPENDENCIES = host-toolchain
>
> +HOST_GO_BOOTSTRAP_ADD_TOOLCHAIN_DEPENDENCY = YES
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-05-06 19:58 ` Geoff Levand
@ 2016-05-07 23:48 ` Arnout Vandecappelle
0 siblings, 0 replies; 25+ messages in thread
From: Arnout Vandecappelle @ 2016-05-07 23:48 UTC (permalink / raw)
To: buildroot
On 05/06/16 21:58, Geoff Levand wrote:
> On Fri, 2016-05-06 at 12:57 -0700, Geoff Levand wrote:
>> On Tue, 2016-05-03 at 09:08 +0200, Thomas Petazzoni wrote:
>>> On Mon, 02 May 2016 09:37:50 -0700, Geoff Levand wrote:
>>>
>>>> I have the patch below that adds BR2_TOOLCHAIN_HAS_THREADS. Is
>>>> it enough to pull in the toolchain?
>>>
>>> No, adding dependencies at the Config.in level doesn't change
>>> anything
>>> in terms of build order.
>>
>> It seems one of these in go-bootstrap.mk should work, is either
>> one prefered?
>>
>> +HOST_GO_BOOTSTRAP_DEPENDENCIES = host-go-bootstrap
>
> +HOST_GO_BOOTSTRAP_DEPENDENCIES = host-toolchain
>
>>
>> +HOST_GO_BOOTSTRAP_ADD_TOOLCHAIN_DEPENDENCY = YES
I don't see how either of these could work... AFAICS, host-toolchain doesn't
exist, and _ADD_TOOLCHAIN_DEPENDENCY is only checked for target packages.
What should work however:
HOST_GO_BOOTSTRAP_DEPENDENCIES = toolchain
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 25+ messages in thread
* [Buildroot] [PATCH v3 0/3] Add go language support
2016-04-30 12:03 ` Thomas Petazzoni
2016-05-01 3:43 ` Christian Stewart
@ 2016-05-02 16:21 ` Geoff Levand
1 sibling, 0 replies; 25+ messages in thread
From: Geoff Levand @ 2016-05-02 16:21 UTC (permalink / raw)
To: buildroot
On Sat, 2016-04-30 at 14:03 +0200, Thomas Petazzoni wrote:
> Hum, I'm looking at this repository, and I see only 3 branches, and
> none of them seem to contain things that look like fixes. Did I miss
> something?
Here's a browser link:
https://github.com/glevand/buildroot--buildroot/commits/master
You should see these:
b461b3a package/go: Add BR2_TOOLCHAIN_HAS_THREADS
149dbc4 package/go: Add not BR2_TOOLCHAIN_USES_UCLIBC
abb61c6 package/go: Fix powerpc64 config typo
044579e package/go: Upgrade 1.5.3 to 1.6.2
I don't think 'package/go: Add not BR2_TOOLCHAIN_USES_UCLIBC' is the
righ fix though. I think the problem is something else. I need to
look at that one some more.
-Geoff
^ permalink raw reply [flat|nested] 25+ messages in thread