Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] readline: fix installed libraries permission
Date: Tue, 14 Jun 2016 22:04:28 +0200	[thread overview]
Message-ID: <20160614200427.GE3759@free.fr> (raw)
In-Reply-To: <1465917079-30473-2-git-send-email-gilles.chanteperdrix@xenomai.org>

Gilles, All,

On 2016-06-14 17:11 +0200, Gilles Chanteperdrix spake thusly:
> In order to avoid strip failing to strip the library.

I just tried to build readline, and the two libraries that are installed
are already 755:

    -rwxr-xr-x 1 ymorin ymorin  33K Jun 14 21:59 target/usr/lib/libhistory.so.6.3*
    -rwxr-xr-x 1 ymorin ymorin 261K Jun 14 21:59 target/usr/lib/libreadline.so.6.3*

And after some inspection, we already fix that in our readline.mk:

    # libraries get installed read only, so strip fails
    define READLINE_INSTALL_FIXUPS_SHARED
        chmod +w $(addprefix $(TARGET_DIR)/usr/lib/,libhistory.so.* libreadline.so.*)
    endef
    READLINE_POST_INSTALL_TARGET_HOOKS += READLINE_INSTALL_FIXUPS_SHARED

Regards,
Yann E. MORIN.

> Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
> ---
>  package/readline/0009-avoid-strip-perm-issue.patch | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 package/readline/0009-avoid-strip-perm-issue.patch
> 
> diff --git a/package/readline/0009-avoid-strip-perm-issue.patch b/package/readline/0009-avoid-strip-perm-issue.patch
> new file mode 100644
> index 0000000..55d5166
> --- /dev/null
> +++ b/package/readline/0009-avoid-strip-perm-issue.patch
> @@ -0,0 +1,14 @@
> +Avoid libreadline to be installed read-only, as it makes stripping fail.
> +
> +Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
> +--- readline-6.3/support/shlib-install~	2012-07-10 21:58:08.000000000 +0200
> ++++ readline-6.3/support/shlib-install	2016-02-27 01:19:09.878310797 +0100
> +@@ -73,7 +73,7 @@ fi
> + case "$host_os" in
> + hpux*|darwin*|macosx*|linux*|solaris2*)
> + 	if [ -z "$uninstall" ]; then
> +-		chmod 555 ${INSTALLDIR}/${LIBNAME}
> ++		chmod 755 ${INSTALLDIR}/${LIBNAME}
> + 	fi ;;
> + cygwin*|mingw*)
> + 	IMPLIBNAME=`echo ${LIBNAME} \
> -- 
> 2.8.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-06-14 20:04 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 15:04 [Buildroot] Various patches Gilles Chanteperdrix
2016-06-14 15:05 ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 2/5] readline: fix installed libraries permission Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs Gilles Chanteperdrix
2016-06-14 20:14     ` Yann E. MORIN
2016-06-15 21:29       ` Gilles Chanteperdrix
2016-06-15 21:37         ` Yann E. MORIN
2016-06-16 19:36           ` Gilles Chanteperdrix
2016-06-16 19:41             ` Yann E. MORIN
2016-06-17  8:35               ` Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 4/5] grub2: really disable liblzma Gilles Chanteperdrix
2016-06-14 20:26     ` Yann E. MORIN
2016-06-14 15:05   ` [Buildroot] [PATCH 5/5] grub2: allow full install (for installer images) Gilles Chanteperdrix
2016-06-14 15:10 ` [Buildroot] Various patches Gilles Chanteperdrix
2016-06-14 15:11   ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Gilles Chanteperdrix
2016-06-14 15:11     ` [Buildroot] [PATCH 2/5] readline: fix installed libraries permission Gilles Chanteperdrix
2016-06-14 20:04       ` Yann E. MORIN [this message]
2016-06-14 20:21       ` Peter Korsgaard
2016-06-15 21:32         ` Gilles Chanteperdrix
2016-06-15 21:48           ` Peter Korsgaard
2016-06-16 19:43             ` Gilles Chanteperdrix
2016-06-14 15:11     ` [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs Gilles Chanteperdrix
2016-06-15 21:08       ` Thomas Petazzoni
2016-06-16 19:40         ` Gilles Chanteperdrix
2016-06-16 20:21           ` Thomas Petazzoni
2016-06-14 15:11     ` [Buildroot] [PATCH 4/5] grub2: really disable liblzma Gilles Chanteperdrix
2016-06-14 20:38       ` Yann E. MORIN
2016-06-15 21:00       ` Thomas Petazzoni
2016-06-14 15:11     ` [Buildroot] [PATCH 5/5] grub2: allow full install (for installer images) Gilles Chanteperdrix
2016-06-14 19:33     ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Yann E. MORIN
2016-06-14 19:37       ` Yann E. MORIN
2016-06-14 20:22       ` Peter Korsgaard
2016-06-14 20:25       ` Peter Korsgaard
2016-06-14 20:31         ` Peter Korsgaard
2016-06-14 19:42     ` Yann E. MORIN
2016-06-14 20:12     ` Peter Korsgaard
2016-06-15 21:30       ` Gilles Chanteperdrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614200427.GE3759@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox