Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] readline: fix installed libraries permission
Date: Tue, 14 Jun 2016 22:21:23 +0200	[thread overview]
Message-ID: <87oa73v7wc.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1465917079-30473-2-git-send-email-gilles.chanteperdrix@xenomai.org> (Gilles Chanteperdrix's message of "Tue, 14 Jun 2016 17:11:16 +0200")

>>>>> "Gilles" == Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> writes:

 > In order to avoid strip failing to strip the library.
 > Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>

Thanks, but we already have logic in readline.mk to fix this:

ifneq ($(BR2_STATIC_LIBS),y)
# libraries get installed read only, so strip fails
define READLINE_INSTALL_FIXUPS_SHARED
	chmod +w $(addprefix $(TARGET_DIR)/usr/lib/,libhistory.so.* libreadline.so.*)
endef
READLINE_POST_INSTALL_TARGET_HOOKS += READLINE_INSTALL_FIXUPS_SHARED
endif

So why this patch instead? It would be good if we could get rid of both,
have you tried sending it upstream?

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2016-06-14 20:21 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 15:04 [Buildroot] Various patches Gilles Chanteperdrix
2016-06-14 15:05 ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 2/5] readline: fix installed libraries permission Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs Gilles Chanteperdrix
2016-06-14 20:14     ` Yann E. MORIN
2016-06-15 21:29       ` Gilles Chanteperdrix
2016-06-15 21:37         ` Yann E. MORIN
2016-06-16 19:36           ` Gilles Chanteperdrix
2016-06-16 19:41             ` Yann E. MORIN
2016-06-17  8:35               ` Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 4/5] grub2: really disable liblzma Gilles Chanteperdrix
2016-06-14 20:26     ` Yann E. MORIN
2016-06-14 15:05   ` [Buildroot] [PATCH 5/5] grub2: allow full install (for installer images) Gilles Chanteperdrix
2016-06-14 15:10 ` [Buildroot] Various patches Gilles Chanteperdrix
2016-06-14 15:11   ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Gilles Chanteperdrix
2016-06-14 15:11     ` [Buildroot] [PATCH 2/5] readline: fix installed libraries permission Gilles Chanteperdrix
2016-06-14 20:04       ` Yann E. MORIN
2016-06-14 20:21       ` Peter Korsgaard [this message]
2016-06-15 21:32         ` Gilles Chanteperdrix
2016-06-15 21:48           ` Peter Korsgaard
2016-06-16 19:43             ` Gilles Chanteperdrix
2016-06-14 15:11     ` [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs Gilles Chanteperdrix
2016-06-15 21:08       ` Thomas Petazzoni
2016-06-16 19:40         ` Gilles Chanteperdrix
2016-06-16 20:21           ` Thomas Petazzoni
2016-06-14 15:11     ` [Buildroot] [PATCH 4/5] grub2: really disable liblzma Gilles Chanteperdrix
2016-06-14 20:38       ` Yann E. MORIN
2016-06-15 21:00       ` Thomas Petazzoni
2016-06-14 15:11     ` [Buildroot] [PATCH 5/5] grub2: allow full install (for installer images) Gilles Chanteperdrix
2016-06-14 19:33     ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Yann E. MORIN
2016-06-14 19:37       ` Yann E. MORIN
2016-06-14 20:22       ` Peter Korsgaard
2016-06-14 20:25       ` Peter Korsgaard
2016-06-14 20:31         ` Peter Korsgaard
2016-06-14 19:42     ` Yann E. MORIN
2016-06-14 20:12     ` Peter Korsgaard
2016-06-15 21:30       ` Gilles Chanteperdrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa73v7wc.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox