Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs
Date: Thu, 16 Jun 2016 21:40:24 +0200	[thread overview]
Message-ID: <20160616194024.GF32532@hermes.click-hack.org> (raw)
In-Reply-To: <20160615230808.4c1e063b@free-electrons.com>

On Wed, Jun 15, 2016 at 11:08:08PM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 14 Jun 2016 17:11:17 +0200, Gilles Chanteperdrix wrote:
> 
> > diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> > index a0f694d..5f7a155 100644
> > --- a/package/pkg-download.mk
> > +++ b/package/pkg-download.mk
> > @@ -225,7 +225,7 @@ define DOWNLOAD_INNER
> >  	fi ; \
> >  	if test -n "$(1)" ; then \
> >  		case "$($(PKG)_SITE_METHOD)" in \
> > -			git) $($(3)_GIT) && exit ;; \
> > +			git|ssh) $($(3)_GIT) && exit ;; \
> 
> There has already been a question from Yann on a previous iteration of
> this patch, which hasn't been answered:
> 
> """
> What about Hg URLs that can also start with 'ssh://' ?
> """
> 
> Indeed, I don't see why a ssh:// URL should necessarily reference a Git
> repository. And there's no explanation about this decision in the
> commit log.

See the discussion here:
http://lists.busybox.net/pipermail/buildroot/2016-May/160670.html

-- 
					    Gilles.
https://click-hack.org

  reply	other threads:[~2016-06-16 19:40 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 15:04 [Buildroot] Various patches Gilles Chanteperdrix
2016-06-14 15:05 ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 2/5] readline: fix installed libraries permission Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs Gilles Chanteperdrix
2016-06-14 20:14     ` Yann E. MORIN
2016-06-15 21:29       ` Gilles Chanteperdrix
2016-06-15 21:37         ` Yann E. MORIN
2016-06-16 19:36           ` Gilles Chanteperdrix
2016-06-16 19:41             ` Yann E. MORIN
2016-06-17  8:35               ` Gilles Chanteperdrix
2016-06-14 15:05   ` [Buildroot] [PATCH 4/5] grub2: really disable liblzma Gilles Chanteperdrix
2016-06-14 20:26     ` Yann E. MORIN
2016-06-14 15:05   ` [Buildroot] [PATCH 5/5] grub2: allow full install (for installer images) Gilles Chanteperdrix
2016-06-14 15:10 ` [Buildroot] Various patches Gilles Chanteperdrix
2016-06-14 15:11   ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Gilles Chanteperdrix
2016-06-14 15:11     ` [Buildroot] [PATCH 2/5] readline: fix installed libraries permission Gilles Chanteperdrix
2016-06-14 20:04       ` Yann E. MORIN
2016-06-14 20:21       ` Peter Korsgaard
2016-06-15 21:32         ` Gilles Chanteperdrix
2016-06-15 21:48           ` Peter Korsgaard
2016-06-16 19:43             ` Gilles Chanteperdrix
2016-06-14 15:11     ` [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs Gilles Chanteperdrix
2016-06-15 21:08       ` Thomas Petazzoni
2016-06-16 19:40         ` Gilles Chanteperdrix [this message]
2016-06-16 20:21           ` Thomas Petazzoni
2016-06-14 15:11     ` [Buildroot] [PATCH 4/5] grub2: really disable liblzma Gilles Chanteperdrix
2016-06-14 20:38       ` Yann E. MORIN
2016-06-15 21:00       ` Thomas Petazzoni
2016-06-14 15:11     ` [Buildroot] [PATCH 5/5] grub2: allow full install (for installer images) Gilles Chanteperdrix
2016-06-14 19:33     ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Yann E. MORIN
2016-06-14 19:37       ` Yann E. MORIN
2016-06-14 20:22       ` Peter Korsgaard
2016-06-14 20:25       ` Peter Korsgaard
2016-06-14 20:31         ` Peter Korsgaard
2016-06-14 19:42     ` Yann E. MORIN
2016-06-14 20:12     ` Peter Korsgaard
2016-06-15 21:30       ` Gilles Chanteperdrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160616194024.GF32532@hermes.click-hack.org \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox