From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs
Date: Wed, 15 Jun 2016 23:08:08 +0200 [thread overview]
Message-ID: <20160615230808.4c1e063b@free-electrons.com> (raw)
In-Reply-To: <1465917079-30473-3-git-send-email-gilles.chanteperdrix@xenomai.org>
Hello,
On Tue, 14 Jun 2016 17:11:17 +0200, Gilles Chanteperdrix wrote:
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index a0f694d..5f7a155 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -225,7 +225,7 @@ define DOWNLOAD_INNER
> fi ; \
> if test -n "$(1)" ; then \
> case "$($(PKG)_SITE_METHOD)" in \
> - git) $($(3)_GIT) && exit ;; \
> + git|ssh) $($(3)_GIT) && exit ;; \
There has already been a question from Yann on a previous iteration of
this patch, which hasn't been answered:
"""
What about Hg URLs that can also start with 'ssh://' ?
"""
Indeed, I don't see why a ssh:// URL should necessarily reference a Git
repository. And there's no explanation about this decision in the
commit log.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-15 21:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 15:04 [Buildroot] Various patches Gilles Chanteperdrix
2016-06-14 15:05 ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Gilles Chanteperdrix
2016-06-14 15:05 ` [Buildroot] [PATCH 2/5] readline: fix installed libraries permission Gilles Chanteperdrix
2016-06-14 15:05 ` [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs Gilles Chanteperdrix
2016-06-14 20:14 ` Yann E. MORIN
2016-06-15 21:29 ` Gilles Chanteperdrix
2016-06-15 21:37 ` Yann E. MORIN
2016-06-16 19:36 ` Gilles Chanteperdrix
2016-06-16 19:41 ` Yann E. MORIN
2016-06-17 8:35 ` Gilles Chanteperdrix
2016-06-14 15:05 ` [Buildroot] [PATCH 4/5] grub2: really disable liblzma Gilles Chanteperdrix
2016-06-14 20:26 ` Yann E. MORIN
2016-06-14 15:05 ` [Buildroot] [PATCH 5/5] grub2: allow full install (for installer images) Gilles Chanteperdrix
2016-06-14 15:10 ` [Buildroot] Various patches Gilles Chanteperdrix
2016-06-14 15:11 ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Gilles Chanteperdrix
2016-06-14 15:11 ` [Buildroot] [PATCH 2/5] readline: fix installed libraries permission Gilles Chanteperdrix
2016-06-14 20:04 ` Yann E. MORIN
2016-06-14 20:21 ` Peter Korsgaard
2016-06-15 21:32 ` Gilles Chanteperdrix
2016-06-15 21:48 ` Peter Korsgaard
2016-06-16 19:43 ` Gilles Chanteperdrix
2016-06-14 15:11 ` [Buildroot] [PATCH 3/5] pkg-download: allow ssh URLs Gilles Chanteperdrix
2016-06-15 21:08 ` Thomas Petazzoni [this message]
2016-06-16 19:40 ` Gilles Chanteperdrix
2016-06-16 20:21 ` Thomas Petazzoni
2016-06-14 15:11 ` [Buildroot] [PATCH 4/5] grub2: really disable liblzma Gilles Chanteperdrix
2016-06-14 20:38 ` Yann E. MORIN
2016-06-15 21:00 ` Thomas Petazzoni
2016-06-14 15:11 ` [Buildroot] [PATCH 5/5] grub2: allow full install (for installer images) Gilles Chanteperdrix
2016-06-14 19:33 ` [Buildroot] [PATCH 1/5] wireshark: remove documentation Yann E. MORIN
2016-06-14 19:37 ` Yann E. MORIN
2016-06-14 20:22 ` Peter Korsgaard
2016-06-14 20:25 ` Peter Korsgaard
2016-06-14 20:31 ` Peter Korsgaard
2016-06-14 19:42 ` Yann E. MORIN
2016-06-14 20:12 ` Peter Korsgaard
2016-06-15 21:30 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615230808.4c1e063b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox