Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package.
@ 2016-07-24  5:56 Dagg Stompler
  2016-07-24  5:56 ` [Buildroot] [PATCH 2/2 v4] odroid-mali: " Dagg Stompler
  2016-07-24 12:40 ` [Buildroot] [PATCH 1/2 v3] odroid-scripts: " Thomas Petazzoni
  0 siblings, 2 replies; 8+ messages in thread
From: Dagg Stompler @ 2016-07-24  5:56 UTC (permalink / raw)
  To: buildroot

v2 -> v3:
 - update repo rev to a252de04562dcf8d8a4918a544b45a9e3d46d2fb.
 - update hash

v1 -> v2:
 - fix hash type in hash file.

Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
 configs/odroidc2_defconfig                 |  1 +
 package/Config.in                          |  1 +
 package/odroid-scripts/Config.in           |  7 +++++++
 package/odroid-scripts/S50odroidc2_fb      | 20 +++++++++++++++++++
 package/odroid-scripts/odroid-scripts.hash |  2 ++
 package/odroid-scripts/odroid-scripts.mk   | 32 ++++++++++++++++++++++++++++++
 6 files changed, 63 insertions(+)
 create mode 100644 package/odroid-scripts/Config.in
 create mode 100644 package/odroid-scripts/S50odroidc2_fb
 create mode 100644 package/odroid-scripts/odroid-scripts.hash
 create mode 100644 package/odroid-scripts/odroid-scripts.mk

diff --git a/configs/odroidc2_defconfig b/configs/odroidc2_defconfig
index 43c2787..45ede62 100644
--- a/configs/odroidc2_defconfig
+++ b/configs/odroidc2_defconfig
@@ -6,6 +6,7 @@ BR2_TARGET_GENERIC_HOSTNAME="odroidc2"
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
+BR2_PACKAGE_ODROID_SCRIPTS=y
 
 # Kernel
 BR2_KERNEL_HEADERS_VERSION=y
diff --git a/package/Config.in b/package/Config.in
index 46ad276..a7858dc 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1688,6 +1688,7 @@ menu "System tools"
 	source "package/ncdu/Config.in"
 	source "package/numactl/Config.in"
 	source "package/nut/Config.in"
+	source "package/odroid-scripts/Config.in"
 	source "package/openvmtools/Config.in"
 	source "package/polkit/Config.in"
 	source "package/powerpc-utils/Config.in"
diff --git a/package/odroid-scripts/Config.in b/package/odroid-scripts/Config.in
new file mode 100644
index 0000000..48544b6
--- /dev/null
+++ b/package/odroid-scripts/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_ODROID_SCRIPTS
+	bool "odroid-scripts"
+	depends on BR2_aarch64 || BR2_arm
+	help
+	  Install the scripts for the odroidc2 based systems.
+
+	  https://github.com/mdrjr/c2_bootini
diff --git a/package/odroid-scripts/S50odroidc2_fb b/package/odroid-scripts/S50odroidc2_fb
new file mode 100644
index 0000000..2aae59d
--- /dev/null
+++ b/package/odroid-scripts/S50odroidc2_fb
@@ -0,0 +1,20 @@
+#!/bin/sh
+#
+# Set up frame buffer
+#
+
+case "$1" in
+    start)
+        echo "Setting up display..."
+        /usr/sbin/odroidc2_init_fb.sh
+        ;;
+    stop)
+        ;;
+    restart|reload)
+        ;;
+    *)
+        echo "Usage: $0 {start|stop|restart}"
+        exit 1
+esac
+
+exit $?
diff --git a/package/odroid-scripts/odroid-scripts.hash b/package/odroid-scripts/odroid-scripts.hash
new file mode 100644
index 0000000..8fd4b2c
--- /dev/null
+++ b/package/odroid-scripts/odroid-scripts.hash
@@ -0,0 +1,2 @@
+#  Locally computed hash
+sha256 779e8beccf8c66d51e495a4cc0e6eccf72c295499a1ecdc0740aa4459de786a0 odroid-scripts-a252de04562dcf8d8a4918a544b45a9e3d46d2fb.tar.gz
diff --git a/package/odroid-scripts/odroid-scripts.mk b/package/odroid-scripts/odroid-scripts.mk
new file mode 100644
index 0000000..445f2d8
--- /dev/null
+++ b/package/odroid-scripts/odroid-scripts.mk
@@ -0,0 +1,32 @@
+################################################################################
+#
+# odroid-scripts
+#
+################################################################################
+
+ODROID_SCRIPTS_VERSION = a252de04562dcf8d8a4918a544b45a9e3d46d2fb
+ODROID_SCRIPTS_SITE = $(call github,mdrjr,c2_bootini,$(ODROID_SCRIPTS_VERSION))
+ODROID_SCRIPTS_LICENSE = unclear
+
+ifeq ($(BR2_PACKAGE_EUDEV),y)
+	ODROID_SCRIPTS_INSTALL_UDEV_RULES = $(INSTALL) -D -m 0644 $(@D)/10-odroid.rules $(TARGET_DIR)/etc/udev/rules.d/10-odroid.rules
+else
+	ODROID_SCRIPTS_INSTALL_UDEV_RULES =
+endif
+
+define ODROID_SCRIPTS_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/c2_init.sh $(TARGET_DIR)/usr/sbin/odroidc2_init_fb.sh
+	$(ODROID_SCRIPTS_INSTALL_UDEV_RULES)
+endef
+
+define ODROID_SCRIPTS_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 0644 $(@D)/amlogic.service $(TARGET_DIR)/usr/lib/systemd/system/odroidc2_fb.service
+	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+	ln -fs ../../../../usr/lib/systemd/system/odroidc2_fb.service $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/odroidc2_fb.service
+endef
+
+define ODROID_SCRIPTS_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/odroid-scripts/S50odroidc2_fb $(TARGET_DIR)/etc/init.d/S50odroidc2_fb
+endef
+
+$(eval $(generic-package))
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/2 v4] odroid-mali: New Package.
  2016-07-24  5:56 [Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package Dagg Stompler
@ 2016-07-24  5:56 ` Dagg Stompler
  2016-07-24 12:44   ` Thomas Petazzoni
  2016-07-24 12:40 ` [Buildroot] [PATCH 1/2 v3] odroid-scripts: " Thomas Petazzoni
  1 sibling, 1 reply; 8+ messages in thread
From: Dagg Stompler @ 2016-07-24  5:56 UTC (permalink / raw)
  To: buildroot

v3 -> v4:
 - update repo rev to 46fe49f37e3506c6205ad8c50980eca9bfff11e3.
 - update hash
 - 32 and 64 bit flavors can now use the same repo rev.

v2 -> v3:
 - fix pkgconfig installation.

v1 -> v2:
 - added hash for 32 bits revision.
 - fix file permissions for S50odroidc2_fb and odroidc2_init_fb.sh

Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
 package/Config.in                    |  1 +
 package/odroid-mali/Config.in        | 21 +++++++++++++++++++++
 package/odroid-mali/odroid-mali.hash |  2 ++
 package/odroid-mali/odroid-mali.mk   | 36 ++++++++++++++++++++++++++++++++++++
 4 files changed, 60 insertions(+)
 create mode 100644 package/odroid-mali/Config.in
 create mode 100644 package/odroid-mali/odroid-mali.hash
 create mode 100644 package/odroid-mali/odroid-mali.mk

diff --git a/package/Config.in b/package/Config.in
index a7858dc..f7e7592 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -414,6 +414,7 @@ endmenu
 	source "package/nvidia-driver/Config.in"
 	source "package/nvidia-tegra23/Config.in"
 	source "package/nvme/Config.in"
+	source "package/odroid-mali/Config.in"
 	source "package/ofono/Config.in"
 	source "package/ola/Config.in"
 	source "package/on2-8170-modules/Config.in"
diff --git a/package/odroid-mali/Config.in b/package/odroid-mali/Config.in
new file mode 100644
index 0000000..02c6ca0
--- /dev/null
+++ b/package/odroid-mali/Config.in
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_ODROID_MALI
+	bool "odroid-mali"
+	select BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_HAS_LIBGLES
+	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+	select BR2_PACKAGE_FBSET
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_aarch64 || BR2_arm
+	depends on BR2_PACKAGE_ODROID_SCRIPTS
+	help
+	  Install the ARM Mali drivers for odroidc2 based systems.
+
+	  https://github.com/mdrjr/c2_mali
+
+if BR2_PACKAGE_ODROID_MALI
+config BR2_PACKAGE_PROVIDES_LIBEGL
+	default "odroid-mali"
+
+config BR2_PACKAGE_PROVIDES_LIBGLES
+	default "odroid-mali"
+endif
diff --git a/package/odroid-mali/odroid-mali.hash b/package/odroid-mali/odroid-mali.hash
new file mode 100644
index 0000000..4d24824
--- /dev/null
+++ b/package/odroid-mali/odroid-mali.hash
@@ -0,0 +1,2 @@
+# Locally computed hash
+sha256 29d98ed4b8694b860d9289787c416faa847b0de26d36580a53add1752b4c2e9a  odroid-mali-46fe49f37e3506c6205ad8c50980eca9bfff11e3.tar.gz
diff --git a/package/odroid-mali/odroid-mali.mk b/package/odroid-mali/odroid-mali.mk
new file mode 100644
index 0000000..17a7de2
--- /dev/null
+++ b/package/odroid-mali/odroid-mali.mk
@@ -0,0 +1,36 @@
+################################################################################
+#
+# odroid-mali
+#
+################################################################################
+
+ODROID_MALI_VERSION = 46fe49f37e3506c6205ad8c50980eca9bfff11e3
+ODROID_MALI_SITE = $(call github,mdrjr,c2_mali,$(ODROID_MALI_VERSION))
+ODROID_MALI_LICENSE = hardkernel
+ODROID_MALI_LICENSE_FILES = README.md
+
+ODROID_MALI_INSTALL_STAGING = YES
+ODROID_MALI_PROVIDES = libegl libgles
+
+ifeq ($(BR2_aarch64),y)
+ODROID_MALI_LIBS_INSTALL_ARCH=mali_libs
+else
+ODROID_MALI_LIBS_INSTALL_ARCH=32bit_libs
+endif
+
+define ODROID_MALI_INSTALL_LIBS
+	cp -aRP $(@D)/fbdev/$(ODROID_MALI_LIBS_INSTALL_ARCH)/lib* $(1)/lib/
+endef
+
+define ODROID_MALI_INSTALL_STAGING_CMDS
+	$(call ODROID_MALI_INSTALL_LIBS,$(STAGING_DIR)/usr)
+	$(INSTALL) -d $(STAGING_DIR)/usr/lib/pkgconfig
+	$(INSTALL) -m 644 $(@D)/pkgconfig/*.pc $(STAGING_DIR)/usr/lib/pkgconfig/
+	cp -aRP $(@D)/fbdev/mali_headers/* $(STAGING_DIR)/usr/include
+endef
+
+define ODROID_MALI_INSTALL_TARGET_CMDS
+	$(call ODROID_MALI_INSTALL_LIBS,$(TARGET_DIR)/usr)
+endef
+
+$(eval $(generic-package))
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package.
  2016-07-24  5:56 [Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package Dagg Stompler
  2016-07-24  5:56 ` [Buildroot] [PATCH 2/2 v4] odroid-mali: " Dagg Stompler
@ 2016-07-24 12:40 ` Thomas Petazzoni
  2016-07-24 13:26   ` daggs
  1 sibling, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2016-07-24 12:40 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 24 Jul 2016 08:56:01 +0300, Dagg Stompler wrote:
> v2 -> v3:
>  - update repo rev to a252de04562dcf8d8a4918a544b45a9e3d46d2fb.
>  - update hash
> 
> v1 -> v2:
>  - fix hash type in hash file.

The changelog should not be part of the commit log.

> 
> Signed-off-by: Dagg Stompler <daggs@gmx.com>
> ---

It should be here.

>  configs/odroidc2_defconfig                 |  1 +
>  package/Config.in                          |  1 +
>  package/odroid-scripts/Config.in           |  7 +++++++
>  package/odroid-scripts/S50odroidc2_fb      | 20 +++++++++++++++++++
>  package/odroid-scripts/odroid-scripts.hash |  2 ++
>  package/odroid-scripts/odroid-scripts.mk   | 32 ++++++++++++++++++++++++++++++
>  6 files changed, 63 insertions(+)
>  create mode 100644 package/odroid-scripts/Config.in
>  create mode 100644 package/odroid-scripts/S50odroidc2_fb
>  create mode 100644 package/odroid-scripts/odroid-scripts.hash
>  create mode 100644 package/odroid-scripts/odroid-scripts.mk
> 
> diff --git a/configs/odroidc2_defconfig b/configs/odroidc2_defconfig
> index 43c2787..45ede62 100644
> --- a/configs/odroidc2_defconfig
> +++ b/configs/odroidc2_defconfig
> @@ -6,6 +6,7 @@ BR2_TARGET_GENERIC_HOSTNAME="odroidc2"
>  BR2_TARGET_ROOTFS_EXT2=y
>  BR2_TARGET_ROOTFS_EXT2_4=y
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
> +BR2_PACKAGE_ODROID_SCRIPTS=y

This should be part of a separate commit.


> +ODROID_SCRIPTS_VERSION = a252de04562dcf8d8a4918a544b45a9e3d46d2fb
> +ODROID_SCRIPTS_SITE = $(call github,mdrjr,c2_bootini,$(ODROID_SCRIPTS_VERSION))

This repository contains the boot.ini for which you add a copy in
Buildroot (see our discussion from yesterday). Why don't we use this
one? It seems to be pretty much the same.

> +ODROID_SCRIPTS_LICENSE = unclear
> +
> +ifeq ($(BR2_PACKAGE_EUDEV),y)

BR2_PACKAGE_HAS_UDEV

so that it also works with systemd

> +	ODROID_SCRIPTS_INSTALL_UDEV_RULES = $(INSTALL) -D -m 0644 $(@D)/10-odroid.rules $(TARGET_DIR)/etc/udev/rules.d/10-odroid.rules

Please use:

define ODROID_SCRIPTS_INSTALL_UDEV_RULES
	$(INSTALL) -D -m 0644 $(@D)/10-odroid.rules $(TARGET_DIR)/etc/udev/rules.d/10-odroid.rules
endef

> +else
> +	ODROID_SCRIPTS_INSTALL_UDEV_RULES =

Not needed, by default variables are empty.

> +endif
> +
> +define ODROID_SCRIPTS_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/c2_init.sh $(TARGET_DIR)/usr/sbin/odroidc2_init_fb.sh
> +	$(ODROID_SCRIPTS_INSTALL_UDEV_RULES)
> +endef
> +
> +define ODROID_SCRIPTS_INSTALL_INIT_SYSTEMD
> +	$(INSTALL) -D -m 0644 $(@D)/amlogic.service $(TARGET_DIR)/usr/lib/systemd/system/odroidc2_fb.service
> +	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> +	ln -fs ../../../../usr/lib/systemd/system/odroidc2_fb.service $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/odroidc2_fb.service
> +endef
> +
> +define ODROID_SCRIPTS_INSTALL_INIT_SYSV
> +	$(INSTALL) -D -m 0755 package/odroid-scripts/S50odroidc2_fb $(TARGET_DIR)/etc/init.d/S50odroidc2_fb
> +endef

Other than that, looks good. Can you respin a new version?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/2 v4] odroid-mali: New Package.
  2016-07-24  5:56 ` [Buildroot] [PATCH 2/2 v4] odroid-mali: " Dagg Stompler
@ 2016-07-24 12:44   ` Thomas Petazzoni
  2016-07-24 13:29     ` daggs
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2016-07-24 12:44 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 24 Jul 2016 08:56:02 +0300, Dagg Stompler wrote:
> v3 -> v4:
>  - update repo rev to 46fe49f37e3506c6205ad8c50980eca9bfff11e3.
>  - update hash
>  - 32 and 64 bit flavors can now use the same repo rev.
> 
> v2 -> v3:
>  - fix pkgconfig installation.
> 
> v1 -> v2:
>  - added hash for 32 bits revision.
>  - fix file permissions for S50odroidc2_fb and odroidc2_init_fb.sh

The changelog should not be part of the commit log. It should go...

> 
> Signed-off-by: Dagg Stompler <daggs@gmx.com>
> ---

... here.

>  package/Config.in                    |  1 +
>  package/odroid-mali/Config.in        | 21 +++++++++++++++++++++
>  package/odroid-mali/odroid-mali.hash |  2 ++
>  package/odroid-mali/odroid-mali.mk   | 36 ++++++++++++++++++++++++++++++++++++
>  4 files changed, 60 insertions(+)
>  create mode 100644 package/odroid-mali/Config.in
>  create mode 100644 package/odroid-mali/odroid-mali.hash
>  create mode 100644 package/odroid-mali/odroid-mali.mk

> +	depends on BR2_PACKAGE_ODROID_SCRIPTS

Why do you have this dependency?

> +################################################################################
> +#
> +# odroid-mali
> +#
> +################################################################################
> +
> +ODROID_MALI_VERSION = 46fe49f37e3506c6205ad8c50980eca9bfff11e3
> +ODROID_MALI_SITE = $(call github,mdrjr,c2_mali,$(ODROID_MALI_VERSION))
> +ODROID_MALI_LICENSE = hardkernel

I think:

	Hardkernel EULA

would be better here.

> +ODROID_MALI_LICENSE_FILES = README.md
> +
> +ODROID_MALI_INSTALL_STAGING = YES
> +ODROID_MALI_PROVIDES = libegl libgles
> +
> +ifeq ($(BR2_aarch64),y)
> +ODROID_MALI_LIBS_INSTALL_ARCH=mali_libs
> +else
> +ODROID_MALI_LIBS_INSTALL_ARCH=32bit_libs
> +endif
> +
> +define ODROID_MALI_INSTALL_LIBS
> +	cp -aRP $(@D)/fbdev/$(ODROID_MALI_LIBS_INSTALL_ARCH)/lib* $(1)/lib/

Make it:

	cp -aRP $(@D)/fbdev/$(ODROID_MALI_LIBS_INSTALL_ARCH)/lib* $(1)/usr/lib/

This way you just have to pass TARGET_DIR or STAGING_DIR, and not
TARGET_DIR/usr and STAGING_DIR/usr.

Also, in Buildroot, we by convention use:

	cp -dpfr


> +endef
> +
> +define ODROID_MALI_INSTALL_STAGING_CMDS
> +	$(call ODROID_MALI_INSTALL_LIBS,$(STAGING_DIR)/usr)
> +	$(INSTALL) -d $(STAGING_DIR)/usr/lib/pkgconfig
> +	$(INSTALL) -m 644 $(@D)/pkgconfig/*.pc $(STAGING_DIR)/usr/lib/pkgconfig/

Use cp

> +	cp -aRP $(@D)/fbdev/mali_headers/* $(STAGING_DIR)/usr/include

cp -dpfr

> +endef
> +
> +define ODROID_MALI_INSTALL_TARGET_CMDS
> +	$(call ODROID_MALI_INSTALL_LIBS,$(TARGET_DIR)/usr)
> +endef
> +
> +$(eval $(generic-package))

Other than that, looks good.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package.
  2016-07-24 12:40 ` [Buildroot] [PATCH 1/2 v3] odroid-scripts: " Thomas Petazzoni
@ 2016-07-24 13:26   ` daggs
  2016-07-24 13:33     ` Thomas Petazzoni
  0 siblings, 1 reply; 8+ messages in thread
From: daggs @ 2016-07-24 13:26 UTC (permalink / raw)
  To: buildroot

Greetings,

> Hello,
> 
> On Sun, 24 Jul 2016 08:56:01 +0300, Dagg Stompler wrote:
> > v2 -> v3:
> >  - update repo rev to a252de04562dcf8d8a4918a544b45a9e3d46d2fb.
> >  - update hash
> > 
> > v1 -> v2:
> >  - fix hash type in hash file.
> 
> The changelog should not be part of the commit log.
> 
> > 
> > Signed-off-by: Dagg Stompler <daggs@gmx.com>
> > ---
> 
> It should be here.

I always seems to forget were to place it.... :-/

> 
> >  configs/odroidc2_defconfig                 |  1 +
> >  package/Config.in                          |  1 +
> >  package/odroid-scripts/Config.in           |  7 +++++++
> >  package/odroid-scripts/S50odroidc2_fb      | 20 +++++++++++++++++++
> >  package/odroid-scripts/odroid-scripts.hash |  2 ++
> >  package/odroid-scripts/odroid-scripts.mk   | 32 ++++++++++++++++++++++++++++++
> >  6 files changed, 63 insertions(+)
> >  create mode 100644 package/odroid-scripts/Config.in
> >  create mode 100644 package/odroid-scripts/S50odroidc2_fb
> >  create mode 100644 package/odroid-scripts/odroid-scripts.hash
> >  create mode 100644 package/odroid-scripts/odroid-scripts.mk
> > 
> > diff --git a/configs/odroidc2_defconfig b/configs/odroidc2_defconfig
> > index 43c2787..45ede62 100644
> > --- a/configs/odroidc2_defconfig
> > +++ b/configs/odroidc2_defconfig
> > @@ -6,6 +6,7 @@ BR2_TARGET_GENERIC_HOSTNAME="odroidc2"
> >  BR2_TARGET_ROOTFS_EXT2=y
> >  BR2_TARGET_ROOTFS_EXT2_4=y
> >  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
> > +BR2_PACKAGE_ODROID_SCRIPTS=y
> 
> This should be part of a separate commit.

will do.

> 
> 
> > +ODROID_SCRIPTS_VERSION = a252de04562dcf8d8a4918a544b45a9e3d46d2fb
> > +ODROID_SCRIPTS_SITE = $(call github,mdrjr,c2_bootini,$(ODROID_SCRIPTS_VERSION))
> 
> This repository contains the boot.ini for which you add a copy in
> Buildroot (see our discussion from yesterday). Why don't we use this
> one? It seems to be pretty much the same.

nope it isn't, as said in the other mail, there are two parts that will cause the image to fail booting or misbehave:
1. consider the following diff:
+# Booting

-# Load Images
 setenv loadaddr "0x11000000"
-setenv dtb_loadaddr "0x10000000"
+setenv dtb_loadaddr "0x1000000"
+setenv initrd_loadaddr "0x13000000"
+
+fatload mmc 0:1 ${initrd_loadaddr} uInitrd
 fatload mmc 0:1 ${loadaddr} Image
 fatload mmc 0:1 ${dtb_loadaddr} meson64_odroidc2.dtb
+fdt addr ${dtb_loadaddr}

-# Booting
-booti ${loadaddr} - ${dtb_loadaddr}
+ ...
+
+booti ${loadaddr} ${initrd_loadaddr} ${dtb_loadaddr}

this will force buildroot to provide an initrd image, when asked, I was told to fetch the ubuntu's one.
if no initrd is provided, the system will fail boot.
also taking ubuntu's initrd means hijacking it.

2. consider the following diff:
 # Default Console Device Setting
-setenv condev "console=ttyS0,115200n8" # Serial Console
+setenv condev "console=ttyS0,115200n8 console=tty0"   # on both

this resulted im my serial usb stop working, e.g. I didn't know where I was in the boot nor couldn't log in into the system.

without both of the changes, the system boots ok.

> 
> > +ODROID_SCRIPTS_LICENSE = unclear
> > +
> > +ifeq ($(BR2_PACKAGE_EUDEV),y)
> 
> BR2_PACKAGE_HAS_UDEV
> 
> so that it also works with systemd

will do.

> 
> > +	ODROID_SCRIPTS_INSTALL_UDEV_RULES = $(INSTALL) -D -m 0644 $(@D)/10-odroid.rules $(TARGET_DIR)/etc/udev/rules.d/10-odroid.rules
> 
> Please use:
> 
> define ODROID_SCRIPTS_INSTALL_UDEV_RULES
> 	$(INSTALL) -D -m 0644 $(@D)/10-odroid.rules $(TARGET_DIR)/etc/udev/rules.d/10-odroid.rules
> endef
> 

same as above.

> > +else
> > +	ODROID_SCRIPTS_INSTALL_UDEV_RULES =
> 
> Not needed, by default variables are empty.

will remove.

> 
> > +endif
> > +
> > +define ODROID_SCRIPTS_INSTALL_TARGET_CMDS
> > +	$(INSTALL) -D -m 0755 $(@D)/c2_init.sh $(TARGET_DIR)/usr/sbin/odroidc2_init_fb.sh
> > +	$(ODROID_SCRIPTS_INSTALL_UDEV_RULES)
> > +endef
> > +
> > +define ODROID_SCRIPTS_INSTALL_INIT_SYSTEMD
> > +	$(INSTALL) -D -m 0644 $(@D)/amlogic.service $(TARGET_DIR)/usr/lib/systemd/system/odroidc2_fb.service
> > +	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> > +	ln -fs ../../../../usr/lib/systemd/system/odroidc2_fb.service $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/odroidc2_fb.service
> > +endef
> > +
> > +define ODROID_SCRIPTS_INSTALL_INIT_SYSV
> > +	$(INSTALL) -D -m 0755 package/odroid-scripts/S50odroidc2_fb $(TARGET_DIR)/etc/init.d/S50odroidc2_fb
> > +endef
> 
> Other than that, looks good. Can you respin a new version?

maybe later today.

thanks for the rejects.

> 
> Thanks!
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/2 v4] odroid-mali: New Package.
  2016-07-24 12:44   ` Thomas Petazzoni
@ 2016-07-24 13:29     ` daggs
  2016-07-24 13:34       ` Thomas Petazzoni
  0 siblings, 1 reply; 8+ messages in thread
From: daggs @ 2016-07-24 13:29 UTC (permalink / raw)
  To: buildroot

Greetings,
>
> Hello,
> 
> On Sun, 24 Jul 2016 08:56:02 +0300, Dagg Stompler wrote:
> > v3 -> v4:
> >  - update repo rev to 46fe49f37e3506c6205ad8c50980eca9bfff11e3.
> >  - update hash
> >  - 32 and 64 bit flavors can now use the same repo rev.
> > 
> > v2 -> v3:
> >  - fix pkgconfig installation.
> > 
> > v1 -> v2:
> >  - added hash for 32 bits revision.
> >  - fix file permissions for S50odroidc2_fb and odroidc2_init_fb.sh
> 
> The changelog should not be part of the commit log. It should go...
> 
> > 
> > Signed-off-by: Dagg Stompler <daggs@gmx.com>
> > ---
> 
> ... here.

I'll never learn :-/ will do.

> 
> >  package/Config.in                    |  1 +
> >  package/odroid-mali/Config.in        | 21 +++++++++++++++++++++
> >  package/odroid-mali/odroid-mali.hash |  2 ++
> >  package/odroid-mali/odroid-mali.mk   | 36 ++++++++++++++++++++++++++++++++++++
> >  4 files changed, 60 insertions(+)
> >  create mode 100644 package/odroid-mali/Config.in
> >  create mode 100644 package/odroid-mali/odroid-mali.hash
> >  create mode 100644 package/odroid-mali/odroid-mali.mk
> 
> > +	depends on BR2_PACKAGE_ODROID_SCRIPTS
> 
> Why do you have this dependency?

because afaiu, this will not work if the scripts form odroid-scripts got executed.

> 
> > +################################################################################
> > +#
> > +# odroid-mali
> > +#
> > +################################################################################
> > +
> > +ODROID_MALI_VERSION = 46fe49f37e3506c6205ad8c50980eca9bfff11e3
> > +ODROID_MALI_SITE = $(call github,mdrjr,c2_mali,$(ODROID_MALI_VERSION))
> > +ODROID_MALI_LICENSE = hardkernel
> 
> I think:
> 
> 	Hardkernel EULA
> 
> would be better here.

will update.

> 
> > +ODROID_MALI_LICENSE_FILES = README.md
> > +
> > +ODROID_MALI_INSTALL_STAGING = YES
> > +ODROID_MALI_PROVIDES = libegl libgles
> > +
> > +ifeq ($(BR2_aarch64),y)
> > +ODROID_MALI_LIBS_INSTALL_ARCH=mali_libs
> > +else
> > +ODROID_MALI_LIBS_INSTALL_ARCH=32bit_libs
> > +endif
> > +
> > +define ODROID_MALI_INSTALL_LIBS
> > +	cp -aRP $(@D)/fbdev/$(ODROID_MALI_LIBS_INSTALL_ARCH)/lib* $(1)/lib/
> 
> Make it:
> 
> 	cp -aRP $(@D)/fbdev/$(ODROID_MALI_LIBS_INSTALL_ARCH)/lib* $(1)/usr/lib/
> 
> This way you just have to pass TARGET_DIR or STAGING_DIR, and not
> TARGET_DIR/usr and STAGING_DIR/usr.
> 
> Also, in Buildroot, we by convention use:
> 
> 	cp -dpfr
> 

understood.

> 
> > +endef
> > +
> > +define ODROID_MALI_INSTALL_STAGING_CMDS
> > +	$(call ODROID_MALI_INSTALL_LIBS,$(STAGING_DIR)/usr)
> > +	$(INSTALL) -d $(STAGING_DIR)/usr/lib/pkgconfig
> > +	$(INSTALL) -m 644 $(@D)/pkgconfig/*.pc $(STAGING_DIR)/usr/lib/pkgconfig/
> 
> Use cp
> 
> > +	cp -aRP $(@D)/fbdev/mali_headers/* $(STAGING_DIR)/usr/include
> 
> cp -dpfr

will do.

> 
> > +endef
> > +
> > +define ODROID_MALI_INSTALL_TARGET_CMDS
> > +	$(call ODROID_MALI_INSTALL_LIBS,$(TARGET_DIR)/usr)
> > +endef
> > +
> > +$(eval $(generic-package))
> 
> Other than that, looks good.
> 
> Thomas

thanks for the rejects.

> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package.
  2016-07-24 13:26   ` daggs
@ 2016-07-24 13:33     ` Thomas Petazzoni
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2016-07-24 13:33 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 24 Jul 2016 15:26:24 +0200, daggs wrote:

> > The changelog should not be part of the commit log.
> >   
> > > 
> > > Signed-off-by: Dagg Stompler <daggs@gmx.com>
> > > ---  
> > 
> > It should be here.  
> 
> I always seems to forget were to place it.... :-/

It's pretty simple:

"""
foo: new package

Blabla what this new package is all about. Blabla.

Signed-off-by: John Doe
---
Changes since v2:
 ...
"""

Everything that is *above* the "---" sign gets kept in the Git history
as the commit log. Everything that is *below" the "---" sign is ignored
when the patch is applied.

Since the changelog is describing what was changed between iterations
of the patch, we don't want the changelog to be committed forever in
the Git history, so it should be below the "---" sign.

When doing a commit, you can simply introduce a "---" manually below
your Signed-off-by and write your changelog here.


> this resulted im my serial usb stop working, e.g. I didn't know where I was in the boot nor couldn't log in into the system.
> 
> without both of the changes, the system boots ok.

OK, makes sense. Thanks for explaining.

> > Other than that, looks good. Can you respin a new version?  
> 
> maybe later today.

Sure, or another day, there's no hurry.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/2 v4] odroid-mali: New Package.
  2016-07-24 13:29     ` daggs
@ 2016-07-24 13:34       ` Thomas Petazzoni
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2016-07-24 13:34 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 24 Jul 2016 15:29:31 +0200, daggs wrote:

> > >  package/Config.in                    |  1 +
> > >  package/odroid-mali/Config.in        | 21 +++++++++++++++++++++
> > >  package/odroid-mali/odroid-mali.hash |  2 ++
> > >  package/odroid-mali/odroid-mali.mk   | 36 ++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 60 insertions(+)
> > >  create mode 100644 package/odroid-mali/Config.in
> > >  create mode 100644 package/odroid-mali/odroid-mali.hash
> > >  create mode 100644 package/odroid-mali/odroid-mali.mk  
> >   
> > > +	depends on BR2_PACKAGE_ODROID_SCRIPTS  
> > 
> > Why do you have this dependency?  
> 
> because afaiu, this will not work if the scripts form odroid-scripts got executed.

I guess you meant "if the scripts from odroid-scripts were *not*
executed", right ?

If that's the case, then I believe a "select
BR2_PACKAGE_ODROID_SCRIPTS" is probably better.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-07-24 13:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-24  5:56 [Buildroot] [PATCH 1/2 v3] odroid-scripts: New Package Dagg Stompler
2016-07-24  5:56 ` [Buildroot] [PATCH 2/2 v4] odroid-mali: " Dagg Stompler
2016-07-24 12:44   ` Thomas Petazzoni
2016-07-24 13:29     ` daggs
2016-07-24 13:34       ` Thomas Petazzoni
2016-07-24 12:40 ` [Buildroot] [PATCH 1/2 v3] odroid-scripts: " Thomas Petazzoni
2016-07-24 13:26   ` daggs
2016-07-24 13:33     ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox