Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/3] ltp-testsuite: change install prefix
@ 2016-10-01 11:50 Erico Nunes
  2016-10-01 11:50 ` [Buildroot] [PATCH 2/3] ltp-testsuite: bump to version 20160920 Erico Nunes
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Erico Nunes @ 2016-10-01 11:50 UTC (permalink / raw)
  To: buildroot

ltp-testsuite installs some of its files directly at its specified
prefix, which by default in Buildroot is /usr for autotools packages.
This is currently leaving scripts and its internal directories directly
installed in /usr, such as in:

  # ls /usr
  IDcheck.sh       lib64            runltplite.sh    share
  Version          libexec          runtest          testcases
  bin              runalltests.sh   sbin             testscripts
  lib              runltp           scenario_groups  ver_linux

It also seems to be not feasible to try to install all of its testcases
to standard locations such as /usr/bin as may contain hundreds of
binaries and may not be able to find them all if we change their install
locations. Therefore, it is better if ltp-testsuite installs its tree to
its own self-contained subdirectory.
Upstream instructions recommend that the install path be /opt/ltp,
however it seems that installing things to /opt is not a very common
Buildroot practice.
The proposal then is to install it to /usr/lib/ltp-testsuite and so it
can be run directly from there.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
The /usr/lib/ltp-testsuite suggestion came from a brief discussion that
I had on IRC about where would be the least bad place to install it.
Alternatives could be /usr/share/ltp-testsuite or even /opt/ltp if we
were to strictly follow the upstream documentation.
It doesn't matter too much really as long as it doesn't mess /usr up
anymore.
---
 package/ltp-testsuite/ltp-testsuite.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
index cf48072..e97659e 100644
--- a/package/ltp-testsuite/ltp-testsuite.mk
+++ b/package/ltp-testsuite/ltp-testsuite.mk
@@ -21,6 +21,10 @@ else
 LTP_TESTSUITE_CONF_OPTS += --without-modules
 endif
 
+# We change the prefix to a custom one, otherwise we get scripts and
+# directories directly in /usr, such as /usr/runalltests.sh
+LTP_TESTSUITE_CONF_OPTS += --prefix=/usr/lib/ltp-testsuite
+
 # Needs libcap with file attrs which needs attr, so both required
 ifeq ($(BR2_PACKAGE_LIBCAP)$(BR2_PACKAGE_ATTR),yy)
 LTP_TESTSUITE_DEPENDENCIES += libcap
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-10-08  4:14 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-01 11:50 [Buildroot] [PATCH 1/3] ltp-testsuite: change install prefix Erico Nunes
2016-10-01 11:50 ` [Buildroot] [PATCH 2/3] ltp-testsuite: bump to version 20160920 Erico Nunes
2016-10-03 21:37   ` Thomas Petazzoni
2016-10-08  4:14   ` Waldemar Brodkorb
2016-10-01 11:50 ` [Buildroot] [PATCH 3/3] ltp-testsuite: make Config.in libc comment standard Erico Nunes
2016-10-03 21:37   ` Thomas Petazzoni
2016-10-03 21:27 ` [Buildroot] [PATCH 1/3] ltp-testsuite: change install prefix Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox