[Buildroot] [PATCH] package/alsamixergui: add license information

[Buildroot] [PATCH] package/alsamixergui: add license information

[Wolfgang Grandegger]

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
 package/alsamixergui/alsamixergui.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/alsamixergui/alsamixergui.mk b/package/alsamixergui/alsamixergui.mk
index dba3ddd..8a1bcfe 100644
--- a/package/alsamixergui/alsamixergui.mk
+++ b/package/alsamixergui/alsamixergui.mk
@@ -7,6 +7,8 @@
 ALSAMIXERGUI_VERSION = 0.9.0rc2-1
 ALSAMIXERGUI_SOURCE = alsamixergui_$(ALSAMIXERGUI_VERSION).orig.tar.gz
 ALSAMIXERGUI_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/alsamixergui
+ALSAMIXERGUI_LICENSE = GPLv3+
+ALSAMIXERGUI_LICENSE_FILES = COPYING
 ALSAMIXERGUI_AUTORECONF = YES
 
 ALSAMIXERGUI_CONF_ENV = \
-- 
1.9.1

[Buildroot] [PATCH] package/alsamixergui: add license information

[Thomas Petazzoni]

Hello,

On Thu, 2 Mar 2017 17:06:10 +0100, Wolfgang Grandegger wrote:

>  ALSAMIXERGUI_VERSION = 0.9.0rc2-1
>  ALSAMIXERGUI_SOURCE = alsamixergui_$(ALSAMIXERGUI_VERSION).orig.tar.gz
>  ALSAMIXERGUI_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/alsamixergui
> +ALSAMIXERGUI_LICENSE = GPLv3+

Where did you get this GPLv3+ information? I'm seeing GPLv2+, not
GPLv3+.

> +ALSAMIXERGUI_LICENSE_FILES = COPYING

There is no COPYING file in the alsamixergui source code, so I don't
see how this can work. Did you test "make legal-info" after adding this?

Since there is no COPYING file, I would suggest to use debian/copyright
as a license file.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] package/alsamixergui: add license information

[Thomas Petazzoni]

Hello,

Please keep the Buildroot mailing list in Cc. Thanks!

On Thu, 2 Mar 2017 18:28:08 +0100, Wolfgang Grandegger wrote:

> "make legal-info" did report that the license is unkown.

Yes, before your patch. What I suggested is that you should run "make
legal-info" after your patch.

> Then I looked
> into "build/alsamixergui...". The COPYING file seems to be generated by make:
> 
> $ make alsamixergui-dirclean
> $ make alsamixergui-extract
> $ head build/alsamixergui-0.9.0rc2-1/COPYING 
> head: cannot open 'build/alsamixergui/COPYING' for reading: No such file or directory
> $ make alsamixergui
> $ head build/alsamixergui-0.9.0rc2-1/COPYING 

OK, but that doesn't work, because you have no guarantee that the
package has been built when "make legal-info" runs. "make legal-info"
only ensures that packages have been: 1. downloaded, 2. extracted, 3.
patched.

So, with your patch applied, if you run:

 $ make clean
 $ make legal-info

then you will see that it fails, because the COPYING file doesn't exist.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] package/alsamixergui: add license information

[Wolfgang Grandegger]

Hello,

Am 02.03.2017 um 21:37 schrieb Thomas Petazzoni:
> Hello,
>
> Please keep the Buildroot mailing list in Cc. Thanks!
>
> On Thu, 2 Mar 2017 18:28:08 +0100, Wolfgang Grandegger wrote:
>
>> "make legal-info" did report that the license is unkown.
>
> Yes, before your patch. What I suggested is that you should run "make
> legal-info" after your patch.
>
>> Then I looked
>> into "build/alsamixergui...". The COPYING file seems to be generated by make:
>>
>> $ make alsamixergui-dirclean
>> $ make alsamixergui-extract
>> $ head build/alsamixergui-0.9.0rc2-1/COPYING
>> head: cannot open 'build/alsamixergui/COPYING' for reading: No such file or directory
>> $ make alsamixergui
>> $ head build/alsamixergui-0.9.0rc2-1/COPYING
>
> OK, but that doesn't work, because you have no guarantee that the
> package has been built when "make legal-info" runs. "make legal-info"
> only ensures that packages have been: 1. downloaded, 2. extracted, 3.
> patched.
>
> So, with your patch applied, if you run:
>
>  $ make clean
>  $ make legal-info
>
> then you will see that it fails, because the COPYING file doesn't exist.

OK! How should I/we fix that problem? With a patch adding the COPYING 
file or we simply don't provide ALSAMIXERGUI_LICENSE_FILES.

Wolfgang.

[Buildroot] [PATCH] package/alsamixergui: add license information

[Thomas Petazzoni]

Hello,

On Fri, 3 Mar 2017 08:34:58 +0100, Wolfgang Grandegger wrote:

> OK! How should I/we fix that problem? With a patch adding the COPYING 
> file or we simply don't provide ALSAMIXERGUI_LICENSE_FILES.

As I suggested in my previous reply: use debian/copyright.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com