[Buildroot] [PATCH] x11vnc: make x11vnc select libvncserver

[Buildroot] [PATCH] x11vnc: make x11vnc select libvncserver

[Martin Kepplinger]

x11vnc needs libvncserver, so select it explicitely.

In case of missing libvncserver, we see build failures like this:

http://autobuild.buildroot.net/results/34f/34f8045e772b96293cc7d25bd61ac0aa5842824f/

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
 package/x11vnc/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/x11vnc/Config.in b/package/x11vnc/Config.in
index 0909b9aec..4542c5080 100644
--- a/package/x11vnc/Config.in
+++ b/package/x11vnc/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_X11VNC
 	select BR2_PACKAGE_XLIB_LIBXT
 	select BR2_PACKAGE_XLIB_LIBXEXT
 	select BR2_PACKAGE_XLIB_LIBXTST
+	select BR2_PACKAGE_LIBVNCSERVER
 	help
 	  VNC server for X11 display
 
-- 
2.11.0

[Buildroot] [PATCH] x11vnc: make x11vnc select libvncserver

[Baruch Siach]

Hi Martin,

On Sun, Apr 30, 2017 at 10:35:32AM +0200, Martin Kepplinger wrote:
> x11vnc needs libvncserver, so select it explicitely.
> 
> In case of missing libvncserver, we see build failures like this:
> 
> http://autobuild.buildroot.net/results/34f/34f8045e772b96293cc7d25bd61ac0aa5842824f/
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
>  package/x11vnc/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/x11vnc/Config.in b/package/x11vnc/Config.in
> index 0909b9aec..4542c5080 100644
> --- a/package/x11vnc/Config.in
> +++ b/package/x11vnc/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_X11VNC
>  	select BR2_PACKAGE_XLIB_LIBXT
>  	select BR2_PACKAGE_XLIB_LIBXEXT
>  	select BR2_PACKAGE_XLIB_LIBXTST
> +	select BR2_PACKAGE_LIBVNCSERVER

Since this is a build time dependency, you need to add it to 
X11VNC_DEPENDENCIES to make sure libvncserver builds before x11vnc.

You also need to propagate the additional BR2_PACKAGE_LIBVNCSERVER dependency, 
!BR2_nios2.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH v2] x11vnc: make x11vnc select libvncserver

[Martin Kepplinger]

x11vnc needs libvncserver, so select it explicitely.

In case of missing libvncserver, we see build failures like this:

http://autobuild.buildroot.net/results/34f/34f8045e772b96293cc7d25bd61ac0aa5842824f/

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---

Thanks a lot for your help! I think that's what you meant, right?

revision history
----------------
v2: add libvncserver to build dependencies and !BR2_nios2 to depends
v1: initial patch. add select BR2_PACKAGE_LIBVNCSERVER


 package/x11vnc/Config.in | 2 ++
 package/x11vnc/x11vnc.mk | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/package/x11vnc/Config.in b/package/x11vnc/Config.in
index 0909b9aec..9d9541cbf 100644
--- a/package/x11vnc/Config.in
+++ b/package/x11vnc/Config.in
@@ -2,9 +2,11 @@ config BR2_PACKAGE_X11VNC
 	bool "x11vnc"
 	depends on BR2_PACKAGE_XORG7
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_nios2 # from libvncserver
 	select BR2_PACKAGE_XLIB_LIBXT
 	select BR2_PACKAGE_XLIB_LIBXEXT
 	select BR2_PACKAGE_XLIB_LIBXTST
+	select BR2_PACKAGE_LIBVNCSERVER
 	help
 	  VNC server for X11 display
 
diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
index 9233b7047..5a505b920 100644
--- a/package/x11vnc/x11vnc.mk
+++ b/package/x11vnc/x11vnc.mk
@@ -16,6 +16,8 @@ X11VNC_LICENSE_FILES = COPYING
 # Source coming from github, no configure included
 X11VNC_AUTORECONF = YES
 
+X11VNC_DEPENDENCIES += libvncserver
+
 ifeq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yy)
 X11VNC_DEPENDENCIES += avahi dbus
 else
-- 
2.11.0

[Buildroot] [PATCH v2] x11vnc: make x11vnc select libvncserver

[Thomas Petazzoni]

Hello,

On Sun, 30 Apr 2017 15:05:02 +0200, Martin Kepplinger wrote:

> diff --git a/package/x11vnc/Config.in b/package/x11vnc/Config.in
> index 0909b9aec..9d9541cbf 100644
> --- a/package/x11vnc/Config.in
> +++ b/package/x11vnc/Config.in
> @@ -2,9 +2,11 @@ config BR2_PACKAGE_X11VNC
>  	bool "x11vnc"
>  	depends on BR2_PACKAGE_XORG7
>  	depends on BR2_USE_MMU # fork()
> +	depends on !BR2_nios2 # from libvncserver

The comment is normally just "# libvncserver"

>  	select BR2_PACKAGE_XLIB_LIBXT
>  	select BR2_PACKAGE_XLIB_LIBXEXT
>  	select BR2_PACKAGE_XLIB_LIBXTST
> +	select BR2_PACKAGE_LIBVNCSERVER

We try to keep things sorted alphabetically, so this select should have
been before the other ones.

> diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
> index 9233b7047..5a505b920 100644
> --- a/package/x11vnc/x11vnc.mk
> +++ b/package/x11vnc/x11vnc.mk
> @@ -16,6 +16,8 @@ X11VNC_LICENSE_FILES = COPYING
>  # Source coming from github, no configure included
>  X11VNC_AUTORECONF = YES
>  
> +X11VNC_DEPENDENCIES += libvncserver

No need for a new X11VNC_DEPENDENCIES assignment here, there was
already one a few lines above.

I've fixed those minor issues and applied your patch. Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com