[Buildroot] [PATCH] mpir: fix build failure

Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [PATCH] mpir: fix build failure
       [not found] <mpir: fix build failure>
@ 2017-04-17 13:59 ` Semyon Kolganov
  2017-04-17 14:08   ` Yann E. MORIN
  2017-04-17 14:40 ` [Buildroot] [PATCHv2] " Semyon Kolganov
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 18+ messages in thread
From: Semyon Kolganov @ 2017-04-17 13:59 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
 package/mpir/Config.in | 5 +++++
 package/mpir/mpir.mk   | 8 ++++++++
 2 files changed, 13 insertions(+)

diff --git a/package/mpir/Config.in b/package/mpir/Config.in
index da4cc9f..4f7fa65 100644
--- a/package/mpir/Config.in
+++ b/package/mpir/Config.in
@@ -1,8 +1,13 @@
 config BR2_PACKAGE_MPIR
 	bool "mpir"
+	# asm files in mpn/powerpc64/mode64/* are Abi version 1.
+	depends on !BR2_powerpc64le
 	select BR2_PACKAGE_GMP
 	help
 	  MPIR is a highly optimised library for bignum arithmetic
 	  forked from the GMP bignum library.
 
 	  http://www.mpir.org/
+
+comment "mpir conflicts with powerpc64le"
+	depends on BR2_powerpc64le
diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index 430d587..b835ca4 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -12,4 +12,12 @@ MPIR_LICENSE_FILES = COPYING.LIB
 MPIR_INSTALL_STAGING = YES
 MPIR_DEPENDENCIES = gmp host-yasm
 
+ifeq ($(BR2_MIPS_NABI32),y)
+MPIR_CONF_OPTS += ABI=n32
+endif
+
+ifeq ($(BR2_MIPS_NABI64),y)
+MPIR_CONF_OPTS += ABI=n64
+endif
+
 $(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] mpir: fix build failure
  2017-04-17 13:59 ` [Buildroot] [PATCH] mpir: fix build failure Semyon Kolganov
@ 2017-04-17 14:08   ` Yann E. MORIN
  2017-04-17 14:20     ` Semen Kolganov
  0 siblings, 1 reply; 18+ messages in thread
From: Yann E. MORIN @ 2017-04-17 14:08 UTC (permalink / raw)
  To: buildroot

Semyon, All,

On 2017-04-17 16:59 +0300, Semyon Kolganov spake thusly:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
> ---
>  package/mpir/Config.in | 5 +++++
>  package/mpir/mpir.mk   | 8 ++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/package/mpir/Config.in b/package/mpir/Config.in
> index da4cc9f..4f7fa65 100644
> --- a/package/mpir/Config.in
> +++ b/package/mpir/Config.in
> @@ -1,8 +1,13 @@
>  config BR2_PACKAGE_MPIR
>  	bool "mpir"
> +	# asm files in mpn/powerpc64/mode64/* are Abi version 1.
> +	depends on !BR2_powerpc64le

Is it otherwise possible to disable use of the asm code and use some
generic one (if any) ?

>  	select BR2_PACKAGE_GMP
>  	help
>  	  MPIR is a highly optimised library for bignum arithmetic
>  	  forked from the GMP bignum library.
>  
>  	  http://www.mpir.org/
> +
> +comment "mpir conflicts with powerpc64le"
> +	depends on BR2_powerpc64le

We do not usually add a comment for architecture dependencies.

Regards,
Yann E. MORIN.

> diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
> index 430d587..b835ca4 100644
> --- a/package/mpir/mpir.mk
> +++ b/package/mpir/mpir.mk
> @@ -12,4 +12,12 @@ MPIR_LICENSE_FILES = COPYING.LIB
>  MPIR_INSTALL_STAGING = YES
>  MPIR_DEPENDENCIES = gmp host-yasm
>  
> +ifeq ($(BR2_MIPS_NABI32),y)
> +MPIR_CONF_OPTS += ABI=n32
> +endif
> +
> +ifeq ($(BR2_MIPS_NABI64),y)
> +MPIR_CONF_OPTS += ABI=n64
> +endif
> +
>  $(eval $(autotools-package))
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] mpir: fix build failure
  2017-04-17 14:08   ` Yann E. MORIN
@ 2017-04-17 14:20     ` Semen Kolganov
  0 siblings, 0 replies; 18+ messages in thread
From: Semen Kolganov @ 2017-04-17 14:20 UTC (permalink / raw)
  To: buildroot


Well, good idea, I'll check it. Thanks for revision!

>???????????, 17 ?????? 2017, 17:08 +03:00 ?? "Yann E. MORIN" <yann.morin.1998@free.fr>:
>
>Semyon, All,
>
>On 2017-04-17 16:59 +0300, Semyon Kolganov spake thusly:
>> Signed-off-by: Semyon Kolganov < semenak94@mail.ru >
>> ---
>>  package/mpir/Config.in | 5 +++++
>>  package/mpir/mpir.mk   | 8 ++++++++
>>  2 files changed, 13 insertions(+)
>> 
>> diff --git a/package/mpir/Config.in b/package/mpir/Config.in
>> index da4cc9f..4f7fa65 100644
>> --- a/package/mpir/Config.in
>> +++ b/package/mpir/Config.in
>> @@ -1,8 +1,13 @@
>>  config BR2_PACKAGE_MPIR
>>  	bool "mpir"
>> +	# asm files in mpn/powerpc64/mode64/* are Abi version 1.
>> +	depends on !BR2_powerpc64le
>
>Is it otherwise possible to disable use of the asm code and use some
>generic one (if any) ?
>
>>  	select BR2_PACKAGE_GMP
>>  	help
>>  	  MPIR is a highly optimised library for bignum arithmetic
>>  	  forked from the GMP bignum library.
>> 
>>  	  http://www.mpir.org/
>> +
>> +comment "mpir conflicts with powerpc64le"
>> +	depends on BR2_powerpc64le
>
>We do not usually add a comment for architecture dependencies.
>
>Regards,
>Yann E. MORIN.
>
>> diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
>> index 430d587..b835ca4 100644
>> --- a/package/mpir/mpir.mk
>> +++ b/package/mpir/mpir.mk
>> @@ -12,4 +12,12 @@ MPIR_LICENSE_FILES = COPYING.LIB
>>  MPIR_INSTALL_STAGING = YES
>>  MPIR_DEPENDENCIES = gmp host-yasm
>> 
>> +ifeq ($(BR2_MIPS_NABI32),y)
>> +MPIR_CONF_OPTS += ABI=n32
>> +endif
>> +
>> +ifeq ($(BR2_MIPS_NABI64),y)
>> +MPIR_CONF_OPTS += ABI=n64
>> +endif
>> +
>>  $(eval $(autotools-package))
>> -- 
>> 2.7.4
>> 
>> _______________________________________________
>> buildroot mailing list
>>  buildroot at busybox.net
>>  http://lists.busybox.net/mailman/listinfo/buildroot
>
>-- 
>.-----------------.--------------------.------------------.--------------------.
>|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>|  +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
>|  +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
>|  http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
>'------------------------------^-------^------------------^--------------------'


Semyon
---------------
Semyon Kolganov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170417/44b6d28b/attachment.html>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv2] mpir: fix build failure
       [not found] <mpir: fix build failure>
  2017-04-17 13:59 ` [Buildroot] [PATCH] mpir: fix build failure Semyon Kolganov
@ 2017-04-17 14:40 ` Semyon Kolganov
  2017-04-17 14:57   ` Yann E. MORIN
  2017-04-17 15:20 ` [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/ Semyon Kolganov
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 18+ messages in thread
From: Semyon Kolganov @ 2017-04-17 14:40 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
Changes between v1 and v2:
 - removed unneeded depend on
 - fixed build for powerpc
---
 package/mpir/mpir.mk | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index 430d587..2a5807b 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -12,4 +12,17 @@ MPIR_LICENSE_FILES = COPYING.LIB
 MPIR_INSTALL_STAGING = YES
 MPIR_DEPENDENCIES = gmp host-yasm
 
+ifeq ($(BR2_MIPS_NABI32),y)
+MPIR_CONF_OPTS += ABI=n32
+endif
+
+ifeq ($(BR2_MIPS_NABI64),y)
+MPIR_CONF_OPTS += ABI=n64
+endif
+
+ifeq ($(BR2_powerpc_CLASSIC),y)
+MPIR_CONF_OPTS += ABI=mode64
+export MPN_PATH=generic
+endif
+
 $(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv2] mpir: fix build failure
  2017-04-17 14:40 ` [Buildroot] [PATCHv2] " Semyon Kolganov
@ 2017-04-17 14:57   ` Yann E. MORIN
  0 siblings, 0 replies; 18+ messages in thread
From: Yann E. MORIN @ 2017-04-17 14:57 UTC (permalink / raw)
  To: buildroot

Semyon, All,

On 2017-04-17 17:40 +0300, Semyon Kolganov spake thusly:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

I forgot to state in my previous review, but: is this fixing autobuilder
failiures? If so, please include (a few) references to those failures,
like (assuming those are the failures you wanted to fix!):

    Fixes:
        http://autobuild.buildroot.org/results/df7/df7e532686303e8f975aefc82dafb9ee66c529c8/
        http://autobuild.buildroot.org/results/a9a/a9a1f0a23f8983410cf641d869ad0dcd543da677/
        [...]

I guess the committer can add this when applying; no need to respin.

Otherwise:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> Changes between v1 and v2:
>  - removed unneeded depend on
>  - fixed build for powerpc
> ---
>  package/mpir/mpir.mk | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
> index 430d587..2a5807b 100644
> --- a/package/mpir/mpir.mk
> +++ b/package/mpir/mpir.mk
> @@ -12,4 +12,17 @@ MPIR_LICENSE_FILES = COPYING.LIB
>  MPIR_INSTALL_STAGING = YES
>  MPIR_DEPENDENCIES = gmp host-yasm
>  
> +ifeq ($(BR2_MIPS_NABI32),y)
> +MPIR_CONF_OPTS += ABI=n32
> +endif
> +
> +ifeq ($(BR2_MIPS_NABI64),y)
> +MPIR_CONF_OPTS += ABI=n64
> +endif
> +
> +ifeq ($(BR2_powerpc_CLASSIC),y)
> +MPIR_CONF_OPTS += ABI=mode64
> +export MPN_PATH=generic
> +endif
> +
>  $(eval $(autotools-package))
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/
       [not found] <mpir: fix build failure>
  2017-04-17 13:59 ` [Buildroot] [PATCH] mpir: fix build failure Semyon Kolganov
  2017-04-17 14:40 ` [Buildroot] [PATCHv2] " Semyon Kolganov
@ 2017-04-17 15:20 ` Semyon Kolganov
  2017-04-18 19:59   ` Arnout Vandecappelle
  2017-04-19  9:12 ` [Buildroot] [PATCHv4] mpir: fix build failure Semyon Kolganov
  2017-04-21 11:27 ` [Buildroot] [PATCHv5] " Semyon Kolganov
  4 siblings, 1 reply; 18+ messages in thread
From: Semyon Kolganov @ 2017-04-17 15:20 UTC (permalink / raw)
  To: buildroot

 http://autobuild.buildroot.net/results/b4c/b4c65ad8f35299588de67917be5d020a7f641ce7/

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
Changes between v1 and v2:
 - removed unneeded depend on
 - fixed build for powerpc
---
 package/mpir/mpir.mk | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index 430d587..2a5807b 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -12,4 +12,17 @@ MPIR_LICENSE_FILES = COPYING.LIB
 MPIR_INSTALL_STAGING = YES
 MPIR_DEPENDENCIES = gmp host-yasm
 
+ifeq ($(BR2_MIPS_NABI32),y)
+MPIR_CONF_OPTS += ABI=n32
+endif
+
+ifeq ($(BR2_MIPS_NABI64),y)
+MPIR_CONF_OPTS += ABI=n64
+endif
+
+ifeq ($(BR2_powerpc_CLASSIC),y)
+MPIR_CONF_OPTS += ABI=mode64
+export MPN_PATH=generic
+endif
+
 $(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/
  2017-04-17 15:20 ` [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/ Semyon Kolganov
@ 2017-04-18 19:59   ` Arnout Vandecappelle
  0 siblings, 0 replies; 18+ messages in thread
From: Arnout Vandecappelle @ 2017-04-18 19:59 UTC (permalink / raw)
  To: buildroot



On 17-04-17 17:20, Semyon Kolganov wrote:
>  http://autobuild.buildroot.net/results/b4c/b4c65ad8f35299588de67917be5d020a7f641ce7/
> 
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
> ---
> Changes between v1 and v2:
>  - removed unneeded depend on
>  - fixed build for powerpc
> ---
>  package/mpir/mpir.mk | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
> index 430d587..2a5807b 100644
> --- a/package/mpir/mpir.mk
> +++ b/package/mpir/mpir.mk
> @@ -12,4 +12,17 @@ MPIR_LICENSE_FILES = COPYING.LIB
>  MPIR_INSTALL_STAGING = YES
>  MPIR_DEPENDENCIES = gmp host-yasm
>  
> +ifeq ($(BR2_MIPS_NABI32),y)
> +MPIR_CONF_OPTS += ABI=n32
> +endif
> +
> +ifeq ($(BR2_MIPS_NABI64),y)
> +MPIR_CONF_OPTS += ABI=n64
> +endif
> +
> +ifeq ($(BR2_powerpc_CLASSIC),y)
> +MPIR_CONF_OPTS += ABI=mode64
> +export MPN_PATH=generic

 This is not good, because it will *globally* export that variable, not just for
this package.

 Instead, you should set
MPIR_CONF_ENV += MPN_PATH=generic

(and if it is also needed at build time, same for MPIR_MAKE_ENV).

 Regards,
 Arnout

> +endif
> +
>  $(eval $(autotools-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv4] mpir: fix build failure
       [not found] <mpir: fix build failure>
                   ` (2 preceding siblings ...)
  2017-04-17 15:20 ` [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/ Semyon Kolganov
@ 2017-04-19  9:12 ` Semyon Kolganov
  2017-04-21 11:27 ` [Buildroot] [PATCHv5] " Semyon Kolganov
  4 siblings, 0 replies; 18+ messages in thread
From: Semyon Kolganov @ 2017-04-19  9:12 UTC (permalink / raw)
  To: buildroot

fixes:

 http://autobuild.buildroot.net/results/ecd/ecdde998c6763c14b2314d4513f15db95305fa11//
 http://autobuild.buildroot.net/results/b4c/b4c65ad8f35299588de67917be5d020a7f641ce7//

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
Changes between v3 and v4:
 - small formatting change

Changes between v2 and v3:
 - fixed build for mips

Changes between v1 and v2:
 - removed unneeded depend on
 - fixed build for powerpc
---
 package/mpir/mpir.mk | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index 430d587..24cd00d 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -12,4 +12,18 @@ MPIR_LICENSE_FILES = COPYING.LIB
 MPIR_INSTALL_STAGING = YES
 MPIR_DEPENDENCIES = gmp host-yasm
 
+ifeq ($(BR2_MIPS_NABI32),y)
+MPIR_CONF_OPTS += ABI=n32
+endif
+
+ifeq ($(BR2_MIPS_NABI64),y)
+MPIR_CONF_OPTS += ABI=n64
+endif
+
+ifeq ($(BR2_powerpc_CLASSIC),y)
+MPIR_CONF_OPTS += \
+	ABI=mode64 \
+	MPN_PATH=generic
+endif
+
 $(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv5] mpir: fix build failure
       [not found] <mpir: fix build failure>
                   ` (3 preceding siblings ...)
  2017-04-19  9:12 ` [Buildroot] [PATCHv4] mpir: fix build failure Semyon Kolganov
@ 2017-04-21 11:27 ` Semyon Kolganov
  2017-05-01  9:21   ` Thomas Petazzoni
  4 siblings, 1 reply; 18+ messages in thread
From: Semyon Kolganov @ 2017-04-21 11:27 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
Changes between v4 and v5:
 - right env variable

Changes between v3 and v4:
 - small formatting change

Changes between v2 and v3:
 - fixed build for mips

Changes between v1 and v2:
 - removed unneeded depend on
 - fixed build for powerpc
---
 package/mpir/mpir.mk | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index 430d587..85569da 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -12,4 +12,17 @@ MPIR_LICENSE_FILES = COPYING.LIB
 MPIR_INSTALL_STAGING = YES
 MPIR_DEPENDENCIES = gmp host-yasm
 
+ifeq ($(BR2_MIPS_NABI32),y)
+MPIR_CONF_OPTS += ABI=n32
+endif
+
+ifeq ($(BR2_MIPS_NABI64),y)
+MPIR_CONF_OPTS += ABI=n64
+endif
+
+ifeq ($(BR2_powerpc_CLASSIC),y)
+MPIR_CONF_OPTS += ABI=mode64
+MPIR_CONF_ENV += MPN_PATH=generic
+endif
+
 $(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv5] mpir: fix build failure
  2017-04-21 11:27 ` [Buildroot] [PATCHv5] " Semyon Kolganov
@ 2017-05-01  9:21   ` Thomas Petazzoni
  2017-05-01  9:25     ` Thomas Petazzoni
  2017-05-01 19:40     ` semenak94 at mail.ru
  0 siblings, 2 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2017-05-01  9:21 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 21 Apr 2017 14:27:11 +0300, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

When you're fixing build failures from the autobuilders, the commit log
should provide references to the autobuilder failures being fixed.

> +ifeq ($(BR2_MIPS_NABI64),y)
> +MPIR_CONF_OPTS += ABI=n64
> +endif

You did not even test this, because it fails to build:

configure: error: ABI=n64 is not among the following valid choices: 64 n32 o32

So I've fixed that to ABI=64

> +ifeq ($(BR2_powerpc_CLASSIC),y)
> +MPIR_CONF_OPTS += ABI=mode64
> +MPIR_CONF_ENV += MPN_PATH=generic
> +endif

This looks bogus. mode64 seems to refer to a 64-bit ABI, while
BR2_powerpc_CLASSIC is not necessarily 64 bit.

So, I've applied after changing ABI=n64 to ABI=64, dropping the PowerPC
stuff and adding a reference to the autobuilder failure being fixes.

That being said, there are still several other mpir related build
failures that have not been fixed:

 * On ARM, we fail with the old Crosstool-NG toolchains, but apparently
   not with other ARM toolchains. Both the ARMv5 and ARMv7 Crosstool-NG
   toolchains are failing to build MPIR:

   http://autobuild.buildroot.net/results/fd0/fd032f7dbd4cace84bb31e8017cb6139ef3c1072/build-end.log
   http://autobuild.buildroot.net/results/c36/c360581c2925529f18635aac32c2865899f5e0f5/build-end.log

 * On MIPS64r6

   http://autobuild.buildroot.net/results/c45/c45dd59f10693b0d9a86dac4733c6c3dde4554f1/build-end.log

 * On PowerPC64

   http://autobuild.buildroot.net/results/be1/be1478836b2e7b580174641f48de92c9b02512a7/build-end.log

Could you have a look and fix those remaining issues?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv5] mpir: fix build failure
  2017-05-01  9:21   ` Thomas Petazzoni
@ 2017-05-01  9:25     ` Thomas Petazzoni
  2017-05-01 19:40     ` semenak94 at mail.ru
  1 sibling, 0 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2017-05-01  9:25 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 1 May 2017 11:21:49 +0200, Thomas Petazzoni wrote:

>  * On ARM, we fail with the old Crosstool-NG toolchains, but apparently
>    not with other ARM toolchains. Both the ARMv5 and ARMv7 Crosstool-NG
>    toolchains are failing to build MPIR:
> 
>    http://autobuild.buildroot.net/results/fd0/fd032f7dbd4cace84bb31e8017cb6139ef3c1072/build-end.log
>    http://autobuild.buildroot.net/results/c36/c360581c2925529f18635aac32c2865899f5e0f5/build-end.log
> 
>  * On MIPS64r6
> 
>    http://autobuild.buildroot.net/results/c45/c45dd59f10693b0d9a86dac4733c6c3dde4554f1/build-end.log
> 
>  * On PowerPC64
> 
>    http://autobuild.buildroot.net/results/be1/be1478836b2e7b580174641f48de92c9b02512a7/build-end.log
> 
> Could you have a look and fix those remaining issues?

And by the way: please use the test-pkg script in
support/scripts/test-pkg to test that MPIR builds correctly on all
platforms.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv5] mpir: fix build failure
  2017-05-01  9:21   ` Thomas Petazzoni
  2017-05-01  9:25     ` Thomas Petazzoni
@ 2017-05-01 19:40     ` semenak94 at mail.ru
  1 sibling, 0 replies; 18+ messages in thread
From: semenak94 at mail.ru @ 2017-05-01 19:40 UTC (permalink / raw)
  To: buildroot


Hello, 
Of course, I'll fixed it, as son as possible. 
--
Semyon
-----------
Semyon Kolganov  ???????????, 01 ??? 2017?., 12:21 +03:00 ?? Thomas Petazzoni  thomas.petazzoni at free-electrons.com :

>Hello,
>
>On Fri, 21 Apr 2017 14:27:11 +0300, Semyon Kolganov wrote:
>> Signed-off-by: Semyon Kolganov < semenak94@mail.ru >
>
>When you're fixing build failures from the autobuilders, the commit log
>should provide references to the autobuilder failures being fixed.
>
>> +ifeq ($(BR2_MIPS_NABI64),y)
>> +MPIR_CONF_OPTS += ABI=n64
>> +endif
>
>You did not even test this, because it fails to build:
>
>configure: error: ABI=n64 is not among the following valid choices: 64 n32 o32
>
>So I've fixed that to ABI=64
>
>> +ifeq ($(BR2_powerpc_CLASSIC),y)
>> +MPIR_CONF_OPTS += ABI=mode64
>> +MPIR_CONF_ENV += MPN_PATH=generic
>> +endif
>
>This looks bogus. mode64 seems to refer to a 64-bit ABI, while
>BR2_powerpc_CLASSIC is not necessarily 64 bit.
>
>So, I've applied after changing ABI=n64 to ABI=64, dropping the PowerPC
>stuff and adding a reference to the autobuilder failure being fixes.
>
>That being said, there are still several other mpir related build
>failures that have not been fixed:
>
>?* On ARM, we fail with the old Crosstool-NG toolchains, but apparently
>???not with other ARM toolchains. Both the ARMv5 and ARMv7 Crosstool-NG
>???toolchains are failing to build MPIR:
>
>??? http://autobuild.buildroot.net/results/fd0/fd032f7dbd4cace84bb31e8017cb6139ef3c1072/build-end.log
>??? http://autobuild.buildroot.net/results/c36/c360581c2925529f18635aac32c2865899f5e0f5/build-end.log
>
>?* On MIPS64r6
>
>??? http://autobuild.buildroot.net/results/c45/c45dd59f10693b0d9a86dac4733c6c3dde4554f1/build-end.log
>
>?* On PowerPC64
>
>??? http://autobuild.buildroot.net/results/be1/be1478836b2e7b580174641f48de92c9b02512a7/build-end.log
>
>Could you have a look and fix those remaining issues?
>
>Thanks!
>
>Thomas
>-- 
>Thomas Petazzoni, CTO, Free Electrons
>Embedded Linux and Kernel engineering
>http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170501/87298ad8/attachment.html>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv5] mpir: fix build failure
@ 2017-04-19  9:37 Semen Kolganov
  0 siblings, 0 replies; 18+ messages in thread
From: Semen Kolganov @ 2017-04-19  9:37 UTC (permalink / raw)
  To: buildroot

fixes:

? http://autobuild.buildroot.net/results/ecd/ecdde998c6763c14b2314d4513f15db95305fa11//
? http://autobuild.buildroot.net/results/b4c/b4c65ad8f35299588de67917be5d020a7f641ce7//

PATCHv4 is incorrect

Semyon
---------------
Semyon Kolganov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170419/0a11fac1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v5-0001-mpir-fix-build-failure.patch
Type: application/x-patch
Size: 1108 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170419/0a11fac1/attachment.bin>

^ permalink raw reply	[flat|nested] 18+ messages in thread

[parent not found: <mpir: new package>]

* [Buildroot] [PATCH] mpir: new package
       [not found] <mpir: new package>
@ 2017-04-13 13:49 ` Semyon Kolganov
  2017-04-13 19:59   ` Thomas Petazzoni
  2017-04-13 20:32 ` [Buildroot] [PATCHv2] " Semyon Kolganov
  1 sibling, 1 reply; 18+ messages in thread
From: Semyon Kolganov @ 2017-04-13 13:49 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
 package/Config.in      |  1 +
 package/mpir/Config.in |  8 ++++++++
 package/mpir/mpir.hash |  2 ++
 package/mpir/mpir.mk   | 18 ++++++++++++++++++
 4 files changed, 29 insertions(+)
 create mode 100644 package/mpir/Config.in
 create mode 100644 package/mpir/mpir.hash
 create mode 100644 package/mpir/mpir.mk

diff --git a/package/Config.in b/package/Config.in
index 3683578..0866c13 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1405,6 +1405,7 @@ endif
 	source "package/mpc/Config.in"
 	source "package/mpdecimal/Config.in"
 	source "package/mpfr/Config.in"
+	source "package/mpir/Config.in"
 	source "package/msgpack/Config.in"
 	source "package/mtdev2tuio/Config.in"
 	source "package/musl-compat-headers/Config.in"
diff --git a/package/mpir/Config.in b/package/mpir/Config.in
new file mode 100644
index 0000000..acd448c
--- /dev/null
+++ b/package/mpir/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_MPIR
+	bool "mpir"
+	select BR2_PACKAGE_GMP
+	help
+	  MPIR is a highly optimised library for bignum arithmetic forked 
+	  from the GMP bignum library.
+
+	  http://www.mpir.org/
diff --git a/package/mpir/mpir.hash b/package/mpir/mpir.hash
new file mode 100644
index 0000000..8320337
--- /dev/null
+++ b/package/mpir/mpir.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256	52f63459cf3f9478859de29e00357f004050ead70b45913f2c2269d9708675bb	mpir-3.0.0.tar.bz2
diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
new file mode 100644
index 0000000..fbce887
--- /dev/null
+++ b/package/mpir/mpir.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# mpir
+#
+################################################################################
+
+MPIR_VERSION = 3.0.0
+MPIR_SITE = http://www.mpir.org
+MPIR_SOURCE = mpir-$(MPIR_VERSION).tar.bz2
+MPIR_LICENSE = LGPL-3.0+
+MPIR_LICENSE_FILES = COPYING.LIB
+MPIR_INSTALL_STAGING = YES
+MPIR_DEPENDENCIES = gmp
+HOST_MPIR_DEPENDENCIES = host-gmp
+MPIR_MAKE_OPTS = RANLIB=$(TARGET_RANLIB)
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCH] mpir: new package
  2017-04-13 13:49 ` [Buildroot] [PATCH] mpir: new package Semyon Kolganov
@ 2017-04-13 19:59   ` Thomas Petazzoni
       [not found]     ` <1492114114.644630127@f341.i.mail.ru>
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Petazzoni @ 2017-04-13 19:59 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 13 Apr 2017 16:49:34 +0300, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

Thanks for this new contribution. It generally looks good, just a few
comments, see below.

>  package/Config.in      |  1 +
>  package/mpir/Config.in |  8 ++++++++
>  package/mpir/mpir.hash |  2 ++
>  package/mpir/mpir.mk   | 18 ++++++++++++++++++

You forgot to change the DEVELOPERS file to add yourself as the
developer for this package.

> diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
> new file mode 100644
> index 0000000..fbce887
> --- /dev/null
> +++ b/package/mpir/mpir.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# mpir
> +#
> +################################################################################
> +
> +MPIR_VERSION = 3.0.0
> +MPIR_SITE = http://www.mpir.org
> +MPIR_SOURCE = mpir-$(MPIR_VERSION).tar.bz2
> +MPIR_LICENSE = LGPL-3.0+
> +MPIR_LICENSE_FILES = COPYING.LIB
> +MPIR_INSTALL_STAGING = YES
> +MPIR_DEPENDENCIES = gmp
> +HOST_MPIR_DEPENDENCIES = host-gmp
> +MPIR_MAKE_OPTS = RANLIB=$(TARGET_RANLIB)
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))

Why is a host variant of this package needed? It should at the very
least be explained in the commit log.

The rest looks good.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

[parent not found: <1492114114.644630127@f341.i.mail.ru>]

* [Buildroot] [PATCH] mpir: new package
       [not found]     ` <1492114114.644630127@f341.i.mail.ru>
@ 2017-04-13 20:13       ` Thomas Petazzoni
  0 siblings, 0 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2017-04-13 20:13 UTC (permalink / raw)
  To: buildroot

Hello,

Please keep the Buildroot mailing list in Cc, thanks!

On Thu, 13 Apr 2017 23:08:34 +0300, Semen Kolganov wrote:

> I just forgot about DEVELOPER file.:-)?Should I resend you a new
> patch?
>
> Well, about host, I thought, that it can be usefull to have this
> library on host, when you don't need in your target, but only for
> building.

We don't want to needlessly add host packages. So either the host
package is needed as a build dependency of another package or directly
useful for some specific use case, otherwise we simply don't want to
have a host variant.

So we never add a host variant "just because".

Could you resend after dropping the host variant and adding the change
to the DEVELOPERS file?

Make sure to run support/scripts/check-package on your package.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv2] mpir: new package
       [not found] <mpir: new package>
  2017-04-13 13:49 ` [Buildroot] [PATCH] mpir: new package Semyon Kolganov
@ 2017-04-13 20:32 ` Semyon Kolganov
  2017-04-13 21:05   ` Thomas Petazzoni
  1 sibling, 1 reply; 18+ messages in thread
From: Semyon Kolganov @ 2017-04-13 20:32 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
Changes between v1 and v2:
 - removed host variant
 - added package to DEVELOPERS
---
 DEVELOPERS             |  1 +
 package/Config.in      |  1 +
 package/mpir/Config.in |  8 ++++++++
 package/mpir/mpir.hash |  2 ++
 package/mpir/mpir.mk   | 16 ++++++++++++++++
 5 files changed, 28 insertions(+)
 create mode 100644 package/mpir/Config.in
 create mode 100644 package/mpir/mpir.hash
 create mode 100644 package/mpir/mpir.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index a7e1849..1f42e6e 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1418,6 +1418,7 @@ F:	package/yaml-cpp/
 N:	Semyon Kolganov <semenak94@mail.ru>
 F:	package/fmt/
 F:	package/libbson/
+F:	package/mpir/
 
 N:	Sergio Prado <sergio.prado@e-labworks.com>
 F:	package/libgdiplus/
diff --git a/package/Config.in b/package/Config.in
index 3683578..0866c13 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1405,6 +1405,7 @@ endif
 	source "package/mpc/Config.in"
 	source "package/mpdecimal/Config.in"
 	source "package/mpfr/Config.in"
+	source "package/mpir/Config.in"
 	source "package/msgpack/Config.in"
 	source "package/mtdev2tuio/Config.in"
 	source "package/musl-compat-headers/Config.in"
diff --git a/package/mpir/Config.in b/package/mpir/Config.in
new file mode 100644
index 0000000..acd448c
--- /dev/null
+++ b/package/mpir/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_MPIR
+	bool "mpir"
+	select BR2_PACKAGE_GMP
+	help
+	  MPIR is a highly optimised library for bignum arithmetic forked 
+	  from the GMP bignum library.
+
+	  http://www.mpir.org/
diff --git a/package/mpir/mpir.hash b/package/mpir/mpir.hash
new file mode 100644
index 0000000..8320337
--- /dev/null
+++ b/package/mpir/mpir.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256	52f63459cf3f9478859de29e00357f004050ead70b45913f2c2269d9708675bb	mpir-3.0.0.tar.bz2
diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
new file mode 100644
index 0000000..9b15a0c
--- /dev/null
+++ b/package/mpir/mpir.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# mpir
+#
+################################################################################
+
+MPIR_VERSION = 3.0.0
+MPIR_SITE = http://www.mpir.org
+MPIR_SOURCE = mpir-$(MPIR_VERSION).tar.bz2
+MPIR_LICENSE = LGPL-3.0+
+MPIR_LICENSE_FILES = COPYING.LIB
+MPIR_INSTALL_STAGING = YES
+MPIR_DEPENDENCIES = gmp
+MPIR_MAKE_OPTS = RANLIB=$(TARGET_RANLIB)
+
+$(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [Buildroot] [PATCHv2] mpir: new package
  2017-04-13 20:32 ` [Buildroot] [PATCHv2] " Semyon Kolganov
@ 2017-04-13 21:05   ` Thomas Petazzoni
  0 siblings, 0 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2017-04-13 21:05 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 13 Apr 2017 23:32:01 +0300, Semyon Kolganov wrote:

> +	  MPIR is a highly optimised library for bignum arithmetic forked 

This line had a trailing slash, and was too long, so I rewrapped the
Config.in help text.

> +MPIR_DEPENDENCIES = gmp

A dependency on host-yasm was missing, so I've added it here.
Otherwise, the build fails if yasm is not installed on your system.

> +MPIR_MAKE_OPTS = RANLIB=$(TARGET_RANLIB)

Everything build successfully without this line for me, so I dropped
it. Let me know which problem it solved for you.

I've applied after fixing the above issues.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2017-05-01 19:40 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <mpir: fix build failure>
2017-04-17 13:59 ` [Buildroot] [PATCH] mpir: fix build failure Semyon Kolganov
2017-04-17 14:08   ` Yann E. MORIN
2017-04-17 14:20     ` Semen Kolganov
2017-04-17 14:40 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-17 14:57   ` Yann E. MORIN
2017-04-17 15:20 ` [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/ Semyon Kolganov
2017-04-18 19:59   ` Arnout Vandecappelle
2017-04-19  9:12 ` [Buildroot] [PATCHv4] mpir: fix build failure Semyon Kolganov
2017-04-21 11:27 ` [Buildroot] [PATCHv5] " Semyon Kolganov
2017-05-01  9:21   ` Thomas Petazzoni
2017-05-01  9:25     ` Thomas Petazzoni
2017-05-01 19:40     ` semenak94 at mail.ru
2017-04-19  9:37 Semen Kolganov
     [not found] <mpir: new package>
2017-04-13 13:49 ` [Buildroot] [PATCH] mpir: new package Semyon Kolganov
2017-04-13 19:59   ` Thomas Petazzoni
     [not found]     ` <1492114114.644630127@f341.i.mail.ru>
2017-04-13 20:13       ` Thomas Petazzoni
2017-04-13 20:32 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-13 21:05   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox