Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] host-cargo: select host-rustc
@ 2018-06-06 20:25 Fabrice Fontaine
  2018-06-06 20:25 ` [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
  2018-06-07 16:02 ` [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Thomas Petazzoni
  0 siblings, 2 replies; 7+ messages in thread
From: Fabrice Fontaine @ 2018-06-06 20:25 UTC (permalink / raw)
  To: buildroot

Buildroot documentation specifies that cargo-based package should only
depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS and selects
BR2_PACKAGE_HOST_CARGO but this does not work as host-cargo depends on
BR2_PACKAGE_HAS_HOST_RUSTC which is selected only when host-rustc is
selected.

So instead of having to select both cargo and rustc in each cargo-based
package, replace BR2_PACKAGE_HAS_HOST_RUSTC dependency by
BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS and select
BR2_PACKAGE_HOST_RUSTC

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/cargo/Config.in.host | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/cargo/Config.in.host b/package/cargo/Config.in.host
index 0f1ca305c6..c33c6851f2 100644
--- a/package/cargo/Config.in.host
+++ b/package/cargo/Config.in.host
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_HOST_CARGO
 	bool "host cargo"
-	depends on BR2_PACKAGE_HAS_HOST_RUSTC
+	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
+	select BR2_PACKAGE_HOST_RUSTC
 	help
 	  Cargo is the package manager for the Rust programming
 	  language.
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5
  2018-06-06 20:25 [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Fabrice Fontaine
@ 2018-06-06 20:25 ` Fabrice Fontaine
  2018-06-07  2:39   ` Baruch Siach
  2018-06-07  5:58   ` Thomas Petazzoni
  2018-06-07 16:02 ` [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Thomas Petazzoni
  1 sibling, 2 replies; 7+ messages in thread
From: Fabrice Fontaine @ 2018-06-06 20:25 UTC (permalink / raw)
  To: buildroot

- Add a dependency to host-cargo
- Add a patch to set RUST_TARGET
- Add a dependency to BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
- Forward this dependency to efl svg and enlightment
- Add hash for license file

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/efl/Config.in                              |  1 +
 package/enlightenment/Config.in                    |  2 +
 .../librsvg/0001-Add-RUST_TARGET-variable.patch    | 57 ++++++++++++++++++++++
 package/librsvg/Config.in                          |  3 ++
 package/librsvg/librsvg.hash                       |  7 ++-
 package/librsvg/librsvg.mk                         | 12 +++--
 6 files changed, 76 insertions(+), 6 deletions(-)
 create mode 100644 package/librsvg/0001-Add-RUST_TARGET-variable.patch

diff --git a/package/efl/Config.in b/package/efl/Config.in
index cfb803c6df..b9b285d8da 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -289,6 +289,7 @@ config BR2_PACKAGE_EFL_LIBRAW
 
 config BR2_PACKAGE_EFL_SVG
 	bool "SVG loader"
+	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # librsvg
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # librsvg -> pango -> harfbuzz
 	select BR2_PACKAGE_LIBRSVG
 	select BR2_PACKAGE_CAIRO
diff --git a/package/enlightenment/Config.in b/package/enlightenment/Config.in
index d1dee25f86..de194c7b37 100644
--- a/package/enlightenment/Config.in
+++ b/package/enlightenment/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_ENLIGHTENMENT
 	bool "enlightenment"
+	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # efl svg
 	# libevas-generic-loaders-svg -> librsvg -> glib2 / pango
 	depends on BR2_USE_WCHAR
 	depends on BR2_INSTALL_LIBSTDCPP
@@ -29,6 +30,7 @@ config BR2_PACKAGE_ENLIGHTENMENT
 	  http://www.enlightenment.org/
 
 comment "enlightenment needs udev /dev management and a toolchain w/ wchar, C++, threads"
+	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_EFL && BR2_PACKAGE_XORG7 && BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_PACKAGE_HAS_UDEV
diff --git a/package/librsvg/0001-Add-RUST_TARGET-variable.patch b/package/librsvg/0001-Add-RUST_TARGET-variable.patch
new file mode 100644
index 0000000000..2807c2423f
--- /dev/null
+++ b/package/librsvg/0001-Add-RUST_TARGET-variable.patch
@@ -0,0 +1,57 @@
+From 2bef718d1ade8dd20f431ac2eef9fdf58d96842f Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Fri, 1 Jun 2018 20:58:25 +0200
+Subject: [PATCH] Add RUST_TARGET variable
+
+Add RUST_TARGET environment variable through AC_ARG_VAR to allow the
+user to override the rust target name. Indeed, using $host when
+cross-compiling is not always the good option especially when vendor
+part of target is not set to unknown but to another value such as
+buildroot.
+Indeed, in this case aarch64-buildroot-linux-gnu won't be recognised as
+a valid target by rust/cargo.
+
+[Upstream status: merged (https://github.com/GNOME/librsvg/commit/f0b76ab6f003b8e05d4caab2b6d844e97b97796f)]
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+---
+ Makefile.am  | 2 +-
+ configure.ac | 7 ++++++-
+ 2 files changed, 7 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index f21b58e2..0b5b906f 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -136,7 +136,7 @@ CARGO_RELEASE_ARGS=--release
+ endif
+ 
+ if CROSS_COMPILING
+-CARGO_TARGET_ARGS=--target=$(host)
++CARGO_TARGET_ARGS=--target=$(RUST_TARGET)
+ endif
+ 
+ CARGO_VERBOSE = $(cargo_verbose_$(V))
+diff --git a/configure.ac b/configure.ac
+index c9666757..50ca9f0f 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -286,9 +286,14 @@ else
+ fi
+ AM_CONDITIONAL([DEBUG_RELEASE], [test "x$debug_release" = "xyes"])
+ 
++AC_ARG_VAR(RUST_TARGET, [Set rust target (default=$host)])
++if test "x$RUST_TARGET" == x; then
++	RUST_TARGET=$host
++fi
++
+ AM_CONDITIONAL(CROSS_COMPILING, test $cross_compiling = yes)
+ if test "x$cross_compiling" = "xyes" ; then
+-	RUST_TARGET_SUBDIR="$host/$RUST_TARGET_SUBDIR"
++	RUST_TARGET_SUBDIR="$RUST_TARGET/$RUST_TARGET_SUBDIR"
+ fi
+ AC_SUBST([RUST_TARGET_SUBDIR])
+ 
+-- 
+2.14.1
+
diff --git a/package/librsvg/Config.in b/package/librsvg/Config.in
index ffb0287dbd..45919c7d51 100644
--- a/package/librsvg/Config.in
+++ b/package/librsvg/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBRSVG
 	bool "librsvg"
+	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
@@ -8,6 +9,7 @@ config BR2_PACKAGE_LIBRSVG
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PNG
 	select BR2_PACKAGE_GDK_PIXBUF
+	select BR2_PACKAGE_HOST_CARGO
 	select BR2_PACKAGE_LIBCROCO
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBXML2
@@ -19,6 +21,7 @@ config BR2_PACKAGE_LIBRSVG
 	  https://wiki.gnome.org/Projects/LibRsvg
 
 comment "librsvg needs a toolchain w/ wchar, threads, C++"
+	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/librsvg/librsvg.hash b/package/librsvg/librsvg.hash
index 6f4b07423a..dce918d0ce 100644
--- a/package/librsvg/librsvg.hash
+++ b/package/librsvg/librsvg.hash
@@ -1,2 +1,5 @@
-# From http://ftp.gnome.org/pub/gnome/sources/librsvg/2.40/librsvg-2.40.20.sha256sum
-sha256	cff4dd3c3b78bfe99d8fcfad3b8ba1eee3289a0823c0e118d78106be6b84c92b	librsvg-2.40.20.tar.xz
+# From http://ftp.gnome.org/pub/gnome/sources/librsvg/2.42/librsvg-2.42.5.sha256sum
+sha256	d4dd51a492a2022c07dec385e22947190fe70410928c471934ff3399f20935ec	librsvg-2.42.5.tar.xz
+
+# Hash for license file:
+sha256	d7bf9d064ac3e5840f9dd02422b7eeec4f1fd03f37fadbd043602be5e882304f	COPYING.LIB
diff --git a/package/librsvg/librsvg.mk b/package/librsvg/librsvg.mk
index 4f563ce6db..037e1fbc14 100644
--- a/package/librsvg/librsvg.mk
+++ b/package/librsvg/librsvg.mk
@@ -4,18 +4,22 @@
 #
 ################################################################################
 
-LIBRSVG_VERSION_MAJOR = 2.40
-LIBRSVG_VERSION = $(LIBRSVG_VERSION_MAJOR).20
+LIBRSVG_VERSION_MAJOR = 2.42
+LIBRSVG_VERSION = $(LIBRSVG_VERSION_MAJOR).5
 LIBRSVG_SITE = http://ftp.gnome.org/pub/gnome/sources/librsvg/$(LIBRSVG_VERSION_MAJOR)
 LIBRSVG_SOURCE = librsvg-$(LIBRSVG_VERSION).tar.xz
 LIBRSVG_INSTALL_STAGING = YES
 LIBRSVG_CONF_OPTS = --disable-pixbuf-loader --disable-tools --enable-introspection=no
 HOST_LIBRSVG_CONF_OPTS = --enable-introspection=no
-LIBRSVG_DEPENDENCIES = cairo host-gdk-pixbuf gdk-pixbuf libcroco libglib2 libxml2 pango \
+LIBRSVG_DEPENDENCIES = cairo host-cargo host-gdk-pixbuf gdk-pixbuf libcroco libglib2 libxml2 pango \
 	$(if $(BR2_PACKAGE_LIBGTK3),libgtk3)
-HOST_LIBRSVG_DEPENDENCIES = host-cairo host-gdk-pixbuf host-libcroco host-libglib2 host-libxml2 host-pango
+HOST_LIBRSVG_DEPENDENCIES = host-cairo host-cargo host-gdk-pixbuf host-libcroco host-libglib2 host-libxml2 host-pango
 LIBRSVG_LICENSE = LGPL-2.0+
 LIBRSVG_LICENSE_FILES = COPYING.LIB
 
+# We're patching configure.ac
+LIBRSVG_AUTORECONF = YES
+LIBRSVG_CONF_ENV = RUST_TARGET=$(RUSTC_TARGET_NAME)
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5
  2018-06-06 20:25 ` [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
@ 2018-06-07  2:39   ` Baruch Siach
  2018-06-07  5:58   ` Thomas Petazzoni
  1 sibling, 0 replies; 7+ messages in thread
From: Baruch Siach @ 2018-06-07  2:39 UTC (permalink / raw)
  To: buildroot

Hi Fabrice,

On Wed, Jun 06, 2018 at 10:25:01PM +0200, Fabrice Fontaine wrote:
> - Add a dependency to host-cargo
> - Add a patch to set RUST_TARGET
> - Add a dependency to BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
> - Forward this dependency to efl svg and enlightment
> - Add hash for license file
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/efl/Config.in                              |  1 +
>  package/enlightenment/Config.in                    |  2 +
>  .../librsvg/0001-Add-RUST_TARGET-variable.patch    | 57 ++++++++++++++++++++++
>  package/librsvg/Config.in                          |  3 ++
>  package/librsvg/librsvg.hash                       |  7 ++-
>  package/librsvg/librsvg.mk                         | 12 +++--
>  6 files changed, 76 insertions(+), 6 deletions(-)
>  create mode 100644 package/librsvg/0001-Add-RUST_TARGET-variable.patch
> 
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index cfb803c6df..b9b285d8da 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -289,6 +289,7 @@ config BR2_PACKAGE_EFL_LIBRAW
>  
>  config BR2_PACKAGE_EFL_SVG
>  	bool "SVG loader"
> +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # librsvg
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # librsvg -> pango -> harfbuzz
>  	select BR2_PACKAGE_LIBRSVG
>  	select BR2_PACKAGE_CAIRO
> diff --git a/package/enlightenment/Config.in b/package/enlightenment/Config.in
> index d1dee25f86..de194c7b37 100644
> --- a/package/enlightenment/Config.in
> +++ b/package/enlightenment/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_ENLIGHTENMENT
>  	bool "enlightenment"
> +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # efl svg
>  	# libevas-generic-loaders-svg -> librsvg -> glib2 / pango
>  	depends on BR2_USE_WCHAR
>  	depends on BR2_INSTALL_LIBSTDCPP
> @@ -29,6 +30,7 @@ config BR2_PACKAGE_ENLIGHTENMENT
>  	  http://www.enlightenment.org/
>  
>  comment "enlightenment needs udev /dev management and a toolchain w/ wchar, C++, threads"
> +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_EFL && BR2_PACKAGE_XORG7 && BR2_USE_MMU
>  	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
>  		!BR2_PACKAGE_HAS_UDEV

BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_RSVG and 
BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RSVG also select BR2_PACKAGE_LIBRSVG, so 
they need that dependency.

[snip]

> diff --git a/package/librsvg/Config.in b/package/librsvg/Config.in
> index ffb0287dbd..45919c7d51 100644
> --- a/package/librsvg/Config.in
> +++ b/package/librsvg/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_LIBRSVG
>  	bool "librsvg"
> +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
>  	depends on BR2_USE_WCHAR # glib2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
>  	depends on BR2_USE_MMU # glib2
> @@ -8,6 +9,7 @@ config BR2_PACKAGE_LIBRSVG
>  	select BR2_PACKAGE_CAIRO
>  	select BR2_PACKAGE_CAIRO_PNG
>  	select BR2_PACKAGE_GDK_PIXBUF
> +	select BR2_PACKAGE_HOST_CARGO

This is not needed for host packages. Listing host-cargo in <PKG>_DEPENDENCIES 
should be enough.

>  	select BR2_PACKAGE_LIBCROCO
>  	select BR2_PACKAGE_LIBGLIB2
>  	select BR2_PACKAGE_LIBXML2
> @@ -19,6 +21,7 @@ config BR2_PACKAGE_LIBRSVG
>  	  https://wiki.gnome.org/Projects/LibRsvg
>  
>  comment "librsvg needs a toolchain w/ wchar, threads, C++"
> +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
>  	depends on BR2_USE_MMU
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5
  2018-06-06 20:25 ` [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
  2018-06-07  2:39   ` Baruch Siach
@ 2018-06-07  5:58   ` Thomas Petazzoni
  2018-06-07 17:26     ` Fabrice Fontaine
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2018-06-07  5:58 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed,  6 Jun 2018 22:25:01 +0200, Fabrice Fontaine wrote:
> - Add a dependency to host-cargo
> - Add a patch to set RUST_TARGET
> - Add a dependency to BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
> - Forward this dependency to efl svg and enlightment
> - Add hash for license file
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

As I was surprised by the new rust dependency, I looked at
https://github.com/GNOME/librsvg/blob/master/COMPILING.md. Indeed, Rust
appears to be necessary.

But the other thing that came up from this reading is:

Mandatory dependencies
[...]
GObject-Introspection 0.10.8

But we don't have gobject-introspection in Buildroot, the package for
that is pending review, and it's a complicated one. How is it possible
that you built librsvg without it ? Is the documentation incorrect and
in fact it's an optional dependency ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 1/2] host-cargo: select host-rustc
  2018-06-06 20:25 [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Fabrice Fontaine
  2018-06-06 20:25 ` [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
@ 2018-06-07 16:02 ` Thomas Petazzoni
  2018-06-07 17:25   ` Fabrice Fontaine
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2018-06-07 16:02 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed,  6 Jun 2018 22:25:00 +0200, Fabrice Fontaine wrote:
> Buildroot documentation specifies that cargo-based package should only
> depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS and selects
> BR2_PACKAGE_HOST_CARGO but this does not work as host-cargo depends on
> BR2_PACKAGE_HAS_HOST_RUSTC which is selected only when host-rustc is
> selected.

What "does not work" exactly ?

Yes, you end up with host-rust being built as a dependency of
host-cargo, while BR2_PACKAGE_HOST_RUST is not enabled.

But for host packages, we currently don't enforce that their
Config.in.host option is enabled when the package is built.

So, which problem have you encountered ?

I agree that your patch makes sense (it's better to have the
Config.in.host option enabled when the corresponding host package is
going to be built), but I don't see where the *problem* is, so I'd like
to understand before applying.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 1/2] host-cargo: select host-rustc
  2018-06-07 16:02 ` [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Thomas Petazzoni
@ 2018-06-07 17:25   ` Fabrice Fontaine
  0 siblings, 0 replies; 7+ messages in thread
From: Fabrice Fontaine @ 2018-06-07 17:25 UTC (permalink / raw)
  To: buildroot

Dear Thomas,

2018-06-07 18:02 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>:

> Hello,
>
> On Wed,  6 Jun 2018 22:25:00 +0200, Fabrice Fontaine wrote:
> > Buildroot documentation specifies that cargo-based package should only
> > depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS and selects
> > BR2_PACKAGE_HOST_CARGO but this does not work as host-cargo depends on
> > BR2_PACKAGE_HAS_HOST_RUSTC which is selected only when host-rustc is
> > selected.
>
> What "does not work" exactly ?
>
> Yes, you end up with host-rust being built as a dependency of
> host-cargo, while BR2_PACKAGE_HOST_RUST is not enabled.
>
> But for host packages, we currently don't enforce that their
> Config.in.host option is enabled when the package is built.
>
> So, which problem have you encountered ?
>
I got the following warning when I selected librsvg without this patch
because I added a "select BR2_PACKAGE_HOST_CARGO" in librsvg/Config.in as
specified in
https://buildroot.org/downloads/manual/manual.html#_integration_of_cargo_based_packages
:
warning: (BR2_PACKAGE_LIBRSVG) selects BR2_PACKAGE_HOST_CARGO which has
unmet direct dependencies (BR2_PACKAGE_HAS_HOST_RUSTC)

But thanks to Baruch review of my second patch, I understand that it is not
needed to add this select.
However, I think that documentation should be updated to remove this
select, I will send a patch to update
./docs/manual/adding-packages-cargo.txt if it's ok with you.

>
> I agree that your patch makes sense (it's better to have the
> Config.in.host option enabled when the corresponding host package is
> going to be built), but I don't see where the *problem* is, so I'd like
> to understand before applying.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180607/0807ba99/attachment.html>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5
  2018-06-07  5:58   ` Thomas Petazzoni
@ 2018-06-07 17:26     ` Fabrice Fontaine
  0 siblings, 0 replies; 7+ messages in thread
From: Fabrice Fontaine @ 2018-06-07 17:26 UTC (permalink / raw)
  To: buildroot

Dear Thomas,

2018-06-07 7:58 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>:

> Hello,
>
> On Wed,  6 Jun 2018 22:25:01 +0200, Fabrice Fontaine wrote:
> > - Add a dependency to host-cargo
> > - Add a patch to set RUST_TARGET
> > - Add a dependency to BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
> > - Forward this dependency to efl svg and enlightment
> > - Add hash for license file
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> As I was surprised by the new rust dependency, I looked at
> https://github.com/GNOME/librsvg/blob/master/COMPILING.md. Indeed, Rust
> appears to be necessary.
>
Yes, rust is now needed and 2.40.x won't be maintained anymore: see
https://gitlab.gnome.org/GNOME/librsvg/merge_requests/71#note_231260.

>
> But the other thing that came up from this reading is:
>
> Mandatory dependencies
> [...]
> GObject-Introspection 0.10.8
>
> But we don't have gobject-introspection in Buildroot, the package for
> that is pending review, and it's a complicated one. How is it possible
> that you built librsvg without it ? Is the documentation incorrect and
> in fact it's an optional dependency ?
>
The documentation is incorrect.
configure.ac makes a call to GOBJECT_INTROSPECTION_CHECK and not
GOBJECT_INTROSPECTION_REQUIRE.
So except, if we set --enable-introspection, build won't fail without
gobject-introspection.
gobject-instropection is only needed for vala bindings, see:
https://github.com/GNOME/librsvg/blob/f17210327623f59d4b1fbe
c538850b145f2fc069/m4/vapigen.m4.
This is the same behavior in 2.4.20.
Nevertheless, I will send you a v2 to take into account Baruch's review.

>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180607/5f977855/attachment.html>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-06-07 17:26 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-06 20:25 [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Fabrice Fontaine
2018-06-06 20:25 ` [Buildroot] [PATCH 2/2] librsvg: bump to version 2.42.5 Fabrice Fontaine
2018-06-07  2:39   ` Baruch Siach
2018-06-07  5:58   ` Thomas Petazzoni
2018-06-07 17:26     ` Fabrice Fontaine
2018-06-07 16:02 ` [Buildroot] [PATCH 1/2] host-cargo: select host-rustc Thomas Petazzoni
2018-06-07 17:25   ` Fabrice Fontaine

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox