[Buildroot] [PATCH] package/qemu: enable usb passthrough on host variant

[Buildroot] [PATCH] package/qemu: enable usb passthrough on host variant

[Angelo Compagnucci]

Usb passthrough is a useful feature while using qemu for debugging
purpose.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
 package/qemu/qemu.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 1d3759a850..4cf1c60030 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -264,6 +264,11 @@ else
 HOST_QEMU_OPTS += --disable-virtfs
 endif
 
+ifeq ($(BR2_PACKAGE_LIBUSB),y)
+HOST_QEMU_OPTS += --enable-libusb
+HOST_QEMU_DEPENDENCIES += host-libusb
+endif
+
 # Override CPP, as it expects to be able to call it like it'd
 # call the compiler.
 define HOST_QEMU_CONFIGURE_CMDS
-- 
2.17.1

[Buildroot] [PATCH] package/qemu: enable usb passthrough on host variant

[Thomas Petazzoni]

On Thu, 24 Oct 2019 22:28:20 +0200
Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote:

> Usb passthrough is a useful feature while using qemu for debugging
> purpose.
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
>  package/qemu/qemu.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 1d3759a850..4cf1c60030 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -264,6 +264,11 @@ else
>  HOST_QEMU_OPTS += --disable-virtfs
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBUSB),y)

So, if the target libusb package is enabled...

> +HOST_QEMU_OPTS += --enable-libusb
> +HOST_QEMU_DEPENDENCIES += host-libusb

... you assume the user wants libusb support in host-qemu.

Sorry, but this is not good. Add an option in
package/qemu/Config.in.host to enable USB passthrough, and use that in
qemu.mk.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/qemu: enable usb passthrough on host variant

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 >> +ifeq ($(BR2_PACKAGE_LIBUSB),y)

 > So, if the target libusb package is enabled...

 >> +HOST_QEMU_OPTS += --enable-libusb
 >> +HOST_QEMU_DEPENDENCIES += host-libusb

 > ... you assume the user wants libusb support in host-qemu.

 > Sorry, but this is not good. Add an option in
 > package/qemu/Config.in.host to enable USB passthrough, and use that in
 > qemu.mk.

And pass --disable-libusb (if such option exists) in the else clause.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] package/qemu: enable usb passthrough on host variant

[Arnout Vandecappelle]

On 24/10/2019 23:30, Peter Korsgaard wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> 
>  >> +ifeq ($(BR2_PACKAGE_LIBUSB),y)
> 
>  > So, if the target libusb package is enabled...
> 
>  >> +HOST_QEMU_OPTS += --enable-libusb
>  >> +HOST_QEMU_DEPENDENCIES += host-libusb
> 
>  > ... you assume the user wants libusb support in host-qemu.
> 
>  > Sorry, but this is not good. Add an option in
>  > package/qemu/Config.in.host to enable USB passthrough, and use that in
>  > qemu.mk.

 host-libusb takes 1 second to build (*). Is it really worth to make an option
for it?

 Regards,
 Arnout

(*) Yes, I'm exaggerating :-)

> 
> And pass --disable-libusb (if such option exists) in the else clause.
>