[Buildroot] [PATCH] package/cdrkit: fix build with GCC 10

[Buildroot] [PATCH] package/cdrkit: fix build with GCC 10

[Urja Rannikko]

This patch adds a missing extern on the outfile
variable in genisoimage.h.

Signed-off-by: Urja Rannikko <urjaman@gmail.com>
---
Note: I would like to see this applied to the LTS 2020.02
branch too, since it fixes building host-cdrkit for ISO9660
generation with a host GCC 10.

 .../cdrkit/0003-genisoimage-outfile-extern.patch    | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patch

diff --git a/package/cdrkit/0003-genisoimage-outfile-extern.patch b/package/cdrkit/0003-genisoimage-outfile-extern.patch
new file mode 100644
index 0000000000..5a9f0363c9
--- /dev/null
+++ b/package/cdrkit/0003-genisoimage-outfile-extern.patch
@@ -0,0 +1,13 @@
+diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
+index bbedfb0..82c859b 100644
+--- a/genisoimage/genisoimage.h
++++ b/genisoimage/genisoimage.h
+@@ -376,7 +376,7 @@ extern int	use_fileversion;
+ extern int	split_SL_component;
+ extern int	split_SL_field;
+ extern char	*trans_tbl;
+-char		*outfile;
++extern char	*outfile;
+ 
+ #define	JMAX		64	/* maximum Joliet file name length (spec) */
+ #define	JLONGMAX	103	/* out of spec Joliet file name length */
-- 
2.26.2

[Buildroot] [PATCH] package/cdrkit: fix build with GCC 10

[Heiko Thiery]

Hi Urja,

Am Do., 25. Juni 2020 um 02:58 Uhr schrieb Urja Rannikko <urjaman@gmail.com>:
>
> This patch adds a missing extern on the outfile
> variable in genisoimage.h.
>
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>

Tested-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
> Note: I would like to see this applied to the LTS 2020.02
> branch too, since it fixes building host-cdrkit for ISO9660
> generation with a host GCC 10.
>
>  .../cdrkit/0003-genisoimage-outfile-extern.patch    | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patch
>
> diff --git a/package/cdrkit/0003-genisoimage-outfile-extern.patch b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> new file mode 100644
> index 0000000000..5a9f0363c9
> --- /dev/null
> +++ b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> @@ -0,0 +1,13 @@
> +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
> +index bbedfb0..82c859b 100644
> +--- a/genisoimage/genisoimage.h
> ++++ b/genisoimage/genisoimage.h
> +@@ -376,7 +376,7 @@ extern int use_fileversion;
> + extern int    split_SL_component;
> + extern int    split_SL_field;
> + extern char   *trans_tbl;
> +-char          *outfile;
> ++extern char   *outfile;
> +
> + #define       JMAX            64      /* maximum Joliet file name length (spec) */
> + #define       JLONGMAX        103     /* out of spec Joliet file name length */
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH] package/cdrkit: fix build with GCC 10

[Thomas Petazzoni]

Hello Urja,

Thanks for your contribution!

On Thu, 25 Jun 2020 03:58:36 +0300
Urja Rannikko <urjaman@gmail.com> wrote:

> This patch adds a missing extern on the outfile
> variable in genisoimage.h.
> 
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>
> ---
> Note: I would like to see this applied to the LTS 2020.02
> branch too, since it fixes building host-cdrkit for ISO9660
> generation with a host GCC 10.
> 
>  .../cdrkit/0003-genisoimage-outfile-extern.patch    | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patch
> 
> diff --git a/package/cdrkit/0003-genisoimage-outfile-extern.patch b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> new file mode 100644
> index 0000000000..5a9f0363c9
> --- /dev/null
> +++ b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> @@ -0,0 +1,13 @@
> +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
> +index bbedfb0..82c859b 100644
> +--- a/genisoimage/genisoimage.h
> ++++ b/genisoimage/genisoimage.h

Thanks a lot for your patch! However, we need the cdrkit patch to have
a proper commit title, commit description and Signed-off-by.

See
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for more details.

Could you adjust your patch accordingly ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2] package/cdrkit: fix build with GCC 10

[Urja Rannikko]

This patch adds a missing extern on the outfile
variable in genisoimage.h.

Signed-off-by: Urja Rannikko <urjaman@gmail.com>
---
Note: I would like to see this applied to the LTS 2020.02
branch too, since it fixes building host-cdrkit for ISO9660
generation with a host GCC 10.

v2: Make the patch a fully fledged commit with a sign-off and
way more description than is necessary for a single "extern".

 ...ar-outfile-declaration-to-fix-build-.patch | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch

diff --git a/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
new file mode 100644
index 0000000000..30f4c8d01d
--- /dev/null
+++ b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
@@ -0,0 +1,30 @@
+From eabcc8a6e39dc3c28faee3e04aa56cc65a38d65a Mon Sep 17 00:00:00 2001
+From: Urja Rannikko <urjaman@gmail.com>
+Date: Sun, 19 Jul 2020 20:28:27 +0300
+Subject: [PATCH] Add extern to char* outfile declaration to fix build with gcc
+ 10
+
+Without this linking fails with a rather long spew of
+"multiple definition of `outfile'".
+
+Signed-off-by: Urja Rannikko <urjaman@gmail.com>
+---
+ genisoimage/genisoimage.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
+index bbedfb0..82c859b 100644
+--- a/genisoimage/genisoimage.h
++++ b/genisoimage/genisoimage.h
+@@ -376,7 +376,7 @@ extern int	use_fileversion;
+ extern int	split_SL_component;
+ extern int	split_SL_field;
+ extern char	*trans_tbl;
+-char		*outfile;
++extern char	*outfile;
+ 
+ #define	JMAX		64	/* maximum Joliet file name length (spec) */
+ #define	JLONGMAX	103	/* out of spec Joliet file name length */
+-- 
+2.27.0
+
-- 
2.27.0

[Buildroot] [PATCH v2] package/cdrkit: fix build with GCC 10

[Yann E. MORIN]

Urja, All,

On 2020-07-19 20:42 +0300, Urja Rannikko spake thusly:
> This patch adds a missing extern on the outfile
> variable in genisoimage.h.
> 
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>

Applied to master, thanks.

> ---
> Note: I would like to see this applied to the LTS 2020.02
> branch too, since it fixes building host-cdrkit for ISO9660
> generation with a host GCC 10.

+Peter in cc.

Regards,
Yann E. MORIN.

> v2: Make the patch a fully fledged commit with a sign-off and
> way more description than is necessary for a single "extern".
> 
>  ...ar-outfile-declaration-to-fix-build-.patch | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
> 
> diff --git a/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
> new file mode 100644
> index 0000000000..30f4c8d01d
> --- /dev/null
> +++ b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
> @@ -0,0 +1,30 @@
> +From eabcc8a6e39dc3c28faee3e04aa56cc65a38d65a Mon Sep 17 00:00:00 2001
> +From: Urja Rannikko <urjaman@gmail.com>
> +Date: Sun, 19 Jul 2020 20:28:27 +0300
> +Subject: [PATCH] Add extern to char* outfile declaration to fix build with gcc
> + 10
> +
> +Without this linking fails with a rather long spew of
> +"multiple definition of `outfile'".
> +
> +Signed-off-by: Urja Rannikko <urjaman@gmail.com>
> +---
> + genisoimage/genisoimage.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
> +index bbedfb0..82c859b 100644
> +--- a/genisoimage/genisoimage.h
> ++++ b/genisoimage/genisoimage.h
> +@@ -376,7 +376,7 @@ extern int	use_fileversion;
> + extern int	split_SL_component;
> + extern int	split_SL_field;
> + extern char	*trans_tbl;
> +-char		*outfile;
> ++extern char	*outfile;
> + 
> + #define	JMAX		64	/* maximum Joliet file name length (spec) */
> + #define	JLONGMAX	103	/* out of spec Joliet file name length */
> +-- 
> +2.27.0
> +
> -- 
> 2.27.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v2] package/cdrkit: fix build with GCC 10

[Peter Korsgaard]

>>>>> "Urja" == Urja Rannikko <urjaman@gmail.com> writes:

 > This patch adds a missing extern on the outfile
 > variable in genisoimage.h.

 > Signed-off-by: Urja Rannikko <urjaman@gmail.com>
 > ---
 > Note: I would like to see this applied to the LTS 2020.02
 > branch too, since it fixes building host-cdrkit for ISO9660
 > generation with a host GCC 10.

 > v2: Make the patch a fully fledged commit with a sign-off and
 > way more description than is necessary for a single "extern".

Committed to 2020.02.x and 2020.05.x, thanks.

-- 
Bye, Peter Korsgaard