* [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10
@ 2020-06-25 0:58 Urja Rannikko
2020-07-13 18:49 ` Heiko Thiery
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Urja Rannikko @ 2020-06-25 0:58 UTC (permalink / raw)
To: buildroot
This patch adds a missing extern on the outfile
variable in genisoimage.h.
Signed-off-by: Urja Rannikko <urjaman@gmail.com>
---
Note: I would like to see this applied to the LTS 2020.02
branch too, since it fixes building host-cdrkit for ISO9660
generation with a host GCC 10.
.../cdrkit/0003-genisoimage-outfile-extern.patch | 13 +++++++++++++
1 file changed, 13 insertions(+)
create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patch
diff --git a/package/cdrkit/0003-genisoimage-outfile-extern.patch b/package/cdrkit/0003-genisoimage-outfile-extern.patch
new file mode 100644
index 0000000000..5a9f0363c9
--- /dev/null
+++ b/package/cdrkit/0003-genisoimage-outfile-extern.patch
@@ -0,0 +1,13 @@
+diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
+index bbedfb0..82c859b 100644
+--- a/genisoimage/genisoimage.h
++++ b/genisoimage/genisoimage.h
+@@ -376,7 +376,7 @@ extern int use_fileversion;
+ extern int split_SL_component;
+ extern int split_SL_field;
+ extern char *trans_tbl;
+-char *outfile;
++extern char *outfile;
+
+ #define JMAX 64 /* maximum Joliet file name length (spec) */
+ #define JLONGMAX 103 /* out of spec Joliet file name length */
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10
2020-06-25 0:58 [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10 Urja Rannikko
@ 2020-07-13 18:49 ` Heiko Thiery
2020-07-13 21:34 ` Thomas Petazzoni
2020-07-19 17:42 ` [Buildroot] [PATCH v2] " Urja Rannikko
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Thiery @ 2020-07-13 18:49 UTC (permalink / raw)
To: buildroot
Hi Urja,
Am Do., 25. Juni 2020 um 02:58 Uhr schrieb Urja Rannikko <urjaman@gmail.com>:
>
> This patch adds a missing extern on the outfile
> variable in genisoimage.h.
>
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> Note: I would like to see this applied to the LTS 2020.02
> branch too, since it fixes building host-cdrkit for ISO9660
> generation with a host GCC 10.
>
> .../cdrkit/0003-genisoimage-outfile-extern.patch | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
> create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patch
>
> diff --git a/package/cdrkit/0003-genisoimage-outfile-extern.patch b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> new file mode 100644
> index 0000000000..5a9f0363c9
> --- /dev/null
> +++ b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> @@ -0,0 +1,13 @@
> +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
> +index bbedfb0..82c859b 100644
> +--- a/genisoimage/genisoimage.h
> ++++ b/genisoimage/genisoimage.h
> +@@ -376,7 +376,7 @@ extern int use_fileversion;
> + extern int split_SL_component;
> + extern int split_SL_field;
> + extern char *trans_tbl;
> +-char *outfile;
> ++extern char *outfile;
> +
> + #define JMAX 64 /* maximum Joliet file name length (spec) */
> + #define JLONGMAX 103 /* out of spec Joliet file name length */
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10
2020-06-25 0:58 [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10 Urja Rannikko
2020-07-13 18:49 ` Heiko Thiery
@ 2020-07-13 21:34 ` Thomas Petazzoni
2020-07-19 17:42 ` [Buildroot] [PATCH v2] " Urja Rannikko
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2020-07-13 21:34 UTC (permalink / raw)
To: buildroot
Hello Urja,
Thanks for your contribution!
On Thu, 25 Jun 2020 03:58:36 +0300
Urja Rannikko <urjaman@gmail.com> wrote:
> This patch adds a missing extern on the outfile
> variable in genisoimage.h.
>
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>
> ---
> Note: I would like to see this applied to the LTS 2020.02
> branch too, since it fixes building host-cdrkit for ISO9660
> generation with a host GCC 10.
>
> .../cdrkit/0003-genisoimage-outfile-extern.patch | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
> create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patch
>
> diff --git a/package/cdrkit/0003-genisoimage-outfile-extern.patch b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> new file mode 100644
> index 0000000000..5a9f0363c9
> --- /dev/null
> +++ b/package/cdrkit/0003-genisoimage-outfile-extern.patch
> @@ -0,0 +1,13 @@
> +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
> +index bbedfb0..82c859b 100644
> +--- a/genisoimage/genisoimage.h
> ++++ b/genisoimage/genisoimage.h
Thanks a lot for your patch! However, we need the cdrkit patch to have
a proper commit title, commit description and Signed-off-by.
See
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for more details.
Could you adjust your patch accordingly ?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] package/cdrkit: fix build with GCC 10
2020-06-25 0:58 [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10 Urja Rannikko
2020-07-13 18:49 ` Heiko Thiery
2020-07-13 21:34 ` Thomas Petazzoni
@ 2020-07-19 17:42 ` Urja Rannikko
2020-07-19 19:42 ` Yann E. MORIN
2020-07-24 11:40 ` Peter Korsgaard
2 siblings, 2 replies; 6+ messages in thread
From: Urja Rannikko @ 2020-07-19 17:42 UTC (permalink / raw)
To: buildroot
This patch adds a missing extern on the outfile
variable in genisoimage.h.
Signed-off-by: Urja Rannikko <urjaman@gmail.com>
---
Note: I would like to see this applied to the LTS 2020.02
branch too, since it fixes building host-cdrkit for ISO9660
generation with a host GCC 10.
v2: Make the patch a fully fledged commit with a sign-off and
way more description than is necessary for a single "extern".
...ar-outfile-declaration-to-fix-build-.patch | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
diff --git a/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
new file mode 100644
index 0000000000..30f4c8d01d
--- /dev/null
+++ b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
@@ -0,0 +1,30 @@
+From eabcc8a6e39dc3c28faee3e04aa56cc65a38d65a Mon Sep 17 00:00:00 2001
+From: Urja Rannikko <urjaman@gmail.com>
+Date: Sun, 19 Jul 2020 20:28:27 +0300
+Subject: [PATCH] Add extern to char* outfile declaration to fix build with gcc
+ 10
+
+Without this linking fails with a rather long spew of
+"multiple definition of `outfile'".
+
+Signed-off-by: Urja Rannikko <urjaman@gmail.com>
+---
+ genisoimage/genisoimage.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
+index bbedfb0..82c859b 100644
+--- a/genisoimage/genisoimage.h
++++ b/genisoimage/genisoimage.h
+@@ -376,7 +376,7 @@ extern int use_fileversion;
+ extern int split_SL_component;
+ extern int split_SL_field;
+ extern char *trans_tbl;
+-char *outfile;
++extern char *outfile;
+
+ #define JMAX 64 /* maximum Joliet file name length (spec) */
+ #define JLONGMAX 103 /* out of spec Joliet file name length */
+--
+2.27.0
+
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] package/cdrkit: fix build with GCC 10
2020-07-19 17:42 ` [Buildroot] [PATCH v2] " Urja Rannikko
@ 2020-07-19 19:42 ` Yann E. MORIN
2020-07-24 11:40 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-07-19 19:42 UTC (permalink / raw)
To: buildroot
Urja, All,
On 2020-07-19 20:42 +0300, Urja Rannikko spake thusly:
> This patch adds a missing extern on the outfile
> variable in genisoimage.h.
>
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>
Applied to master, thanks.
> ---
> Note: I would like to see this applied to the LTS 2020.02
> branch too, since it fixes building host-cdrkit for ISO9660
> generation with a host GCC 10.
+Peter in cc.
Regards,
Yann E. MORIN.
> v2: Make the patch a fully fledged commit with a sign-off and
> way more description than is necessary for a single "extern".
>
> ...ar-outfile-declaration-to-fix-build-.patch | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
>
> diff --git a/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
> new file mode 100644
> index 0000000000..30f4c8d01d
> --- /dev/null
> +++ b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
> @@ -0,0 +1,30 @@
> +From eabcc8a6e39dc3c28faee3e04aa56cc65a38d65a Mon Sep 17 00:00:00 2001
> +From: Urja Rannikko <urjaman@gmail.com>
> +Date: Sun, 19 Jul 2020 20:28:27 +0300
> +Subject: [PATCH] Add extern to char* outfile declaration to fix build with gcc
> + 10
> +
> +Without this linking fails with a rather long spew of
> +"multiple definition of `outfile'".
> +
> +Signed-off-by: Urja Rannikko <urjaman@gmail.com>
> +---
> + genisoimage/genisoimage.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
> +index bbedfb0..82c859b 100644
> +--- a/genisoimage/genisoimage.h
> ++++ b/genisoimage/genisoimage.h
> +@@ -376,7 +376,7 @@ extern int use_fileversion;
> + extern int split_SL_component;
> + extern int split_SL_field;
> + extern char *trans_tbl;
> +-char *outfile;
> ++extern char *outfile;
> +
> + #define JMAX 64 /* maximum Joliet file name length (spec) */
> + #define JLONGMAX 103 /* out of spec Joliet file name length */
> +--
> +2.27.0
> +
> --
> 2.27.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] package/cdrkit: fix build with GCC 10
2020-07-19 17:42 ` [Buildroot] [PATCH v2] " Urja Rannikko
2020-07-19 19:42 ` Yann E. MORIN
@ 2020-07-24 11:40 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-07-24 11:40 UTC (permalink / raw)
To: buildroot
>>>>> "Urja" == Urja Rannikko <urjaman@gmail.com> writes:
> This patch adds a missing extern on the outfile
> variable in genisoimage.h.
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>
> ---
> Note: I would like to see this applied to the LTS 2020.02
> branch too, since it fixes building host-cdrkit for ISO9660
> generation with a host GCC 10.
> v2: Make the patch a fully fledged commit with a sign-off and
> way more description than is necessary for a single "extern".
Committed to 2020.02.x and 2020.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-24 11:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-25 0:58 [Buildroot] [PATCH] package/cdrkit: fix build with GCC 10 Urja Rannikko
2020-07-13 18:49 ` Heiko Thiery
2020-07-13 21:34 ` Thomas Petazzoni
2020-07-19 17:42 ` [Buildroot] [PATCH v2] " Urja Rannikko
2020-07-19 19:42 ` Yann E. MORIN
2020-07-24 11:40 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox