[Buildroot] [PATCH 1/1] package/wpewebkit: add optional systemd dependency

[Buildroot] [PATCH 1/1] package/wpewebkit: add optional systemd dependency

[Adrian Perez de Castro]

WPE WebKit 2.30.0 added an USE_SYSTEMD buil option, which needs to
be set to avoid CMake from trying to use systemd unconditionally.

Based on a similar patch for package/webkitgtk by Peter Seiderer.

Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
 package/wpewebkit/wpewebkit.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
index 6233505ca7..6f83775e96 100644
--- a/package/wpewebkit/wpewebkit.mk
+++ b/package/wpewebkit/wpewebkit.mk
@@ -63,6 +63,13 @@ else
 WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
 endif
 
+ifeq ($(BR2_INIT_SYSTEMD),y)
+WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=ON
+WPEWEBKIT_DEPENDENCIES += systemd
+else
+WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=OFF
+endif
+
 # JIT is not supported for MIPS r6, but the WebKit build system does not
 # have a check for these processors. The same goes for ARMv5 and ARMv6.
 # Disable JIT forcibly here and use the CLoop interpreter instead.
-- 
2.29.2

[Buildroot] [PATCH 1/1] package/wpewebkit: add optional systemd dependency

[Peter Seiderer]

Hello Adrian,

On Tue, 10 Nov 2020 11:02:04 +0200, Adrian Perez de Castro <aperez@igalia.com> wrote:

> WPE WebKit 2.30.0 added an USE_SYSTEMD buil option, which needs to
> be set to avoid CMake from trying to use systemd unconditionally.
>
> Based on a similar patch for package/webkitgtk by Peter Seiderer.
>
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
>  package/wpewebkit/wpewebkit.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 6233505ca7..6f83775e96 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -63,6 +63,13 @@ else
>  WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
>  endif
>
> +ifeq ($(BR2_INIT_SYSTEMD),y)
> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=ON
> +WPEWEBKIT_DEPENDENCIES += systemd
> +else
> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=OFF
> +endif
> +
>  # JIT is not supported for MIPS r6, but the WebKit build system does not
>  # have a check for these processors. The same goes for ARMv5 and ARMv6.
>  # Disable JIT forcibly here and use the CLoop interpreter instead.

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Note: the status for this patch in patchwork is 'Superseded' [1] (by mistake?)...

Regards,
Peter

[1] https://patchwork.ozlabs.org/project/buildroot/patch/20201110090204.1581432-1-aperez at igalia.com/

[Buildroot] [PATCH 1/1] package/wpewebkit: add optional systemd dependency

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Hello Adrian,
 > On Tue, 10 Nov 2020 11:02:04 +0200, Adrian Perez de Castro <aperez@igalia.com> wrote:

 >> WPE WebKit 2.30.0 added an USE_SYSTEMD buil option, which needs to
 >> be set to avoid CMake from trying to use systemd unconditionally.
 >> 
 >> Based on a similar patch for package/webkitgtk by Peter Seiderer.
 >> 
 >> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
 >> ---
 >> package/wpewebkit/wpewebkit.mk | 7 +++++++
 >> 1 file changed, 7 insertions(+)
 >> 
 >> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
 >> index 6233505ca7..6f83775e96 100644
 >> --- a/package/wpewebkit/wpewebkit.mk
 >> +++ b/package/wpewebkit/wpewebkit.mk
 >> @@ -63,6 +63,13 @@ else
 >> WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
 >> endif
 >> 
 >> +ifeq ($(BR2_INIT_SYSTEMD),y)
 >> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=ON
 >> +WPEWEBKIT_DEPENDENCIES += systemd
 >> +else
 >> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=OFF
 >> +endif
 >> +
 >> # JIT is not supported for MIPS r6, but the WebKit build system does not
 >> # have a check for these processors. The same goes for ARMv5 and ARMv6.
 >> # Disable JIT forcibly here and use the CLoop interpreter instead.

 > Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Committed, thanks.

 > Note: the status for this patch in patchwork is 'Superseded' [1] (by mistake?)...

I got confused with webkitgtk/wpewebkit and thought it was identical to
your patch, sorry.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/wpewebkit: add optional systemd dependency

[Adrian Perez de Castro]

Hello,

On Tue, 10 Nov 2020 23:19:58 +0100 Peter Korsgaard <peter@korsgaard.com> wrote:
> >>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> 
>  > Hello Adrian,
>  > On Tue, 10 Nov 2020 11:02:04 +0200, Adrian Perez de Castro <aperez@igalia.com> wrote:
> 
>  >> WPE WebKit 2.30.0 added an USE_SYSTEMD buil option, which needs to
>  >> be set to avoid CMake from trying to use systemd unconditionally.
>  >> 
>  >> Based on a similar patch for package/webkitgtk by Peter Seiderer.
>  >> 
>  >> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
>  >> ---
>  >> package/wpewebkit/wpewebkit.mk | 7 +++++++
>  >> 1 file changed, 7 insertions(+)
>  >> 
>  >> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
>  >> index 6233505ca7..6f83775e96 100644
>  >> --- a/package/wpewebkit/wpewebkit.mk
>  >> +++ b/package/wpewebkit/wpewebkit.mk
>  >> @@ -63,6 +63,13 @@ else
>  >> WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
>  >> endif
>  >> 
>  >> +ifeq ($(BR2_INIT_SYSTEMD),y)
>  >> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=ON
>  >> +WPEWEBKIT_DEPENDENCIES += systemd
>  >> +else
>  >> +WPEWEBKIT_CONF_OPTS += -DUSE_SYSTEMD=OFF
>  >> +endif
>  >> +
>  >> # JIT is not supported for MIPS r6, but the WebKit build system does not
>  >> # have a check for these processors. The same goes for ARMv5 and ARMv6.
>  >> # Disable JIT forcibly here and use the CLoop interpreter instead.
> 
>  > Reviewed-by: Peter Seiderer <ps.report@gmx.net>
> 
> Committed, thanks.
> 
>  > Note: the status for this patch in patchwork is 'Superseded' [1] (by mistake?)...
> 
> I got confused with webkitgtk/wpewebkit and thought it was identical to
> your patch, sorry.

No worries, it could happen to anyone. I can see how it's easy to mix both
wpewebkit and webkitgtk, specially when there are patches that we need for
both ^_^

Cheers,
-Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20201111/5654b4a1/attachment.asc>