[Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR

[Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR

[Fabrice Fontaine]

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/openvpn/openvpn.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/openvpn/openvpn.mk b/package/openvpn/openvpn.mk
index 53f332534d..913235679a 100644
--- a/package/openvpn/openvpn.mk
+++ b/package/openvpn/openvpn.mk
@@ -10,6 +10,7 @@ OPENVPN_SITE = http://swupdate.openvpn.net/community/releases
 OPENVPN_DEPENDENCIES = host-pkgconf
 OPENVPN_LICENSE = GPL-2.0
 OPENVPN_LICENSE_FILES = COPYRIGHT.GPL
+OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
 OPENVPN_CONF_OPTS = \
 	--disable-unit-tests \
 	$(if $(BR2_STATIC_LIBS),--disable-plugins)
-- 
2.29.2

[Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 >  package/openvpn/openvpn.mk | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/package/openvpn/openvpn.mk b/package/openvpn/openvpn.mk
 > index 53f332534d..913235679a 100644
 > --- a/package/openvpn/openvpn.mk
 > +++ b/package/openvpn/openvpn.mk
 > @@ -10,6 +10,7 @@ OPENVPN_SITE = http://swupdate.openvpn.net/community/releases
 >  OPENVPN_DEPENDENCIES = host-pkgconf
 >  OPENVPN_LICENSE = GPL-2.0
 >  OPENVPN_LICENSE_FILES = COPYRIGHT.GPL
 > +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)

I am not sure why we do this obfuscation with the _NAME variable instead
of just "openvpn" -  But ok, a bunch of other packages do so as well.

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR

[Thomas Petazzoni]

On Sat, 09 Jan 2021 16:08:24 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

>  > +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)  
> 
> I am not sure why we do this obfuscation with the _NAME variable instead
> of just "openvpn" -  But ok, a bunch of other packages do so as well.

Yes, it was done like this in the original patch from Matt, and I kept
it as-is, but I also wasn't too sure about it. But since nobody
complained when I posted the patch, I applied it as-is.

I definitely wouldn't oppose to changing this to not use the
<pkg>_NAME variable, as it find this indirection to not be very useful.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Sat, 09 Jan 2021 16:08:24 +0100
 > Peter Korsgaard <peter@korsgaard.com> wrote:

 >> > +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)  
 >> 
 >> I am not sure why we do this obfuscation with the _NAME variable instead
 >> of just "openvpn" -  But ok, a bunch of other packages do so as well.

 > Yes, it was done like this in the original patch from Matt, and I kept
 > it as-is, but I also wasn't too sure about it. But since nobody
 > complained when I posted the patch, I applied it as-is.

 > I definitely wouldn't oppose to changing this to not use the
 > <pkg>_NAME variable, as it find this indirection to not be very useful.

Ok, good. It may make sense to default _CPE_ID_VENDOR to $($(PKG)_NAME),
which is perhaps where this comes from?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR

[Thomas Petazzoni]

On Sat, 09 Jan 2021 22:18:04 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> Ok, good. It may make sense to default _CPE_ID_VENDOR to $($(PKG)_NAME),
> which is perhaps where this comes from?

CPE_ID_VENDOR already has a default, which is:

   $(2)_CPE_ID_VENDOR = $$($(2)_RAWNAME)_project

Indeed, for a large number of packages, the CPE vendor ID follows that
<foo>_project scheme.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com