* [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
@ 2021-10-16 8:41 Fabrice Fontaine
2021-10-16 8:46 ` Peter Korsgaard
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Fabrice Fontaine @ 2021-10-16 8:41 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Add a comment when kernel is not enabled (missing since the addition of
the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/wireguard-linux-compat/Config.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/wireguard-linux-compat/Config.in b/package/wireguard-linux-compat/Config.in
index 5a323a35e5..4e8e95bdc3 100644
--- a/package/wireguard-linux-compat/Config.in
+++ b/package/wireguard-linux-compat/Config.in
@@ -21,6 +21,9 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
https://www.wireguard.com
+comment "wireguard-linux-compat needs a Linux kernel to be built"
+ depends on !BR2_LINUX_KERNEL
+
comment "wireguard-linux-compat needs a toolchain w/ headers >= 3.10"
depends on BR2_LINUX_KERNEL
depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
2021-10-16 8:41 [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency Fabrice Fontaine
@ 2021-10-16 8:46 ` Peter Korsgaard
2021-10-16 8:51 ` Fabrice Fontaine
2021-10-16 12:10 ` Yann E. MORIN
2021-10-17 7:50 ` Yann E. MORIN
2021-10-22 18:42 ` Peter Korsgaard
2 siblings, 2 replies; 7+ messages in thread
From: Peter Korsgaard @ 2021-10-16 8:46 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Add a comment when kernel is not enabled (missing since the addition of
> the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/wireguard-linux-compat/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/package/wireguard-linux-compat/Config.in b/package/wireguard-linux-compat/Config.in
> index 5a323a35e5..4e8e95bdc3 100644
> --- a/package/wireguard-linux-compat/Config.in
> +++ b/package/wireguard-linux-compat/Config.in
> @@ -21,6 +21,9 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
> https://www.wireguard.com
> +comment "wireguard-linux-compat needs a Linux kernel to be built"
> + depends on !BR2_LINUX_KERNEL
Is this really a sensible comment? I would imagine that needing a Linux
kernel is an obvious requirement for a kernel driver?
> +
> comment "wireguard-linux-compat needs a toolchain w/ headers >= 3.10"
> depends on BR2_LINUX_KERNEL
> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
> --
> 2.33.0
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
2021-10-16 8:46 ` Peter Korsgaard
@ 2021-10-16 8:51 ` Fabrice Fontaine
2021-10-16 8:58 ` Peter Korsgaard
2021-10-16 12:10 ` Yann E. MORIN
1 sibling, 1 reply; 7+ messages in thread
From: Fabrice Fontaine @ 2021-10-16 8:51 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Buildroot Mailing List
Le sam. 16 oct. 2021 à 10:46, Peter Korsgaard <peter@korsgaard.com> a écrit :
>
> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>
> > Add a comment when kernel is not enabled (missing since the addition of
> > the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
>
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/wireguard-linux-compat/Config.in | 3 +++
> > 1 file changed, 3 insertions(+)
>
> > diff --git a/package/wireguard-linux-compat/Config.in b/package/wireguard-linux-compat/Config.in
> > index 5a323a35e5..4e8e95bdc3 100644
> > --- a/package/wireguard-linux-compat/Config.in
> > +++ b/package/wireguard-linux-compat/Config.in
> > @@ -21,6 +21,9 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
>
> > https://www.wireguard.com
>
> > +comment "wireguard-linux-compat needs a Linux kernel to be built"
> > + depends on !BR2_LINUX_KERNEL
>
> Is this really a sensible comment? I would imagine that needing a Linux
> kernel is an obvious requirement for a kernel driver?
We have this comment for other drivers such as dahdi-linux and xr819-xradio.
So I think we should be consistent in all packages.
>
>
> > +
> > comment "wireguard-linux-compat needs a toolchain w/ headers >= 3.10"
> > depends on BR2_LINUX_KERNEL
> > depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
> > --
> > 2.33.0
>
>
> --
> Bye, Peter Korsgaard
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
2021-10-16 8:51 ` Fabrice Fontaine
@ 2021-10-16 8:58 ` Peter Korsgaard
0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2021-10-16 8:58 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Buildroot Mailing List
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Le sam. 16 oct. 2021 à 10:46, Peter Korsgaard <peter@korsgaard.com> a écrit :
>>
>> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>>
>> > Add a comment when kernel is not enabled (missing since the addition of
>> > the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
>>
>> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> > ---
>> > package/wireguard-linux-compat/Config.in | 3 +++
>> > 1 file changed, 3 insertions(+)
>>
>> > diff --git a/package/wireguard-linux-compat/Config.in
>> > b/package/wireguard-linux-compat/Config.in
>> > index 5a323a35e5..4e8e95bdc3 100644
>> > --- a/package/wireguard-linux-compat/Config.in
>> > +++ b/package/wireguard-linux-compat/Config.in
>> > @@ -21,6 +21,9 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
>>
>> > https://www.wireguard.com
>>
>> > +comment "wireguard-linux-compat needs a Linux kernel to be built"
>> > + depends on !BR2_LINUX_KERNEL
>>
>> Is this really a sensible comment? I would imagine that needing a Linux
>> kernel is an obvious requirement for a kernel driver?
> We have this comment for other drivers such as dahdi-linux and xr819-xradio.
> So I think we should be consistent in all packages.
Ok, I'll take care of it.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
2021-10-16 8:46 ` Peter Korsgaard
2021-10-16 8:51 ` Fabrice Fontaine
@ 2021-10-16 12:10 ` Yann E. MORIN
1 sibling, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2021-10-16 12:10 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Fabrice Fontaine, buildroot
Peter, All,
On 2021-10-16 10:46 +0200, Peter Korsgaard spake thusly:
> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> > Add a comment when kernel is not enabled (missing since the addition of
> > the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
[--SNIP--]
> Is this really a sensible comment? I would imagine that needing a Linux
> kernel is an obvious requirement for a kernel driver?
Remember that some people build their kernel outside of Buildroot, or
do not build it at all, so they may not think of this as "an obvious
requirement"...
I agree with Fabrice: we have that comment in quite some places, and
this is explicitly documented in our manual:
18.2.5. Dependencies on a Linux kernel built by buildroot
Some packages need a Linux kernel to be built by buildroot. These
are typically kernel modules or firmware. A comment should be added
in the Config.in file to express this dependency, similar to
dependencies on toolchain options. The general format is:
foo needs a Linux kernel to be built
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
2021-10-16 8:41 [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency Fabrice Fontaine
2021-10-16 8:46 ` Peter Korsgaard
@ 2021-10-17 7:50 ` Yann E. MORIN
2021-10-22 18:42 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2021-10-17 7:50 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Fabrice, All,
On 2021-10-16 10:41 +0200, Fabrice Fontaine spake thusly:
> Add a comment when kernel is not enabled (missing since the addition of
> the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/wireguard-linux-compat/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/wireguard-linux-compat/Config.in b/package/wireguard-linux-compat/Config.in
> index 5a323a35e5..4e8e95bdc3 100644
> --- a/package/wireguard-linux-compat/Config.in
> +++ b/package/wireguard-linux-compat/Config.in
> @@ -21,6 +21,9 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
>
> https://www.wireguard.com
>
> +comment "wireguard-linux-compat needs a Linux kernel to be built"
> + depends on !BR2_LINUX_KERNEL
> +
> comment "wireguard-linux-compat needs a toolchain w/ headers >= 3.10"
> depends on BR2_LINUX_KERNEL
> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency
2021-10-16 8:41 [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency Fabrice Fontaine
2021-10-16 8:46 ` Peter Korsgaard
2021-10-17 7:50 ` Yann E. MORIN
@ 2021-10-22 18:42 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2021-10-22 18:42 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Add a comment when kernel is not enabled (missing since the addition of
> the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-10-22 18:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-16 8:41 [Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency Fabrice Fontaine
2021-10-16 8:46 ` Peter Korsgaard
2021-10-16 8:51 ` Fabrice Fontaine
2021-10-16 8:58 ` Peter Korsgaard
2021-10-16 12:10 ` Yann E. MORIN
2021-10-17 7:50 ` Yann E. MORIN
2021-10-22 18:42 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox