Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@buildroot.org
Cc: Romain Naour <romain.naour@gmail.com>
Subject: [Buildroot] [PATCH 5/5] docs/manual/adding-packages-directory.txt: reorder select/depends
Date: Sat, 29 Jan 2022 23:46:51 +0100	[thread overview]
Message-ID: <20220129224651.1282263-5-romain.naour@gmail.com> (raw)
In-Reply-To: <20220129224651.1282263-1-romain.naour@gmail.com>

From [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
 is not logical (when reading). It is more logical and far easier to
 understand when depends come first, followed by the selects."

 Also, the Config.in example in the manual suggests to use this coding
 style [2]."

Use the correct coding style in the chapter "Choosing depends on or select"
in the manual.

[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] https://nightly.buildroot.org/manual.html#_coding_style

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 docs/manual/adding-packages-directory.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
index 6c68d7aa67..e5c7462a6c 100644
--- a/docs/manual/adding-packages-directory.txt
+++ b/docs/manual/adding-packages-directory.txt
@@ -196,13 +196,13 @@ config BR2_PACKAGE_E
 --------------------------
 config BR2_PACKAGE_D
 	bool "Package D"
-	select BR2_PACKAGE_B
 	depends on BR2_PACKAGE_A
+	select BR2_PACKAGE_B
 
 config BR2_PACKAGE_E
 	bool "Package E"
-	select BR2_PACKAGE_D
 	depends on BR2_PACKAGE_A
+	select BR2_PACKAGE_D
 --------------------------
 
 Overall, for package library dependencies, +select+ should be
-- 
2.31.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-01-29 22:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-29 22:46 [Buildroot] [PATCH 1/5] package/efl: bump to version 1.26.1 Romain Naour
2022-01-29 22:46 ` [Buildroot] [PATCH 2/5] package/enlightenment: bump to version 0.25.1 Romain Naour
2022-01-30 14:00   ` Thomas Petazzoni via buildroot
2022-01-29 22:46 ` [Buildroot] [PATCH 3/5] package/efl: rework eeze handling in Kconfig Romain Naour
2022-01-30 14:02   ` Thomas Petazzoni via buildroot
2022-01-30 17:40     ` Romain Naour
2022-01-30 20:44       ` Thomas Petazzoni via buildroot
2022-01-29 22:46 ` [Buildroot] [PATCH 4/5] package/efl: handle input option Romain Naour
2022-01-30 14:05   ` Thomas Petazzoni via buildroot
2022-01-29 22:46 ` Romain Naour [this message]
2022-01-30 14:12   ` [Buildroot] [PATCH 5/5] docs/manual/adding-packages-directory.txt: reorder select/depends Thomas Petazzoni via buildroot
2022-01-30 14:00 ` [Buildroot] [PATCH 1/5] package/efl: bump to version 1.26.1 Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220129224651.1282263-5-romain.naour@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox