Re: [Buildroot] [PATCH 4/5] package/efl: handle input option

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Sat, 29 Jan 2022 23:46:50 +0100
Romain Naour <romain.naour@gmail.com> wrote:

> +config BR2_PACKAGE_EFL_LIBINPUT
> +	bool "Enable libinput support (recommended)"
> +	default y
> +	depends on BR2_PACKAGE_HAS_UDEV # libinput

Should be:

	depends on BR2_PACKAGE_HAS_UDEV # libinput, efl-eeze

> +comment "libinput needs udev /dev management (eeze)"

Drop "eeze" between parenthesis.

> +	depends on !BR2_PACKAGE_HAS_UDEV
> +
>  config BR2_PACKAGE_EFL_LIBSNDFILE
>  	bool "Enable libsndfile support (recommended)"
>  	default y
> @@ -216,13 +229,11 @@ endchoice # OpenGL support
>  
>  config BR2_PACKAGE_EFL_DRM
>  	bool "Evas DRM Engine"
> -	depends on BR2_PACKAGE_HAS_UDEV (eeze)
> +	depends on BR2_PACKAGE_HAS_UDEV # elput, eeze

You fixed a bug from the previous commit here. What is "elput" ?

>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
>  	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d
> -	select BR2_PACKAGE_EFL_EEZE
> +	select BR2_PACKAGE_EFL_LIBINPUT

Is that the explanation for PATCH 3/5 ? But even that doesn't seem to
justify PATCH 3/5: you could have done the same with a "depends on
BR2_PACKAGE_EFL_EEZE".

Again: I agree with PATCH 3/5, and I think it's the right patch. I just
don't understand the justification it has in its commit log.

>  	select BR2_PACKAGE_LIBDRM
> -	select BR2_PACKAGE_LIBINPUT # For elput

What is "elput" ?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot