Re: [Buildroot] [PATCH 3/5] package/efl: rework eeze handling in Kconfig

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sat, 29 Jan 2022 23:46:49 +0100
Romain Naour <romain.naour@gmail.com> wrote:

> Commit [1] added eeze dependency using "depends on" to several efl
> options (drm, libmount) instead of selecting eeze and propagate the
> udev reverse dependency.

I do agree with changing from a "depends on BR2_PACKAGE_EFL_EEZE" to a
"depends BR2_PACKAGE_HAS_UDEV" + "select BR2_PACKAGE_EFL_EEZE".
However...

> The dependency between eeze, libinput, efl drm requires to add a new
> libinput option.

... I don't understand this justification. Could you clarify. Even
after reading PATCH 4/5, I don't get the relationship. PATCH 4/5 could
have been done (I guess using the same principle of "depends on
BR2_PACKAGE_EFL_EEZE".

> Rework eeze handling to use select BR2_PACKAGE_EFL_EEZE since the
> user is already aware of the udev dependency (BR2_PACKAGE_HAS_UDEV).

I don't understand why you say the user is already aware of the udev
dependency? Thanks to the comments?

>  comment "efl's libmount support needs udev /dev management (eeze)"

Remove the "eeze" between parenthesis here I believe.

> -	depends on !BR2_PACKAGE_EFL_EEZE
> +	depends on !BR2_PACKAGE_HAS_UDEV
>  
>  config BR2_PACKAGE_EFL_HAS_RECOMMENDED_CONFIG
>  	bool
> @@ -173,7 +174,7 @@ config BR2_PACKAGE_EFL_WAYLAND
>  	depends on BR2_PACKAGE_WAYLAND
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # Evas DRM Engine -> libdrm
>  	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # Evas DRM Engine
> -	depends on BR2_PACKAGE_EFL_EEZE # efl drm
> +	depends on BR2_PACKAGE_HAS_UDEV # efl drm (eeze)
>  	depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only
>  	depends on BR2_ENABLE_LOCALE # efl-drm <- efl-elput <- linput
>  	select BR2_PACKAGE_EFL_DRM
> @@ -182,7 +183,7 @@ config BR2_PACKAGE_EFL_WAYLAND
>  comment "Wayland support needs udev /dev management (eeze), OpenGL ES w/ EGL, threads, locales"

Ditto.

>  	depends on BR2_PACKAGE_WAYLAND
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \
> -		|| !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_EFL_EEZE \
> +		|| !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_HAS_UDEV \
>  		|| !BR2_ENABLE_LOCALE
>  
>  choice
> @@ -215,9 +216,10 @@ endchoice # OpenGL support
>  
>  config BR2_PACKAGE_EFL_DRM
>  	bool "Evas DRM Engine"
> -	depends on BR2_PACKAGE_EFL_EEZE
> +	depends on BR2_PACKAGE_HAS_UDEV (eeze)

Does this line really parses correctly?

>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
>  	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d
> +	select BR2_PACKAGE_EFL_EEZE
>  	select BR2_PACKAGE_LIBDRM
>  	select BR2_PACKAGE_LIBINPUT # For elput
>  	select BR2_PACKAGE_LIBXKBCOMMON
> @@ -232,7 +234,7 @@ config BR2_PACKAGE_EFL_DRM
>  
>  comment "Evas DRM Engine needs udev /dev management (eeze), mesa3d w/ EGL support, threads"

Remove the "eeze" between parenthesis.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot