Re: [Buildroot] [PATCH 3/5] package/efl: rework eeze handling in Kconfig

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/5] package/efl: rework eeze handling in Kconfig
Date: Sun, 30 Jan 2022 21:44:43 +0100	[thread overview]
Message-ID: <20220130214443.0106ce53@windsurf> (raw)
In-Reply-To: <400c4077-1e25-a5fd-592e-cbf149d7a626@gmail.com>

Hello,

On Sun, 30 Jan 2022 18:40:39 +0100
Romain Naour <romain.naour@gmail.com> wrote:

> Le 30/01/2022 à 15:02, Thomas Petazzoni a écrit :
> > On Sat, 29 Jan 2022 23:46:49 +0100
> > Romain Naour <romain.naour@gmail.com> wrote:
> >   
> >> Commit [1] added eeze dependency using "depends on" to several efl
> >> options (drm, libmount) instead of selecting eeze and propagate the
> >> udev reverse dependency.  
> > 
> > I do agree with changing from a "depends on BR2_PACKAGE_EFL_EEZE" to a
> > "depends BR2_PACKAGE_HAS_UDEV" + "select BR2_PACKAGE_EFL_EEZE".
> > However...
> >   
> >> The dependency between eeze, libinput, efl drm requires to add a new
> >> libinput option.  
> > 
> > ... I don't understand this justification. Could you clarify. Even
> > after reading PATCH 4/5, I don't get the relationship. PATCH 4/5 could
> > have been done (I guess using the same principle of "depends on
> > BR2_PACKAGE_EFL_EEZE".  
> 
> AFAIK, efl drm needs libinput (elput) that requires udev (eeze).
> Until now we don't have a libinput option to disable it when eeze is also disabled.

Right, and? How is that related to changing "depends on
BR2_PACKAGE_EFL_EEZE" to "select BR2_PACKAGE_EFL_EEZE" ?

> >> Rework eeze handling to use select BR2_PACKAGE_EFL_EEZE since the
> >> user is already aware of the udev dependency (BR2_PACKAGE_HAS_UDEV).  
> > 
> > I don't understand why you say the user is already aware of the udev
> > dependency? Thanks to the comments?  
> 
> I mean if eeze can be selected, it means that the used either selected systemd
> or eudev.

But that's just normal thing in Buildroot, no? I fail to understand this
part of your commit log.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot