From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Daniel Price" <daniel.price@gmail.com>,
"Gilles Talis" <gilles.talis@gmail.com>,
"Peter Seiderer" <ps.report@gmx.net>,
"Julien Corjon" <corjon.j@ecagroup.com>,
buildroot@buildroot.org, "Martin Bark" <martin@barkynet.com>,
"Gaël Portay" <gael.portay@collabora.com>
Subject: Re: [Buildroot] [PATCH v6 4/8] package/qt5/qt5base: enable ccache via configure option
Date: Sat, 5 Feb 2022 21:23:49 +0100 [thread overview]
Message-ID: <20220205212349.17db6aa4@windsurf> (raw)
In-Reply-To: <20220205201837.3324085-4-james.hilliard1@gmail.com>
On Sat, 5 Feb 2022 13:18:33 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:
> # This allows to use ccache when available
> -define QT5BASE_CONFIGURE_HOSTCC
> - $(SED) 's,^QMAKE_CC\s*=.*,QMAKE_CC = $(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
> - $(SED) 's,^QMAKE_CXX\s*=.*,QMAKE_CXX = $(HOSTCXX),' $(@D)/mkspecs/common/g++-base.conf
> -endef
This this variable is dropped, then surely the place it was used should also be modified?
> +ifeq ($(BR2_CCACHE),y)
> +QT5BASE_CONFIGURE_OPTS += -ccache
> +endif
Are we sure this is going to use Buildroot's ccache and not the system
ccache?
Indeed, $(HOSTCC) and $(HOSTCXX) are defined as:
CCACHE = $(HOST_DIR)/bin/ccache
HOSTCC = $(CCACHE) $(HOSTCC_NOCCACHE)
HOSTCXX = $(CCACHE) $(HOSTCXX_NOCCACHE)
so we know that it's the Buildroot ccache that will be used.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-02-05 20:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 20:18 [Buildroot] [PATCH v6 1/8] package/webp: enable host build James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 2/8] package/re2: switch to generic-package make build James Hilliard
2022-02-13 14:42 ` Yann E. MORIN
2022-02-13 14:52 ` Peter Korsgaard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 3/8] package/icu: don't disable renaming for host build James Hilliard
2022-02-13 15:00 ` Yann E. MORIN
2022-02-13 16:59 ` Peter Korsgaard
2022-02-13 15:01 ` Yann E. MORIN
2022-02-05 20:18 ` [Buildroot] [PATCH v6 4/8] package/qt5/qt5base: enable ccache via configure option James Hilliard
2022-02-05 20:23 ` Thomas Petazzoni via buildroot [this message]
2022-02-05 20:40 ` James Hilliard
2022-02-13 15:06 ` Yann E. MORIN
2022-02-13 16:39 ` Arnout Vandecappelle
2022-02-05 20:18 ` [Buildroot] [PATCH v6 5/8] package/qt5/qt5webengine-chromium-catapult: new package James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 6/8] package/qt5/qt5webengine-chromium: " James Hilliard
2022-02-13 16:50 ` Yann E. MORIN
2022-02-14 1:11 ` James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 7/8] package/qt5/qt5base: disable broken qmake sysrootify James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 8/8] package/qt5/qt5webengine: bump to version 5.15.8 James Hilliard
2022-02-13 11:43 ` [Buildroot] [PATCH v6 1/8] package/webp: enable host build Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220205212349.17db6aa4@windsurf \
--to=buildroot@buildroot.org \
--cc=corjon.j@ecagroup.com \
--cc=daniel.price@gmail.com \
--cc=gael.portay@collabora.com \
--cc=gilles.talis@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=martin@barkynet.com \
--cc=ps.report@gmx.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox