From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Daniel Price" <daniel.price@gmail.com>,
"Gilles Talis" <gilles.talis@gmail.com>,
"Peter Seiderer" <ps.report@gmx.net>,
"Julien Corjon" <corjon.j@ecagroup.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org, "Martin Bark" <martin@barkynet.com>,
"Gaël Portay" <gael.portay@collabora.com>
Subject: Re: [Buildroot] [PATCH v6 3/8] package/icu: don't disable renaming for host build
Date: Sun, 13 Feb 2022 16:01:13 +0100 [thread overview]
Message-ID: <20220213150113.GC4462@scaer> (raw)
In-Reply-To: <20220205201837.3324085-3-james.hilliard1@gmail.com>
On 2022-02-05 13:18 -0700, James Hilliard spake thusly:
> Using a different renaming option for the icu host build can cause
> issues for packages such as qt5webengine which expect target and
> host packages to be built with the same options.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
I forgot to add:
Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/icu/icu.mk | 3 +--
> package/nodejs/nodejs.mk | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/icu/icu.mk b/package/icu/icu.mk
> index 7e0c96e43a..ebbb1968fc 100644
> --- a/package/icu/icu.mk
> +++ b/package/icu/icu.mk
> @@ -45,8 +45,7 @@ HOST_ICU_CONF_OPTS = \
> --disable-tests \
> --disable-extras \
> --disable-icuio \
> - --disable-layout \
> - --disable-renaming
> + --disable-layout
> ICU_SUBDIR = source
> HOST_ICU_SUBDIR = source
>
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 727af6dc50..2e41c11dbd 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -94,7 +94,7 @@ NODEJS_HOST_TOOLS_V8 = \
> NODEJS_HOST_TOOLS_NODE = mkcodecache
> NODEJS_HOST_TOOLS = $(NODEJS_HOST_TOOLS_V8) $(NODEJS_HOST_TOOLS_NODE)
>
> -HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS) -DU_DISABLE_RENAMING=1
> +HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS)
>
> define HOST_NODEJS_BUILD_CMDS
> $(HOST_MAKE_ENV) PYTHON=$(HOST_DIR)/bin/python3 \
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-02-13 15:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 20:18 [Buildroot] [PATCH v6 1/8] package/webp: enable host build James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 2/8] package/re2: switch to generic-package make build James Hilliard
2022-02-13 14:42 ` Yann E. MORIN
2022-02-13 14:52 ` Peter Korsgaard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 3/8] package/icu: don't disable renaming for host build James Hilliard
2022-02-13 15:00 ` Yann E. MORIN
2022-02-13 16:59 ` Peter Korsgaard
2022-02-13 15:01 ` Yann E. MORIN [this message]
2022-02-05 20:18 ` [Buildroot] [PATCH v6 4/8] package/qt5/qt5base: enable ccache via configure option James Hilliard
2022-02-05 20:23 ` Thomas Petazzoni via buildroot
2022-02-05 20:40 ` James Hilliard
2022-02-13 15:06 ` Yann E. MORIN
2022-02-13 16:39 ` Arnout Vandecappelle
2022-02-05 20:18 ` [Buildroot] [PATCH v6 5/8] package/qt5/qt5webengine-chromium-catapult: new package James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 6/8] package/qt5/qt5webengine-chromium: " James Hilliard
2022-02-13 16:50 ` Yann E. MORIN
2022-02-14 1:11 ` James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 7/8] package/qt5/qt5base: disable broken qmake sysrootify James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 8/8] package/qt5/qt5webengine: bump to version 5.15.8 James Hilliard
2022-02-13 11:43 ` [Buildroot] [PATCH v6 1/8] package/webp: enable host build Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220213150113.GC4462@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=corjon.j@ecagroup.com \
--cc=daniel.price@gmail.com \
--cc=gael.portay@collabora.com \
--cc=gilles.talis@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=martin@barkynet.com \
--cc=ps.report@gmx.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox