Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Daniel Price" <daniel.price@gmail.com>,
	"Gilles Talis" <gilles.talis@gmail.com>,
	"Peter Seiderer" <ps.report@gmx.net>,
	"Julien Corjon" <corjon.j@ecagroup.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, "Martin Bark" <martin@barkynet.com>,
	"Gaël Portay" <gael.portay@collabora.com>
Subject: Re: [Buildroot] [PATCH v6 4/8] package/qt5/qt5base: enable ccache via configure option
Date: Sun, 13 Feb 2022 16:06:21 +0100	[thread overview]
Message-ID: <20220213150621.GD4462@scaer> (raw)
In-Reply-To: <20220205201837.3324085-4-james.hilliard1@gmail.com>

James, All,

+Arnout

On 2022-02-05 13:18 -0700, James Hilliard spake thusly:
> This should be cleaner than editing mkspecs/common/g++-base.conf.

Is this actually fixing something? Is ccache as we sue it badly handled
by the qt5webengin buildsystem somehow?

Thomas, Arnout: IIRC some time ago, there were talks about using the
compiler wrapper also for the host compiler. Maybe this would solve this
kind of situations?

Regards,
Yann E. MORIN.

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/qt5/qt5base/qt5base.mk | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index d8a0bf1d16..4b7a2a937d 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -289,10 +289,9 @@ endef
>  endif
>  
>  # This allows to use ccache when available
> -define QT5BASE_CONFIGURE_HOSTCC
> -	$(SED) 's,^QMAKE_CC\s*=.*,QMAKE_CC = $(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
> -	$(SED) 's,^QMAKE_CXX\s*=.*,QMAKE_CXX = $(HOSTCXX),' $(@D)/mkspecs/common/g++-base.conf
> -endef
> +ifeq ($(BR2_CCACHE),y)
> +QT5BASE_CONFIGURE_OPTS += -ccache
> +endif
>  
>  # Must be last so can override all options set by Buildroot
>  QT5BASE_CONFIGURE_OPTS += $(call qstrip,$(BR2_PACKAGE_QT5BASE_CUSTOM_CONF_OPTS))
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-02-13 15:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05 20:18 [Buildroot] [PATCH v6 1/8] package/webp: enable host build James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 2/8] package/re2: switch to generic-package make build James Hilliard
2022-02-13 14:42   ` Yann E. MORIN
2022-02-13 14:52     ` Peter Korsgaard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 3/8] package/icu: don't disable renaming for host build James Hilliard
2022-02-13 15:00   ` Yann E. MORIN
2022-02-13 16:59     ` Peter Korsgaard
2022-02-13 15:01   ` Yann E. MORIN
2022-02-05 20:18 ` [Buildroot] [PATCH v6 4/8] package/qt5/qt5base: enable ccache via configure option James Hilliard
2022-02-05 20:23   ` Thomas Petazzoni via buildroot
2022-02-05 20:40     ` James Hilliard
2022-02-13 15:06   ` Yann E. MORIN [this message]
2022-02-13 16:39     ` Arnout Vandecappelle
2022-02-05 20:18 ` [Buildroot] [PATCH v6 5/8] package/qt5/qt5webengine-chromium-catapult: new package James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 6/8] package/qt5/qt5webengine-chromium: " James Hilliard
2022-02-13 16:50   ` Yann E. MORIN
2022-02-14  1:11     ` James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 7/8] package/qt5/qt5base: disable broken qmake sysrootify James Hilliard
2022-02-05 20:18 ` [Buildroot] [PATCH v6 8/8] package/qt5/qt5webengine: bump to version 5.15.8 James Hilliard
2022-02-13 11:43 ` [Buildroot] [PATCH v6 1/8] package/webp: enable host build Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220213150621.GD4462@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=corjon.j@ecagroup.com \
    --cc=daniel.price@gmail.com \
    --cc=gael.portay@collabora.com \
    --cc=gilles.talis@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=martin@barkynet.com \
    --cc=ps.report@gmx.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox