Re: [Buildroot] [PATCH v6 3/8] package/icu: don't disable renaming for host build

From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: "Daniel Price" <daniel.price@gmail.com>,
	"Gilles Talis" <gilles.talis@gmail.com>,
	"James Hilliard" <james.hilliard1@gmail.com>,
	"Peter Seiderer" <ps.report@gmx.net>,
	"Julien Corjon" <corjon.j@ecagroup.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, "Martin Bark" <martin@barkynet.com>,
	"Gaël Portay" <gael.portay@collabora.com>
Subject: Re: [Buildroot] [PATCH v6 3/8] package/icu: don't disable renaming for host build
Date: Sun, 13 Feb 2022 17:59:09 +0100	[thread overview]
Message-ID: <87iltiln36.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220213150051.GB4462@scaer> (Yann E. MORIN's message of "Sun, 13 Feb 2022 16:00:51 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > James, All,
 > On 2022-02-05 13:18 -0700, James Hilliard spake thusly:
 >> Using a different renaming option for the icu host build can cause
 >> issues for packages such as qt5webengine which expect target and
 >> host packages to be built with the same options.

 > This little hand-waving is not explaning the actual error that those
 > packages encounter, nor the root cause for that error.

 > A package that needs both host and target to have the same options is
 > most probably doing somethig wrong, like linking a host program and
 > taking the result as valid for the target...

 > However, our adding the --disable-renaming in the first place in
 > 3911e67151b (icu: security bump to version 51.2) did not provide any
 > explanations why it was needed to begin with.

 > So it is not much uglier to remove it without further explanations
 > either.

 > Yet, a reference to the original commit would be nice, like the little
 > blurb I wrote above maybe...

Committed with the commit message extended, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot