Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/5] ackage/rtl8723ds-bt: new package
Date: Sun, 30 Oct 2022 22:21:14 +0100	[thread overview]
Message-ID: <20221030212114.GH1058960@scaer> (raw)
In-Reply-To: <CA+_SqVZvmi+iVGF=ig6ct4fbygRaL63KwJ-AQzCL1piTixgQVQ@mail.gmail.com>

Angelo, All,

On 2022-10-30 21:55 +0100, Angelo Compagnucci spake thusly:
> On Sun, Oct 30, 2022 at 9:48 PM Thomas Petazzoni < [1]thomas.petazzoni@bootlin.com> wrote:
>   On Fri, 14 Oct 2022 08:58:58 +0200
>   Angelo Compagnucci < [2]angelo@amarulasolutions.com> wrote:
>   > @@ -78,7 +78,8 @@ LINUX_DEPENDENCIES += \
>   >       $(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>   >       $(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
>   >       $(if $(BR2_PACKAGE_FIRMWARE_IMX),firmware-imx) \
>   > -     $(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
>   > +     $(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb) \
>   > +     $(if $(BR2_PACKAGE_RTL8723DS_BT),rtl8723ds-bt)
>   > 
>   >  # Starting with 4.16, the generated kconfig paser code is no longer
>   >  # shipped with the kernel sources, so we need flex and bison, but
>   > diff --git a/package/Config.in b/package/Config.in
>   > index e3a34d6e97..4f6e508106 100644
>   > --- a/package/Config.in
>   > +++ b/package/Config.in
>   > @@ -578,6 +578,7 @@ endmenu
>   >       source "package/rtl8189fs/Config.in"
>   >       source "package/rtl8723bu/Config.in"
>   >       source "package/rtl8723ds/Config.in"
>   > +     source "package/rtl8723ds-bt/Config.in"
>   >       source "package/rtl8812au-aircrack-ng/Config.in"
>   >       source "package/rtl8821au/Config.in"
>   >       source "package/sane-backends/Config.in"
>   > diff --git a/package/rtl8723ds-bt/Config.in b/package/rtl8723ds-bt/Config.in
>   > new file mode 100644
>   > index 0000000000..ab4ba0bf11
>   > --- /dev/null
>   > +++ b/package/rtl8723ds-bt/Config.in
>   > @@ -0,0 +1,6 @@
>   > +config BR2_PACKAGE_RTL8723DS_BT
>   > +     bool "rtl8723ds-bt"
>   > +     help
>   > +       rtl8723ds UART attached Bluetooth driver
> 
>   So here you're saying this package is for a driver.
> 
>   > +define RTL8723DS_BT_LINUX_CONFIG_FIXUPS
>   > +     $(call KCONFIG_ENABLE_OPT,CONFIG_SERIAL_DEV_BUS)
>   > +     $(call KCONFIG_ENABLE_OPT,CONFIG_SERIAL_DEV_CTRL_TTYPORT)
>   > +     $(call KCONFIG_ENABLE_OPT,CONFIG_BT)
>   > +     $(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART)
>   > +     $(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART_3WIRE)
>   > +     $(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART_RTL)
>   > +     $(call KCONFIG_APPEND_OPT,CONFIG_EXTRA_FIRMWARE,rtl_bt/rtl8723ds_fw.bin rtl_bt/rtl8723ds_config.bin)
>   > +endef
>   > +
>   > +define RTL8723DS_BT_INSTALL_STAGING_CMDS
>   > +     mkdir -p $(STAGING_DIR)/lib/firmware/rtl_bt/
>   > +     cp $(@D)/8723D/rtl8723d_fw $(STAGING_DIR)/lib/firmware/rtl_bt/rtl8723ds_fw.bin
>   > +     cp $(@D)/8723D/rtl8723d_config $(STAGING_DIR)/lib/firmware/rtl_bt/rtl8723ds_config.bin
> 
>   But here you are only installing the firmware file, and you're not
>   building the kernel module that is provided in this Git repository.
> 
>   Is it because the driver is in the upstream kernel, and the only part
>   that it lacks is the firmware?
> 
>   This is not really clear in your commit log nor in the Config.in help
>   text.
> 
> Thi package "enables" (as in the commit log) the module, I didn't want to word differently, because what we are really doing here is
> simply enabling some kernel drivers and offering a way to download the firmware. Anyway, I will reword it better.

Look at the other firmware packages we have: they only install the
firmware blobs they provide.

Enabling kernel options to enable a kernel driver is what the user does
when they provide the configuration file for the kernel. We do not want
to have an option in Buildroot for each driver that can be enabled in
the kernel.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-10-30 21:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  6:58 [Buildroot] [PATCH v2 0/5] Lichee RV and Lichee RV dock support Angelo Compagnucci
2022-10-14  6:58 ` [Buildroot] [PATCH v2 1/5] linux: enable CONFIG_EXTRA_FIRMWARE_DIR Angelo Compagnucci
2022-10-30 20:43   ` Thomas Petazzoni via buildroot
2022-10-30 20:52     ` Angelo Compagnucci
2022-10-30 21:23   ` Yann E. MORIN
2022-10-14  6:58 ` [Buildroot] [PATCH v2 2/5] package/pkg-utils: add KCONFIG_APPEND_OPT Angelo Compagnucci
2022-10-14  6:58 ` [Buildroot] [PATCH v2 3/5] ackage/rtl8723ds-bt: new package Angelo Compagnucci
2022-10-30 20:48   ` Thomas Petazzoni via buildroot
2022-10-30 20:55     ` Angelo Compagnucci
2022-10-30 21:21       ` Yann E. MORIN [this message]
2022-10-14  6:58 ` [Buildroot] [PATCH v2 4/5] configs/lichee_rv: new defconfig Angelo Compagnucci
2022-10-14  6:59 ` [Buildroot] [PATCH v2 5/5] configs/lichee_rv_dock: " Angelo Compagnucci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221030212114.GH1058960@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=angelo@amarulasolutions.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox