From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/5] ackage/rtl8723ds-bt: new package
Date: Sun, 30 Oct 2022 21:48:09 +0100 [thread overview]
Message-ID: <20221030214809.1fa5997c@windsurf> (raw)
In-Reply-To: <20221014065900.3311604-4-angelo@amarulasolutions.com>
On Fri, 14 Oct 2022 08:58:58 +0200
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> @@ -78,7 +78,8 @@ LINUX_DEPENDENCIES += \
> $(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
> $(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
> $(if $(BR2_PACKAGE_FIRMWARE_IMX),firmware-imx) \
> - $(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
> + $(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb) \
> + $(if $(BR2_PACKAGE_RTL8723DS_BT),rtl8723ds-bt)
>
> # Starting with 4.16, the generated kconfig paser code is no longer
> # shipped with the kernel sources, so we need flex and bison, but
> diff --git a/package/Config.in b/package/Config.in
> index e3a34d6e97..4f6e508106 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -578,6 +578,7 @@ endmenu
> source "package/rtl8189fs/Config.in"
> source "package/rtl8723bu/Config.in"
> source "package/rtl8723ds/Config.in"
> + source "package/rtl8723ds-bt/Config.in"
> source "package/rtl8812au-aircrack-ng/Config.in"
> source "package/rtl8821au/Config.in"
> source "package/sane-backends/Config.in"
> diff --git a/package/rtl8723ds-bt/Config.in b/package/rtl8723ds-bt/Config.in
> new file mode 100644
> index 0000000000..ab4ba0bf11
> --- /dev/null
> +++ b/package/rtl8723ds-bt/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_RTL8723DS_BT
> + bool "rtl8723ds-bt"
> + help
> + rtl8723ds UART attached Bluetooth driver
So here you're saying this package is for a driver.
> +define RTL8723DS_BT_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_SERIAL_DEV_BUS)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_SERIAL_DEV_CTRL_TTYPORT)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_BT)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART_3WIRE)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART_RTL)
> + $(call KCONFIG_APPEND_OPT,CONFIG_EXTRA_FIRMWARE,rtl_bt/rtl8723ds_fw.bin rtl_bt/rtl8723ds_config.bin)
> +endef
> +
> +define RTL8723DS_BT_INSTALL_STAGING_CMDS
> + mkdir -p $(STAGING_DIR)/lib/firmware/rtl_bt/
> + cp $(@D)/8723D/rtl8723d_fw $(STAGING_DIR)/lib/firmware/rtl_bt/rtl8723ds_fw.bin
> + cp $(@D)/8723D/rtl8723d_config $(STAGING_DIR)/lib/firmware/rtl_bt/rtl8723ds_config.bin
But here you are only installing the firmware file, and you're not
building the kernel module that is provided in this Git repository.
Is it because the driver is in the upstream kernel, and the only part
that it lacks is the firmware?
This is not really clear in your commit log nor in the Config.in help
text.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-30 20:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 6:58 [Buildroot] [PATCH v2 0/5] Lichee RV and Lichee RV dock support Angelo Compagnucci
2022-10-14 6:58 ` [Buildroot] [PATCH v2 1/5] linux: enable CONFIG_EXTRA_FIRMWARE_DIR Angelo Compagnucci
2022-10-30 20:43 ` Thomas Petazzoni via buildroot
2022-10-30 20:52 ` Angelo Compagnucci
2022-10-30 21:23 ` Yann E. MORIN
2022-10-14 6:58 ` [Buildroot] [PATCH v2 2/5] package/pkg-utils: add KCONFIG_APPEND_OPT Angelo Compagnucci
2022-10-14 6:58 ` [Buildroot] [PATCH v2 3/5] ackage/rtl8723ds-bt: new package Angelo Compagnucci
2022-10-30 20:48 ` Thomas Petazzoni via buildroot [this message]
2022-10-30 20:55 ` Angelo Compagnucci
2022-10-30 21:21 ` Yann E. MORIN
2022-10-14 6:58 ` [Buildroot] [PATCH v2 4/5] configs/lichee_rv: new defconfig Angelo Compagnucci
2022-10-14 6:59 ` [Buildroot] [PATCH v2 5/5] configs/lichee_rv_dock: " Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030214809.1fa5997c@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox