From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/5] linux: enable CONFIG_EXTRA_FIRMWARE_DIR
Date: Sun, 30 Oct 2022 22:23:33 +0100 [thread overview]
Message-ID: <20221030212333.GI1058960@scaer> (raw)
In-Reply-To: <20221014065900.3311604-2-angelo@amarulasolutions.com>
Angelo, All,
On 2022-10-14 08:58 +0200, Angelo Compagnucci spake thusly:
> CONFIG_EXTRA_FIRMWARE_DIR must point to the directory where firmware
> file from CONFIG_EXTRA_FIRMWARE will be taken to be embedded to the
> kernel.
> The option is removed if CONFIG_EXTRA_FIRMWARE is not used, but it
> defaults to a sensible value when used.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> linux/linux.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index efdc21eff2..9a909c7d7b 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -408,6 +408,9 @@ define LINUX_KCONFIG_FIXUP_CMDS
> $(call KCONFIG_ENABLE_OPT,CONFIG_LOGO)
> $(call KCONFIG_ENABLE_OPT,CONFIG_LOGO_LINUX_CLUT224))
> $(call KCONFIG_DISABLE_OPT,CONFIG_GCC_PLUGINS)
> + # The kernel CONFIG_EXTRA_FIRMWARE feature requires to have the firmware full
> + # path for locating firmware file.
> + $(call KCONFIG_SET_OPT,CONFIG_EXTRA_FIRMWARE_DIR,"$(STAGING_DIR)/lib/firmware")
Besides what Thomas already said: firmware files are not installed in
STAGING_DIR/lib/firmware, but they are in TARGET_DIR/lib/frmware.
Also, some people already point CONFIG_EXTRA_FIRMWARE_DIR=$(INAGES_DIR)
as there are some firmware fiels copied in there already, so we do not
want to force that for them.
Regards,
Yann E. MORIN.
> $(PACKAGES_LINUX_CONFIG_FIXUPS)
> endef
>
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-30 21:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 6:58 [Buildroot] [PATCH v2 0/5] Lichee RV and Lichee RV dock support Angelo Compagnucci
2022-10-14 6:58 ` [Buildroot] [PATCH v2 1/5] linux: enable CONFIG_EXTRA_FIRMWARE_DIR Angelo Compagnucci
2022-10-30 20:43 ` Thomas Petazzoni via buildroot
2022-10-30 20:52 ` Angelo Compagnucci
2022-10-30 21:23 ` Yann E. MORIN [this message]
2022-10-14 6:58 ` [Buildroot] [PATCH v2 2/5] package/pkg-utils: add KCONFIG_APPEND_OPT Angelo Compagnucci
2022-10-14 6:58 ` [Buildroot] [PATCH v2 3/5] ackage/rtl8723ds-bt: new package Angelo Compagnucci
2022-10-30 20:48 ` Thomas Petazzoni via buildroot
2022-10-30 20:55 ` Angelo Compagnucci
2022-10-30 21:21 ` Yann E. MORIN
2022-10-14 6:58 ` [Buildroot] [PATCH v2 4/5] configs/lichee_rv: new defconfig Angelo Compagnucci
2022-10-14 6:59 ` [Buildroot] [PATCH v2 5/5] configs/lichee_rv_dock: " Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030212333.GI1058960@scaer \
--to=yann.morin.1998@free.fr \
--cc=angelo@amarulasolutions.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox