[Buildroot] [PATCH 1/1] package/lightning; fix build

[Buildroot] [PATCH 1/1] package/lightning; fix build

[Fabrice Fontaine]

Fix the following build failure raised since bump to version 2.2.0 in
commit af6f7aa76db5aed1eada0b27bd0375610a2fc728 and
http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9:

jit_disasm.c: In function 'fprintf_styled':
jit_disasm.c:57:27: error: parameter name omitted
   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
      |                           ^~~~~~
jit_disasm.c:57:35: error: parameter name omitted
   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 .../0001-lib-jit_disasm.c-fix-build.patch     | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 package/lightning/0001-lib-jit_disasm.c-fix-build.patch

diff --git a/package/lightning/0001-lib-jit_disasm.c-fix-build.patch b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
new file mode 100644
index 0000000000..f0bedc1817
--- /dev/null
+++ b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
@@ -0,0 +1,41 @@
+From 6d3ba4fb38ef3af61d8b7fc5c7781ed244ccf9fe Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Mon, 19 Dec 2022 23:36:48 +0100
+Subject: [PATCH] lib/jit_disasm.c: fix build
+
+Fix the following build failure raised since
+http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9:
+
+jit_disasm.c: In function 'fprintf_styled':
+jit_disasm.c:57:27: error: parameter name omitted
+   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
+      |                           ^~~~~~
+jit_disasm.c:57:35: error: parameter name omitted
+   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
+      |                                   ^~~~~~~~~~~~~~~~~~~~~~~
+
+Fixes:
+ - http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: sent to lightning@gnu.org]
+---
+ lib/jit_disasm.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/jit_disasm.c b/lib/jit_disasm.c
+index 58a269b..68c966d 100644
+--- a/lib/jit_disasm.c
++++ b/lib/jit_disasm.c
+@@ -54,7 +54,7 @@ static FILE			 *disasm_stream;
+ #endif
+ 
+ #if BINUTILS_2_38
+-static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
++static int fprintf_styled(void * stream, enum disassembler_style style, const char* fmt, ...)
+ {
+   va_list args;
+   int r;
+-- 
+2.35.1
+
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/lightning; fix build

[Yann E. MORIN]

Fabrice, All,

On 2022-12-19 23:58 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since bump to version 2.2.0 in
> commit af6f7aa76db5aed1eada0b27bd0375610a2fc728 and
> http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9:
> 
> jit_disasm.c: In function 'fprintf_styled':
> jit_disasm.c:57:27: error: parameter name omitted
>    57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
>       |                           ^~~~~~
> jit_disasm.c:57:35: error: parameter name omitted
>    57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../0001-lib-jit_disasm.c-fix-build.patch     | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> 
> diff --git a/package/lightning/0001-lib-jit_disasm.c-fix-build.patch b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> new file mode 100644
> index 0000000000..f0bedc1817
> --- /dev/null
> +++ b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> @@ -0,0 +1,41 @@
> +From 6d3ba4fb38ef3af61d8b7fc5c7781ed244ccf9fe Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Mon, 19 Dec 2022 23:36:48 +0100
> +Subject: [PATCH] lib/jit_disasm.c: fix build
> +
> +Fix the following build failure raised since
> +http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9:
> +
> +jit_disasm.c: In function 'fprintf_styled':
> +jit_disasm.c:57:27: error: parameter name omitted
> +   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> +      |                           ^~~~~~
> +jit_disasm.c:57:35: error: parameter name omitted
> +   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> +      |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status: sent to lightning@gnu.org]
> +---
> + lib/jit_disasm.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/lib/jit_disasm.c b/lib/jit_disasm.c
> +index 58a269b..68c966d 100644
> +--- a/lib/jit_disasm.c
> ++++ b/lib/jit_disasm.c
> +@@ -54,7 +54,7 @@ static FILE			 *disasm_stream;
> + #endif
> + 
> + #if BINUTILS_2_38
> +-static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> ++static int fprintf_styled(void * stream, enum disassembler_style style, const char* fmt, ...)

Should it be marked with  __attribute__((unused))  or some such?

Regards,
Yann E. MORIN.

> + {
> +   va_list args;
> +   int r;
> +-- 
> +2.35.1
> +
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/lightning; fix build

[Fabrice Fontaine]

[-- Attachment #1.1: Type: text/plain, Size: 4248 bytes --]

Hello,

Le mar. 20 déc. 2022 à 09:47, Yann E. MORIN <yann.morin.1998@free.fr> a
écrit :

> Fabrice, All,
>
> On 2022-12-19 23:58 +0100, Fabrice Fontaine spake thusly:
> > Fix the following build failure raised since bump to version 2.2.0 in
> > commit af6f7aa76db5aed1eada0b27bd0375610a2fc728 and
> >
> http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9
> :
> >
> > jit_disasm.c: In function 'fprintf_styled':
> > jit_disasm.c:57:27: error: parameter name omitted
> >    57 | static int fprintf_styled(void *, enum disassembler_style, const
> char* fmt, ...)
> >       |                           ^~~~~~
> > jit_disasm.c:57:35: error: parameter name omitted
> >    57 | static int fprintf_styled(void *, enum disassembler_style, const
> char* fmt, ...)
> >       |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes:
> >  -
> http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  .../0001-lib-jit_disasm.c-fix-build.patch     | 41 +++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >  create mode 100644
> package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> >
> > diff --git a/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> > new file mode 100644
> > index 0000000000..f0bedc1817
> > --- /dev/null
> > +++ b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> > @@ -0,0 +1,41 @@
> > +From 6d3ba4fb38ef3af61d8b7fc5c7781ed244ccf9fe Mon Sep 17 00:00:00 2001
> > +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > +Date: Mon, 19 Dec 2022 23:36:48 +0100
> > +Subject: [PATCH] lib/jit_disasm.c: fix build
> > +
> > +Fix the following build failure raised since
> > +
> http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9
> :
> > +
> > +jit_disasm.c: In function 'fprintf_styled':
> > +jit_disasm.c:57:27: error: parameter name omitted
> > +   57 | static int fprintf_styled(void *, enum disassembler_style,
> const char* fmt, ...)
> > +      |                           ^~~~~~
> > +jit_disasm.c:57:35: error: parameter name omitted
> > +   57 | static int fprintf_styled(void *, enum disassembler_style,
> const char* fmt, ...)
> > +      |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> > +
> > +Fixes:
> > + -
> http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
> > +
> > +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > +[Upstream status: sent to lightning@gnu.org]
> > +---
> > + lib/jit_disasm.c | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/lib/jit_disasm.c b/lib/jit_disasm.c
> > +index 58a269b..68c966d 100644
> > +--- a/lib/jit_disasm.c
> > ++++ b/lib/jit_disasm.c
> > +@@ -54,7 +54,7 @@ static FILE                         *disasm_stream;
> > + #endif
> > +
> > + #if BINUTILS_2_38
> > +-static int fprintf_styled(void *, enum disassembler_style, const char*
> fmt, ...)
> > ++static int fprintf_styled(void * stream, enum disassembler_style
> style, const char* fmt, ...)
>
> Should it be marked with  __attribute__((unused))  or some such?
>

Indeed, I'll send a v2.


>
> Regards,
> Yann E. MORIN.
>
> > + {
> > +   va_list args;
> > +   int r;
> > +--
> > +2.35.1
> > +
> > --
> > 2.35.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>

Best Regards,

Fabrice

[-- Attachment #1.2: Type: text/html, Size: 6363 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/lightning; fix build

[Yann E. MORIN]

FAbrice, All,

On 2022-12-20 09:52 +0100, Fabrice Fontaine spake thusly:
> Le mar. 20 déc. 2022 à 09:47, Yann E. MORIN < [1]yann.morin.1998@free.fr> a écrit :
>   On 2022-12-19 23:58 +0100, Fabrice Fontaine spake thusly:
>   > Fix the following build failure raised since bump to version 2.2.0 in
>   > commit af6f7aa76db5aed1eada0b27bd0375610a2fc728 and
[--SNIP--]
>   > + #if BINUTILS_2_38
>   > +-static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
>   > ++static int fprintf_styled(void * stream, enum disassembler_style style, const char* fmt, ...)
>   Should it be marked with  __attribute__((unused))  or some such?
> Indeed, I'll send a v2.

And even beter yet: change the code to actually use the stream:

    -  r = vprintf(fmt, args);
    +  r = vfprintf(stream, fmt, args);

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/lightning; fix build

[Yann E. MORIN]

Fabrice, All,

On 2022-12-19 23:58 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since bump to version 2.2.0 in
> commit af6f7aa76db5aed1eada0b27bd0375610a2fc728 and
> http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9:
> 
> jit_disasm.c: In function 'fprintf_styled':
> jit_disasm.c:57:27: error: parameter name omitted
>    57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
>       |                           ^~~~~~
> jit_disasm.c:57:35: error: parameter name omitted
>    57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../0001-lib-jit_disasm.c-fix-build.patch     | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> 
> diff --git a/package/lightning/0001-lib-jit_disasm.c-fix-build.patch b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> new file mode 100644
> index 0000000000..f0bedc1817
> --- /dev/null
> +++ b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> @@ -0,0 +1,41 @@
> +From 6d3ba4fb38ef3af61d8b7fc5c7781ed244ccf9fe Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Mon, 19 Dec 2022 23:36:48 +0100
> +Subject: [PATCH] lib/jit_disasm.c: fix build
> +
> +Fix the following build failure raised since
> +http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9:
> +
> +jit_disasm.c: In function 'fprintf_styled':
> +jit_disasm.c:57:27: error: parameter name omitted
> +   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> +      |                           ^~~~~~
> +jit_disasm.c:57:35: error: parameter name omitted
> +   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> +      |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status: sent to lightning@gnu.org]

Although I think we could have been a better fix, this has now been
applied upstream, so we can just argue that any remaining issue will
have to be fixed with another (set of) patches.

Applied to master after making it a proper backport, thanks.

Regards,
Yann E. MORIN.

> +---
> + lib/jit_disasm.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/lib/jit_disasm.c b/lib/jit_disasm.c
> +index 58a269b..68c966d 100644
> +--- a/lib/jit_disasm.c
> ++++ b/lib/jit_disasm.c
> +@@ -54,7 +54,7 @@ static FILE			 *disasm_stream;
> + #endif
> + 
> + #if BINUTILS_2_38
> +-static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> ++static int fprintf_styled(void * stream, enum disassembler_style style, const char* fmt, ...)
> + {
> +   va_list args;
> +   int r;
> +-- 
> +2.35.1
> +
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot