Re: [Buildroot] [PATCH v2 3/4] package/fail2ban: bump version to 1.1.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Fiona,

On Thu,  4 Jul 2024 14:13:51 +0200
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
> 
> Fail2ban 1.1.0 brings Python 3.12 compatibility, and removes support
> for 2.x. This means 2to3 handling can be dropped.
> 
> Unfortunately fail2ban 1.1.0 still relies on asynchat and asyncore,
> which have been removed from the Python standard library in
> 3.12. Depend on the compatibility package python-pyasynchat (which
> pulls in python-pyasyncore) and remove copies bundled in upstream
> code.

Thanks for the detailed commit log. One question below, though.

> -FAIL2BAN_VERSION = 1.0.2
> +FAIL2BAN_VERSION = 1.1.0
>  FAIL2BAN_SITE = $(call github,fail2ban,fail2ban,$(FAIL2BAN_VERSION))
>  FAIL2BAN_LICENSE = GPL-2.0+
>  FAIL2BAN_LICENSE_FILES = COPYING
>  FAIL2BAN_CPE_ID_VENDOR = fail2ban
>  FAIL2BAN_SELINUX_MODULES = fail2ban
>  FAIL2BAN_SETUP_TYPE = setuptools
> +FAIL2BAN_DEPENDENCIES = host-python3 python-pyasynchat

Why are you adding host-python3 in the dependencies here?

Also, are you sure python-pyasynchat is a build time dependency, and
not just a runtime dependency? If that's the case, then you need to
kept the select in the Config.in file (with a comment # runtime), but
not have it as a build-time dependency in fail2ban.mk.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot